fix(azure): align non-spot location handling with AWS pattern

- Fix DefaultHostingPlace() to return an error when neither
  ARM_LOCATION_NAME nor AZURE_DEFAULTS_LOCATION is set, matching
  AWS behavior (fail at mc.Init() rather than later)
- Fix allocation.go non-spot path to fall back to mCtx.TargetHostingPlace()
  when args.Location is empty, so ARM_LOCATION_NAME is respected
- Return a clear error if no compute sizes match the resolved location
- Remove dead commented Location line from rhel-ai action

Co-Authored-By: Claude <Sonnet 4.6> <noreply@anthropic.com>
Signed-off-by: Rishabh Kothari <rkothari@redhat.com>

Author: 2 people

pkg/provider/azure/action/rhel-ai/rhelai.go

@@ -42,8 +42,7 @@ func Create(mCtxArgs *maptContext.ContextArgs, args *apiRHELAI.RHELAIArgs) (err
 	}
 	azureLinuxRequest :=
 		&azureLinux.LinuxArgs{
-			Prefix: args.Prefix,
-			// Location:         args.Location,
+			Prefix:         args.Prefix,
 			ComputeRequest: args.ComputeRequest,
 			Spot:           args.Spot,
 			ImageRef: &data.ImageReference{

pkg/provider/azure/azure.go

@@ -42,8 +42,7 @@ func (a *Azure) DefaultHostingPlace() (*string, error) {
 	if len(hp) > 0 {
 		return &hp, nil
 	}
-	logging.Infof("missing default value for Azure Location, if needed it should set using ARM_LOCATION_NAME or AZURE_DEFAULTS_LOCATION")
-	return nil, nil
+	return nil, fmt.Errorf("missing default value for Azure Location, set ARM_LOCATION_NAME or AZURE_DEFAULTS_LOCATION environment variable")
 }
 
 // Envs required for auth with go sdk

pkg/provider/azure/modules/allocation/allocation.go

@@ -1,6 +1,8 @@
 package allocation
 
 import (
+	"fmt"
+
 	mc "github.com/redhat-developer/mapt/pkg/manager/context"
 	cr "github.com/redhat-developer/mapt/pkg/provider/api/compute-request"
 	spotTypes "github.com/redhat-developer/mapt/pkg/provider/api/spot"
@@ -55,15 +57,26 @@ func Allocation(mCtx *mc.Context, args *AllocationArgs) (*AllocationResult, erro
 		}, nil
 
 	} else {
+		location := args.Location
+		if location == nil || *location == "" {
+			hp := mCtx.TargetHostingPlace()
+			if hp == "" {
+				return nil, fmt.Errorf("location is required for non-spot allocation: set ARM_LOCATION_NAME or AZURE_DEFAULTS_LOCATION environment variable")
+			}
+			location = &hp
+		}
 		// Filter for current location the computesizes
 		supportedComputeSizes, err := data.FilterComputeSizesByLocation(
-			mCtx.Context(), args.Location, computeSizes)
+			mCtx.Context(), location, computeSizes)
 		if err != nil {
 			return nil, err
 		}
+		if len(supportedComputeSizes) == 0 {
+			return nil, fmt.Errorf("no compute sizes available for location %q", *location)
+		}
 		return &AllocationResult{
 			ImageRef:     args.ImageRef,
-			Location:     args.Location,
+			Location:     location,
 			ComputeSizes: supportedComputeSizes,
 		}, nil