feat(profile): add --operator-channel and --catalog-source flags#806
feat(profile): add --operator-channel and --catalog-source flags#806jangel97 wants to merge 1 commit into
Conversation
|
Warning Review limit reached
More reviews will be available in 38 minutes and 19 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThis PR adds CLI support for per-operator OLM customization in OpenShift SNC deployments. Users can override individual operator subscription channels and provide custom CatalogSource index images, which are provisioned as Kubernetes custom resources before profile deployment begins. ChangesOperator and CatalogSource Overrides
🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4ee0615 to
3c0fd15
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/aws/openshift-snc.md`:
- Around line 88-98: The fenced code blocks showing the commands (e.g., the
block with "mapt aws openshift-snc create" and the block with
"--operator-channel serverless-operator=preview,nfd=4.17") are missing language
specifiers; update each triple-backtick fence to include "bash" (```bash) so the
two blocks that contain the mapt aws openshift-snc create command and the
operator-channel example are annotated for proper syntax highlighting and to
satisfy MD040.
- Around line 104-117: Add the missing language specifier to both fenced code
blocks by marking them as bash to satisfy markdownlint MD040; update the two
code fences that show the "mapt aws openshift-snc create" examples (the
single-profile example using flags like --profile and --catalog-source, and the
combined example using --profile, --operator-channel and --catalog-source) to
start with ```bash so the commands are rendered with shell syntax highlighting.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: 74225bc6-e2fc-444a-8d43-dd1ae0909fb9
📒 Files selected for processing (6)
cmd/mapt/cmd/aws/services/snc.godocs/aws/openshift-snc.mdpkg/provider/aws/action/snc/snc.gopkg/target/service/snc/api.gopkg/target/service/snc/profile/operator.gopkg/target/service/snc/profile/profile.go
Allow overriding the OLM subscription channel and catalog source per operator when creating SNC clusters. This lets QE teams test specific operator versions or custom index images without modifying profile code. Validation runs before any infrastructure is provisioned to fail fast on invalid inputs.
3c0fd15 to
49d12c6
Compare
Summary
--operator-channelflag to override the OLM subscription channel per operator (e.g.--operator-channel serverless-operator=candidate)--catalog-sourceflag to use a custom index image per operator (e.g.--catalog-source nfd=quay.io/my-team/index:test), creating a CatalogSource CR automaticallyinstallOperator()— no profile files need changesTest plan
--operator-channeloverride--catalog-sourceoverride (NFD installed from custom index image hosted on ttl.sh, verified CatalogSource pod running and subscription pointing to custom catalog)