Skip to content

Use DetectVMInstallationsJob.disabled=true property from JDT Debug#898

Merged
rgrunber merged 1 commit intoredhat-developer:masterfrom
rgrunber:fix-oom
Jul 11, 2023
Merged

Use DetectVMInstallationsJob.disabled=true property from JDT Debug#898
rgrunber merged 1 commit intoredhat-developer:masterfrom
rgrunber:fix-oom

Conversation

@rgrunber
Copy link
Copy Markdown
Member

@rgrunber rgrunber commented Jul 11, 2023

  • Automatic JVM detection in JDT Debug seems to have introduced a regression in JDT indexing causing java.lang.OutOfMemory
  • Use Eclipse Temurin for JDK distribution.

See eclipse-jdt/eclipse.jdt.debug#231 for (I believe) the root cause.

Note : The property is just a workaround, and will only apply for the tests, so that they can run. I really suspect this would hit people at runtime. I've imported quarkus projects in vscode-quarkus (with vscode-java) and seen the OOM error. 😐

- Automatic JVM detection in JDT Debug seems to have introduced a
  regression in JDT indexing causing java.lang.OutOfMemory
- Use Eclipse Temurin for JDK distribution.

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@rgrunber rgrunber requested a review from datho7561 July 11, 2023 19:18
@rgrunber rgrunber added the build label Jul 11, 2023
Copy link
Copy Markdown
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works locally for me. Thanks, Roland!

@rgrunber rgrunber merged commit dd9791a into redhat-developer:master Jul 11, 2023
@rgrunber rgrunber deleted the fix-oom branch July 11, 2023 20:30
@rgrunber rgrunber added this to the 0.16.0 milestone Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants