Use DetectVMInstallationsJob.disabled=true property from JDT Debug#898
Merged
rgrunber merged 1 commit intoredhat-developer:masterfrom Jul 11, 2023
Merged
Use DetectVMInstallationsJob.disabled=true property from JDT Debug#898rgrunber merged 1 commit intoredhat-developer:masterfrom
rgrunber merged 1 commit intoredhat-developer:masterfrom
Conversation
- Automatic JVM detection in JDT Debug seems to have introduced a regression in JDT indexing causing java.lang.OutOfMemory - Use Eclipse Temurin for JDK distribution. Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
datho7561
approved these changes
Jul 11, 2023
Contributor
datho7561
left a comment
There was a problem hiding this comment.
Looks good and works locally for me. Thanks, Roland!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See eclipse-jdt/eclipse.jdt.debug#231 for (I believe) the root cause.
Note : The property is just a workaround, and will only apply for the tests, so that they can run. I really suspect this would hit people at runtime. I've imported quarkus projects in vscode-quarkus (with vscode-java) and seen the OOM error. 😐