fix: improve deploy step naming and inline trap cleanup

- Rename "Deploy to gh-pages" to "Deploy to the gh-pages branch"
- Inline the trap cleanup to eliminate shellcheck SC2329 suppression

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: themr0c

.github/workflows/build-asciidoc.yml

@@ -50,7 +50,7 @@ jobs:
         echo "Building branch ${{ env.GIT_BRANCH }}"
         build/scripts/build-ccutil.sh -b ${{ env.GIT_BRANCH }}
 
-    - name: Deploy to gh-pages
+    - name: Deploy to the gh-pages branch
       env:
         GITHUB_TOKEN: ${{ secrets.RHDH_BOT_TOKEN }}
         GITHUB_REPOSITORY: ${{ github.repository }}

build/scripts/deploy-gh-pages.sh

@@ -36,9 +36,7 @@ MAX_RETRIES=3
 RETRY_DELAYS=(0 27 133)
 
 DEPLOY_DIR="$(mktemp -d)"
-# shellcheck disable=SC2329 # invoked via trap
-cleanup() { rm -rf "$DEPLOY_DIR"; }
-trap cleanup EXIT
+trap 'rm -rf "$DEPLOY_DIR"' EXIT
 
 cd "$DEPLOY_DIR"
 git init -q