RHIDP-12779: Fix all shellcheck alerts across CQA scripts

- SC1091: Add disable for dynamic source paths
- SC2329: Suppress for callback/helper functions invoked indirectly
- SC2034: Suppress for variables used by sourcing scripts (CQA_FORMAT, CQA_OUTPUT_FORMAT, CQA_DELEGATES_TO)
- SC2155: Separate local declarations from assignments
- SC2318: Split combined local declarations
- SC2004: Remove unnecessary $ in arithmetic expressions
- SC2094: Suppress false positive for cqa_is_in_block (reads cached data)
- SC2001: Replace sed with parameter expansion for CQA number extraction
- Remove unused variables (level, file_fixed, need_ar_fix)
- Rename loop variable to avoid shadowing function parameter (target -> delegate_to)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: themr0c

build/scripts/cqa-00-orphaned-modules.sh

@@ -13,19 +13,21 @@
 #
 # Autofix (--fix): Deletes orphaned files (git rm if tracked, rm otherwise)
 
+# shellcheck disable=SC1091
 source "$(dirname "${BASH_SOURCE[0]}")/cqa-lib.sh"
 
 # Custom arg parsing: accept standard flags but don't require a target file
 CQA_FIX_MODE=false
+# shellcheck disable=SC2034  # CQA_FORMAT/CQA_FIX_MODE used by cqa-lib output functions
 CQA_FORMAT="checklist"
+# shellcheck disable=SC2034
 for arg in "$@"; do
     case "$arg" in
         --fix)         CQA_FIX_MODE=true ;;
         --all)         ;; # accepted, ignored (always scans everything)
         --format=*)    CQA_FORMAT="${arg#--format=}" ;;
         --format)      ;; # next arg handled below
         checklist|json)
-            # Could be the value after --format
             if [[ "${_prev_arg:-}" == "--format" ]]; then
                 CQA_FORMAT="$arg"
             fi

build/scripts/cqa-01-asciidoctor-dita-vale.sh

@@ -16,13 +16,16 @@
 #   - ShortDescription -> CQA #8
 #   - DocumentId -> CQA #10
 
+# shellcheck disable=SC1091
 source "$(dirname "${BASH_SOURCE[0]}")/cqa-lib.sh"
 cqa_parse_args "$0" "$@"
 
+# shellcheck disable=SC2034  # Used by delegation framework
 CQA_DELEGATES_TO=("ShortDescription:8" "DocumentId:10")
 
 [[ -f ".vale-dita-only.ini" ]] || { echo "Error: .vale-dita-only.ini not found" >&2; exit 1; }
 
+# shellcheck disable=SC2329  # Invoked indirectly via cqa_run_for_each_title
 _cqa01_check() {
     local target="$1"
 
@@ -185,11 +188,11 @@ try:
                 kind = 'manual'
             print(f\"{f}\t{i['Line']}\t{kind}\t{target}\t{fix_type}\t{check}: {i['Message']}\")
 except: pass
-" 2>/dev/null | while IFS=$'\t' read -r file line kind target fix_type message; do
+" 2>/dev/null | while IFS=$'\t' read -r file line kind delegate_to fix_type message; do
             case "$kind" in
                 autofix) cqa_fail_autofix "$file" "$line" "$message" ;;
                 manual)  cqa_fail_manual "$file" "$line" "$message" ;;
-                delegated) cqa_delegated "$file" "$line" "$target" "$message" "$fix_type" ;;
+                delegated) cqa_delegated "$file" "$line" "$delegate_to" "$message" "$fix_type" ;;
             esac
         done
     else

build/scripts/cqa-02-assembly-structure.sh

@@ -17,23 +17,27 @@
 # Autofix: content type, context save/restore, ID suffix, :context:, prerequisites heading,
 #          additional resources format
 
+# shellcheck disable=SC1091
 source "$(dirname "${BASH_SOURCE[0]}")/cqa-lib.sh"
 cqa_parse_args "$0" "$@"
 
-# Helper: get line number of first match
+# shellcheck disable=SC2329
 _lineno() { grep -n "$1" "$2" 2>/dev/null | head -1 | cut -d: -f1; }
 
+# shellcheck disable=SC2329
 _fix_content_type_first_line() {
     local file="$1"
     sed -i '/^:_mod-docs-content-type:/d' "$file"
     sed -i '1s/^/:_mod-docs-content-type: ASSEMBLY\n/' "$file"
 }
 
+# shellcheck disable=SC2329
 _fix_add_context_save() {
     local file="$1"
     sed -i '1a\ifdef::context[:parent-context: {context}]' "$file"
 }
 
+# shellcheck disable=SC2329
 _fix_add_context_restore() {
     local file="$1"
     sed -i '/^ifdef::parent-context\[:context: {parent-context}\]$/d' "$file"
@@ -42,6 +46,7 @@ _fix_add_context_restore() {
     printf '\nifdef::parent-context[:context: {parent-context}]\nifndef::parent-context[:!context:]\n' >> "$file"
 }
 
+# shellcheck disable=SC2329
 _fix_context_line() {
     local file="$1" title_ln="$2"
     sed -i '/^:context:/d' "$file"
@@ -52,6 +57,7 @@ _fix_context_line() {
     fi
 }
 
+# shellcheck disable=SC2329
 _cqa02_check() {
     local target="$1"
 
@@ -74,7 +80,8 @@ _cqa02_check() {
         [[ -f "$file" ]] || continue
 
         cqa_file_start "$file"
-        local is_master=$([[ "$(basename "$file")" == "master.adoc" ]] && echo true || echo false)
+        local is_master
+        is_master=$([[ "$(basename "$file")" == "master.adoc" ]] && echo true || echo false)
 
         # Check 1: Content type on first line
         local first_line
@@ -205,7 +212,6 @@ _cqa02_check() {
         fi
 
         # Check 9: Additional resources format
-        local need_ar_fix=false
         if grep -q "^\.Additional resources" "$file"; then
             local ar_ln
             ar_ln=$(_lineno "^\.Additional resources" "$file")

build/scripts/cqa-03-content-is-modularized.sh

@@ -11,10 +11,11 @@
 #   - Adds/fixes content type metadata
 #   - Normalizes section list formatting
 
+# shellcheck disable=SC1091
 source "$(dirname "${BASH_SOURCE[0]}")/cqa-lib.sh"
 cqa_parse_args "$0" "$@"
 
-# Detect content type from file content and filename
+# shellcheck disable=SC2329  # Helper functions invoked from _cqa03_check
 _detect_content_type() {
     local file="$1"
     local bn
@@ -40,19 +41,19 @@ _detect_content_type() {
     esac
 }
 
-# Count occurrences of content type metadata
+# shellcheck disable=SC2329
 _count_type_occurrences() {
     grep -c "^:_mod-docs-content-type:" "$1" 2>/dev/null || echo "0"
 }
 
-# Fix content type metadata
+# shellcheck disable=SC2329
 _fix_content_type() {
     local file="$1" type="$2"
     sed -i '/^:_mod-docs-content-type:/d' "$file"
     sed -i "1s/^/:_mod-docs-content-type: ${type}\n\n/" "$file"
 }
 
-# Fix list formatting in a section (.Procedure or .Verification)
+# shellcheck disable=SC2329
 _fix_section_lists() {
     local file="$1" section="$2"
 
@@ -100,6 +101,7 @@ _fix_section_lists() {
     return 0
 }
 
+# shellcheck disable=SC2329  # Invoked indirectly via cqa_run_for_each_title
 _cqa03_check() {
     local target="$1"
 

build/scripts/cqa-04-modules-use-official-templates.sh

@@ -20,9 +20,11 @@
 #   - ASSEMBLY and SNIPPET files
 #   - master.adoc and attributes.adoc files
 
+# shellcheck disable=SC1091
 source "$(dirname "${BASH_SOURCE[0]}")/cqa-lib.sh"
 cqa_parse_args "$0" "$@"
 
+# shellcheck disable=SC2329  # Invoked indirectly via cqa_run_for_each_title
 _cqa04_check() {
     local target="$1"
 

build/scripts/cqa-05-modular-elements-checklist.sh

@@ -17,11 +17,13 @@
 #   - Removes admonition titles
 #   - Adds missing image alt text quotes
 
+# shellcheck disable=SC1091
 source "$(dirname "${BASH_SOURCE[0]}")/cqa-lib.sh"
 cqa_parse_args "$0" "$@"
 
 readonly PATTERN_BLOCK_TITLE='^\.[A-Z]'
 
+# shellcheck disable=SC2329  # Invoked indirectly via cqa_run_for_each_title
 _cqa05_check() {
     local target="$1"
 

build/scripts/cqa-06-assemblies-use-the-official-template-assemblies-ar.sh

@@ -17,9 +17,11 @@
 #   - Non-assembly files (PROCEDURE, CONCEPT, REFERENCE, SNIPPET)
 #   - attributes.adoc files
 
+# shellcheck disable=SC1091
 source "$(dirname "${BASH_SOURCE[0]}")/cqa-lib.sh"
 cqa_parse_args "$0" "$@"
 
+# shellcheck disable=SC2329  # Invoked indirectly via cqa_run_for_each_title
 _cqa06_check() {
     local target="$1"
 

build/scripts/cqa-07-toc-max-3-levels.sh

@@ -15,9 +15,11 @@
 #   - Content inside source/listing blocks (----, ....)
 #   - attributes.adoc files
 
+# shellcheck disable=SC1091
 source "$(dirname "${BASH_SOURCE[0]}")/cqa-lib.sh"
 cqa_parse_args "$0" "$@"
 
+# shellcheck disable=SC2329  # Invoked indirectly via cqa_run_for_each_title
 _cqa07_check() {
     local target="$1"
 
@@ -35,10 +37,10 @@ _cqa07_check() {
         local violation_line_nums=()
         local line_num=0
 
+        # shellcheck disable=SC2094  # cqa_is_in_block reads cached data, not $file
         while IFS= read -r line; do
             line_num=$((line_num + 1))
 
-            # Skip content inside blocks
             if cqa_is_in_block "$file" "$line_num"; then
                 continue
             fi

build/scripts/cqa-08-short-description-content.sh

@@ -16,6 +16,7 @@
 #   - SNIPPET files
 #   - attributes.adoc and master.adoc files
 
+# shellcheck disable=SC1091
 source "$(dirname "${BASH_SOURCE[0]}")/cqa-lib.sh"
 cqa_parse_args "$0" "$@"
 
@@ -49,6 +50,7 @@ SELF_REF_REMOVABLE=(
     "In this section, we "
 )
 
+# shellcheck disable=SC2329  # Invoked indirectly via cqa_run_for_each_title
 _cqa08_check() {
     local target="$1"
 

build/scripts/cqa-09-short-description-format.sh

@@ -16,9 +16,11 @@
 # Skips:
 #   - SNIPPET files
 
+# shellcheck disable=SC1091
 source "$(dirname "${BASH_SOURCE[0]}")/cqa-lib.sh"
 cqa_parse_args "$0" "$@"
 
+# shellcheck disable=SC2329  # Invoked indirectly via cqa_run_for_each_title
 _cqa09_check() {
     local target="$1"