Skip to content

RHIDP-11447: Conditional permissions for Scorecards#1765

Merged
deerskindoll merged 5 commits into
redhat-developer:mainfrom
pabel-rh:rhidp-11447
Feb 16, 2026
Merged

RHIDP-11447: Conditional permissions for Scorecards#1765
deerskindoll merged 5 commits into
redhat-developer:mainfrom
pabel-rh:rhidp-11447

Conversation

@pabel-rh
Copy link
Copy Markdown
Member

@pabel-rh pabel-rh commented Feb 9, 2026 •
edited
Loading

IMPORTANT: Do Not Merge - To be merged by Docs Team Only

Version(s):
main, 1.9.0
Issue:
RHIDP-11447
Preview:
https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1765/scorecard-plugin/#assembly-configuring-scorecards-in-rhdh

@pabel-rh pabel-rh requested a review from dzemanov February 9, 2026 08:32
@rhdh-bot
Copy link
Copy Markdown
Collaborator

rhdh-bot commented Feb 9, 2026 •
edited
Loading

Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1765/ @ 02/16/26 15:22:28

dzemanov
dzemanov suggested changes Feb 9, 2026
View reviewed changes
Comment thread modules/observe/scorecards/proc-installing-and-configuring-scorecard.adoc Outdated
Comment thread modules/observe/scorecards/proc-installing-and-configuring-scorecard.adoc Outdated
dzemanov
dzemanov suggested changes Feb 9, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@dzemanov dzemanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, I have only a couple of suggestions.

@pabel-rh pabel-rh requested a review from dzemanov February 10, 2026 09:48
dzemanov
dzemanov suggested changes Feb 11, 2026
View reviewed changes
Comment thread modules/observe/scorecards/proc-installing-and-configuring-scorecard.adoc Outdated
@pabel-rh pabel-rh requested a review from dzemanov February 16, 2026 06:28
dzemanov
dzemanov suggested changes Feb 16, 2026
View reviewed changes
Comment thread modules/observe/scorecards/proc-installing-and-configuring-scorecard.adoc Outdated
@pabel-rh pabel-rh added Technical review done ⛅ Any procedure has been succesfully tested and removed Technical review needed 🔩 Test all the procedures labels Feb 16, 2026
jmagak
jmagak reviewed Feb 16, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jmagak jmagak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions.

Comment thread modules/observe/scorecards/proc-installing-and-configuring-scorecard.adoc Outdated
Comment thread modules/observe/scorecards/proc-installing-and-configuring-scorecard.adoc Outdated
Comment thread modules/observe/scorecards/proc-installing-and-configuring-scorecard.adoc Outdated
Comment thread modules/observe/scorecards/proc-installing-and-configuring-scorecard.adoc Outdated
Comment thread modules/observe/scorecards/proc-installing-and-configuring-scorecard.adoc
Comment thread modules/observe/scorecards/proc-installing-and-configuring-scorecard.adoc Outdated
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 16, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pabel-rh
Copy link
Copy Markdown
Member Author

pabel-rh commented Feb 16, 2026

/cherry-pick release-1.9

@openshift-cherrypick-robot
Copy link
Copy Markdown
Contributor

openshift-cherrypick-robot commented Feb 16, 2026

@pabel-rh: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@deerskindoll deerskindoll merged commit 7724c7e into redhat-developer:main Feb 16, 2026
6 checks passed
@openshift-cherrypick-robot
Copy link
Copy Markdown
Contributor

openshift-cherrypick-robot commented Feb 16, 2026

@pabel-rh: new pull request created: #1795

Details

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 16, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagak jmagak jmagak approved these changes

+1 more reviewer

@dzemanov dzemanov dzemanov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Peer review done 📘 Ready to merge 💂 Technical review done ⛅ Any procedure has been succesfully tested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pabel-rh @rhdh-bot @openshift-cherrypick-robot @dzemanov @jmagak @deerskindoll