Skip to content

RHDHBUGS-942 RBAC REST API DELETE request requires a JSON body#1766

Merged
themr0c merged 15 commits into
redhat-developer:mainfrom
themr0c:RHDHBUGS-942-RBAC-REST-API-DELETE-requests-need-a-body
Feb 10, 2026
Merged

RHDHBUGS-942 RBAC REST API DELETE request requires a JSON body#1766
themr0c merged 15 commits into
redhat-developer:mainfrom
themr0c:RHDHBUGS-942-RBAC-REST-API-DELETE-requests-need-a-body

Conversation

@themr0c
Copy link
Copy Markdown
Member

@themr0c themr0c commented Feb 9, 2026

RBAC REST API DELETE request requires a JSON body

Version(s): main, release-1.9

Issue: https://issues.redhat.com/browse/RHDHBUGS-942

@themr0c
RHDHBUGS-942 RBAC REST API DELETE request requires a JSON body
ee92429 
Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
@themr0c themr0c requested a review from PatAKnight February 9, 2026 10:41
@rhdh-bot
Copy link
Copy Markdown
Collaborator

rhdh-bot commented Feb 9, 2026 •
edited
Loading

Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1766/ @ 02/10/26 14:35:23

pabel-rh
pabel-rh approved these changes Feb 9, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@pabel-rh pabel-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a minor comment.

Comment thread modules/authorization/ref-rbac-rest-api-endpoints.adoc Outdated
@themr0c @pabel-rh
Update modules/authorization/ref-rbac-rest-api-endpoints.adoc
190d78e 
Co-authored-by: Priyanka Abel <pabel@redhat.com>
PatAKnight
PatAKnight suggested changes Feb 10, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@PatAKnight PatAKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@themr0c, it looks like the example request bodies were added to the wrong endpoints. The [DELETE] /api/permission/policies/__<kind>__/__<namespace>__/__<name>__:: endpoint is the one that requires the example.

Comment thread modules/authorization/ref-rbac-rest-api-endpoints.adoc Outdated
Comment thread modules/authorization/ref-rbac-rest-api-endpoints.adoc Outdated
@themr0c
fix content
71867fc 
Signed-off-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
themr0c
themr0c commented Feb 10, 2026
View reviewed changes
Comment thread modules/authorization/ref-rbac-rest-api-endpoints.adoc Outdated
themr0c
themr0c commented Feb 10, 2026
View reviewed changes
Comment thread modules/authorization/proc-sending-request-to-the-rbac-rest-api-by-using-curl.adoc Outdated
themr0c
themr0c commented Feb 10, 2026
View reviewed changes
Comment thread modules/authorization/proc-sending-request-to-the-rbac-rest-api-by-using-curl.adoc Outdated
themr0c
themr0c commented Feb 10, 2026
View reviewed changes
Comment thread modules/authorization/ref-rbac-rest-api-endpoints.adoc Outdated
themr0c
themr0c commented Feb 10, 2026
View reviewed changes
Comment thread modules/authorization/proc-sending-request-to-the-rbac-rest-api-by-using-curl.adoc Outdated
themr0c
themr0c commented Feb 10, 2026
View reviewed changes
Comment thread modules/authorization/ref-rbac-rest-api-endpoints.adoc Outdated
PatAKnight
PatAKnight approved these changes Feb 10, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@PatAKnight PatAKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

themr0c
themr0c commented Feb 10, 2026
View reviewed changes
Comment thread modules/authorization/proc-sending-request-to-the-rbac-rest-api-by-using-curl.adoc Outdated
themr0c
themr0c commented Feb 10, 2026
View reviewed changes
Comment thread modules/authorization/proc-sending-request-to-the-rbac-rest-api-by-using-curl.adoc Outdated
themr0c
themr0c commented Feb 10, 2026
View reviewed changes
Comment thread modules/authorization/proc-sending-request-to-the-rbac-rest-api-by-using-curl.adoc Outdated
themr0c
themr0c commented Feb 10, 2026
View reviewed changes
Comment thread modules/authorization/proc-sending-request-to-the-rbac-rest-api-by-using-curl.adoc Outdated
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 10, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@themr0c themr0c merged commit 5eb3b2d into redhat-developer:main Feb 10, 2026
6 checks passed
@themr0c themr0c deleted the RHDHBUGS-942-RBAC-REST-API-DELETE-requests-need-a-body branch February 10, 2026 14:36
@themr0c
Copy link
Copy Markdown
Member Author

themr0c commented Feb 10, 2026 •
edited
Loading

/cherry-pick release-1.9

1 similar comment
@themr0c
Copy link
Copy Markdown
Member Author

themr0c commented Feb 10, 2026

/cherry-pick release-1.9

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 10, 2026
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown
Contributor

openshift-cherrypick-robot commented Feb 10, 2026

@themr0c: new pull request created: #1783

Details

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pabel-rh pabel-rh pabel-rh approved these changes

+1 more reviewer

@PatAKnight PatAKnight PatAKnight approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Peer review done 📘 Ready to merge 💂 Technical review done ⛅ Any procedure has been succesfully tested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@themr0c @rhdh-bot @openshift-cherrypick-robot @PatAKnight @pabel-rh