Skip to content

RHIDP-12605: Phase 2 Homepage - persona support and related RBAC#2153

Merged
pabel-rh merged 12 commits into
redhat-developer:mainfrom
jmagak:RHIDP-12605-Phase-2-Homepage-persona-support-and-related-RBAC
May 19, 2026
Merged

RHIDP-12605: Phase 2 Homepage - persona support and related RBAC#2153
pabel-rh merged 12 commits into
redhat-developer:mainfrom
jmagak:RHIDP-12605-Phase-2-Homepage-persona-support-and-related-RBAC

Conversation

@jmagak
Copy link
Copy Markdown
Member

@jmagak jmagak commented May 1, 2026 •
edited
Loading

@rhdh-bot
Copy link
Copy Markdown
Collaborator

rhdh-bot commented May 1, 2026 •
edited
Loading

PR Build Results

Build passed -- 34/34 titles | 75s
Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-2153/

Content Quality Assessment

CQA Report

  • CQA-00a: Orphaned modules
  • CQA-00b: Directory structure
  • CQA-01: Vale AsciiDoc DITA compliance
  • CQA-02: Verify assembly structure
  • CQA-03: Verify content type metadata
  • CQA-04: Verify module templates
  • CQA-05: Verify required modular elements
  • CQA-06: Verify assemblies follow official template (one user story)
  • CQA-07: Verify TOC depth (max 3 levels)
  • CQA-08: Verify short description content quality
  • CQA-09: Verify short description format
  • CQA-10: Verify titles are brief, complete, and descriptive
  • CQA-11: Verify procedure prerequisites
  • CQA-12: Verify grammar and style (Vale)
  • CQA-13: Verify content matches declared type
  • CQA-14: Verify no broken links
  • CQA-15: Check redirects
  • CQA-16: Verify official product names
  • CQA-17: Verify legal disclaimers for preview features

Summary

Checks: 19 total, 19 pass, 0 fail

19 checks: 19 pass, 0 fail

Run node build/scripts/cqa/index.js --all --fix locally to review and auto-fix issues.

Updated 2026-05-19 07:56:13 UTC

@jmagak jmagak added the Technical review needed 🔩 Test all the procedures label May 4, 2026
@jmagak jmagak force-pushed the RHIDP-12605-Phase-2-Homepage-persona-support-and-related-RBAC branch from f96146a to 9e18a23 Compare May 4, 2026 17:20
@jmagak jmagak force-pushed the RHIDP-12605-Phase-2-Homepage-persona-support-and-related-RBAC branch from 9e18a23 to 42dfe9f Compare May 5, 2026 10:55
@jmagak jmagak force-pushed the RHIDP-12605-Phase-2-Homepage-persona-support-and-related-RBAC branch from 42dfe9f to 7c1b1aa Compare May 5, 2026 13:49
@jmagak jmagak force-pushed the RHIDP-12605-Phase-2-Homepage-persona-support-and-related-RBAC branch from 7c1b1aa to 1c8d7c1 Compare May 5, 2026 14:15
@jmagak jmagak force-pushed the RHIDP-12605-Phase-2-Homepage-persona-support-and-related-RBAC branch from 1c8d7c1 to 482ac9e Compare May 5, 2026 14:15
@jmagak jmagak requested a review from christoph-jerolimov May 5, 2026 18:01
@jmagak jmagak force-pushed the RHIDP-12605-Phase-2-Homepage-persona-support-and-related-RBAC branch from 482ac9e to 77f15e4 Compare May 6, 2026 11:09
@jmagak jmagak force-pushed the RHIDP-12605-Phase-2-Homepage-persona-support-and-related-RBAC branch from 77f15e4 to 7f67714 Compare May 6, 2026 12:30
@jmagak jmagak force-pushed the RHIDP-12605-Phase-2-Homepage-persona-support-and-related-RBAC branch from 7f67714 to 40f099b Compare May 7, 2026 09:45
@jmagak jmagak force-pushed the RHIDP-12605-Phase-2-Homepage-persona-support-and-related-RBAC branch from 606ac5f to 186ac2b Compare May 11, 2026 12:38
@jmagak jmagak force-pushed the RHIDP-12605-Phase-2-Homepage-persona-support-and-related-RBAC branch from 186ac2b to 5774212 Compare May 11, 2026 16:54
rh-tokeefe
rh-tokeefe approved these changes May 18, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@rh-tokeefe rh-tokeefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmagak I noted a few things for you to consider. LGTM!

Comment thread ...ssembly-deploy-persona-specific-homepages-to-provide-targeted-content-to-distinct-teams.adoc Outdated
Comment thread modules/shared/proc-arrange-homepage-card-layouts-to-optimize-visual-organization.adoc Outdated
Comment thread ...shared/proc-attach-homepages-to-groups-to-control-access-and-automate-layout-assignment.adoc Outdated
Comment thread modules/shared/ref-available-homepage-cards.adoc
Comment thread modules/shared/ref-homepage-backend-configuration-reference.adoc Outdated
Comment thread modules/shared/ref-homepage-visibility-rule-syntax.adoc Outdated
@jmagak jmagak added Technical review done ⛅ Any procedure has been succesfully tested Peer review done 📘 and removed do-no-merge/review-in-progress 👀 Technical review needed 🔩 Test all the procedures labels May 19, 2026
christoph-jerolimov
christoph-jerolimov suggested changes May 19, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small last change. After that this looks good to me. Thanks @jmagak

Comment thread modules/shared/ref-homepage-backend-configuration-reference.adoc Outdated
@jmagak jmagak force-pushed the RHIDP-12605-Phase-2-Homepage-persona-support-and-related-RBAC branch from 5832aad to 2ded028 Compare May 19, 2026 07:53
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 19, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

christoph-jerolimov
christoph-jerolimov approved these changes May 19, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmagak

Lgtm (for SWE)

@pabel-rh pabel-rh merged commit f0c87f6 into redhat-developer:main May 19, 2026
6 checks passed
@pabel-rh
Copy link
Copy Markdown
Member

pabel-rh commented May 19, 2026

/cherry-pick release-1.10

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 19, 2026
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown
Contributor

openshift-cherrypick-robot commented May 19, 2026

@pabel-rh: new pull request created: #2219

Details

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rh-tokeefe rh-tokeefe rh-tokeefe approved these changes

@karthikjeeyar karthikjeeyar Awaiting requested review from karthikjeeyar

+1 more reviewer

@christoph-jerolimov christoph-jerolimov christoph-jerolimov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Peer review done 📘 Technical review done ⛅ Any procedure has been succesfully tested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jmagak @rhdh-bot @pabel-rh @openshift-cherrypick-robot @christoph-jerolimov @rh-tokeefe