RHIDP-13914: Update RHDH documentation for removal of 'global-floating-action-button' plugin#2463
Open
jmagak wants to merge 2 commits into
Conversation
Collaborator
PR Build ResultsBuild passed -- 36/36 titles | 104s Content Quality AssessmentCQA Report
SummaryChecks: 22 total, 22 pass, 0 fail 22 checks: 22 pass, 0 fail Run Updated 2026-07-07 17:08:57 UTC |
jmagak
added
do-no-merge/review-in-progress 👀
Technical review needed 🔩
ciiay
suggested changes
Jul 6, 2026
ciiay
left a comment
ciiay
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR 👏
Looking at the changes, the PR is over-aggressively replacing "floating action button (FAB)" with just "button" across the documentation. This creates ambiguity in files related to Lightspeed:
con-chat-assistance-with.adoc— Changes "FAB" to "button" but warns about conflicting buttons. The context is actually about the Lightspeed button, not the removed plugin.proc-configure-by-using-the-helm-chart.adoc,proc-manage-chats.adoc, etc. — All Lightspeed verification steps use generic "button" language, losing clarity about what component is actually being discussed.
What Should Happen
The documentation should distinguish:
- Old FAB plugin references → Remove or replace appropriately
- Lightspeed button references → Keep specific terminology (e.g., "Lightspeed button" or describe it as "the button provided by the Lightspeed plugin") to avoid confusion, especially in the warning about conflicting buttons
jmagak
force-pushed
the
RHIDP-13914-Update-RHDH-documentation-for-removal-of-global-floating-action-button-plugin
branch
from
9ca14f5 to
e72563f
Compare
jmagak
force-pushed
the
RHIDP-13914-Update-RHDH-documentation-for-removal-of-global-floating-action-button-plugin
branch
from
cbf9794 to
73c65ed
Compare
|
New changes are detected. LGTM label has been removed. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s): 2.1.0, main
Issue: RHIDP-15246
Preview: