Added Knative CRDs and Knative CR creation logic (#117)

* Added Knative CRDs and Knative CR creation logic

* Added maintanence guide for CRDs, removed annotations

* CRD disclaimer

* Added Knative CRDs, instructions to update them, and subscription channel

* Chart version bump

* typos, updated README.tmpl

* update github test to installcrds upon upgrade

* applying crds from local dir

* pre-install hooks for namespaces

* adding delete hooks to knative

* Added pre-delete hooks for CRDs

* changing helm hooks in knative resources

Author: elai-shalev

.github/workflows/test.yml

@@ -156,6 +156,10 @@ jobs:
 
       - name: Run chart-testing
         run: |
+          
+          kubectl apply -f charts/orchestrator-infra/crds/knative-eventing/knative-eventing-crd.yaml
+          kubectl apply -f charts/orchestrator-infra/crds/knative-serving/knative-serving-crd.yaml
+
           ct install \
             --debug \
             --config ct-install.yaml \

charts/orchestrator-infra/Chart.yaml

@@ -13,4 +13,4 @@ maintainers:
 type: application
 sources:
   - https://github.com/redhat-developer/rhdh-chart
-version: 0.0.2
+version: 0.0.3

charts/orchestrator-infra/README.md

@@ -1,7 +1,7 @@
 
 # Orchestrator Infra Chart for OpenShift (Community Version)
 
-![Version: 0.0.2](https://img.shields.io/badge/Version-0.0.2-informational?style=flat-square)
+![Version: 0.0.3](https://img.shields.io/badge/Version-0.0.3-informational?style=flat-square)
 ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
 
 Helm chart to deploy the Orchestrator solution's required infrastructure suite on OpenShift, including OpenShift Serverless Logic Operator and OpenShift Serverless Operator.
@@ -90,7 +90,7 @@ The command removes all the Kubernetes components associated with the chart and
 | serverlessLogicOperator.subscription.spec.name | name of the operator package | string | `"logic-operator-rhel8"` |
 | serverlessLogicOperator.subscription.spec.source | name of the catalog source | string | `"redhat-operators"` |
 | serverlessLogicOperator.subscription.spec.sourceNamespace |  | string | `"openshift-marketplace"` |
-| serverlessLogicOperator.subscription.spec.startingCSV | The initial version of the operator | string | `"logic-operator-rhel8.v1.35.0"` |
+| serverlessLogicOperator.subscription.spec.startingCSV | The initial version of the operator, must match CRDs installed by the chart | string | `"logic-operator-rhel8.v1.35.0"` |
 | serverlessOperator.enabled | whether the operator should be deployed by the chart | bool | `true` |
 | serverlessOperator.subscription.namespace | namespace where the operator should be deployed | string | `"openshift-serverless"` |
 | serverlessOperator.subscription.spec.channel | channel of an operator package to subscribe to | string | `"stable"` |
@@ -101,3 +101,17 @@ The command removes all the Kubernetes components associated with the chart and
 | tests.enabled | Whether to create the test pod used for testing the Release using `helm test`. | bool | `true` |
 | tests.image | Test pod image | string | `"bitnami/kubectl:latest"` |
 
+### Installing Knative Eventing and Knative Serving CRDs
+
+The orchestrator-infra chart requires several CRDs for Knative Eventing and Knative Serving. These CRDs will be applied prior to installing the chart, ensuring that Knative CRs can be created as part of the chart's deployment process. This approach eliminates the need to wait for the OpenShift Serverless Operator's subscription to install them beforehand.
+
+The KnativeEventing and KnativeServing CRDs are required for this chart to run. These CRDs need to be present under the crds/ directory before running `helm install`.
+After installing the openshift-serverless subscription, more Knative CRDs will be installed on the cluster.
+
+The versions of the CRDs present in the chart and the ones in the subscrtiprion must match. In order to verify the correct CRD, use this following command to extract the CRD:
+
+```bash
+docker run --rm --entrypoint cat registry.redhat.io/openshift-serverless-1/serverless-operator-bundle:1.35.0 /manifests/operator_v1beta1_knativeeventing_crd.yaml > knative-eventing-crd.yaml
+
+docker run --rm --entrypoint cat registry.redhat.io/openshift-serverless-1/serverless-operator-bundle:1.35.0 /manifests/operator_v1beta1_knativeserving_crd.yaml > knative-serving-crd.yaml
+```

charts/orchestrator-infra/README.md.gotmpl

@@ -75,3 +75,18 @@ helm uninstall my-orchestrator-infra
 The command removes all the Kubernetes components associated with the chart and deletes the release.
 
 {{ template "chart.valuesSection" . }}
+
+### Installing Knative Eventing and Knative Serving CRDs
+
+The orchestrator-infra chart requires several CRDs for Knative Eventing and Knative Serving. These CRDs will be applied prior to installing the chart, ensuring that Knative CRs can be created as part of the chart's deployment process. This approach eliminates the need to wait for the OpenShift Serverless Operator's subscription to install them beforehand.
+
+The KnativeEventing and KnativeServing CRDs are required for this chart to run. These CRDs need to be present under the crds/ directory before running `helm install`. 
+After installing the openshift-serverless subscription, more Knative CRDs will be installed on the cluster. 
+
+The versions of the CRDs present in the chart and the ones in the subscrtiprion must match. In order to verify the correct CRD, use this following command to extract the CRD:
+
+```bash 
+docker run --rm --entrypoint cat registry.redhat.io/openshift-serverless-1/serverless-operator-bundle:1.35.0 /manifests/operator_v1beta1_knativeeventing_crd.yaml > knative-eventing-crd.yaml
+
+docker run --rm --entrypoint cat registry.redhat.io/openshift-serverless-1/serverless-operator-bundle:1.35.0 /manifests/operator_v1beta1_knativeserving_crd.yaml > knative-serving-crd.yaml
+```