Skip to content

chore(ci): simplify Snyk workflow using matrix for chart scans#137

Merged
openshift-merge-bot[bot] merged 6 commits intoredhat-developer:mainfrom
Fortune-Ndlovu:snyk-scan-matrix-job
Apr 25, 2025
Merged

chore(ci): simplify Snyk workflow using matrix for chart scans#137
openshift-merge-bot[bot] merged 6 commits intoredhat-developer:mainfrom
Fortune-Ndlovu:snyk-scan-matrix-job

Conversation

@Fortune-Ndlovu
Copy link
Copy Markdown
Member

@Fortune-Ndlovu Fortune-Ndlovu commented Apr 24, 2025

Description of the change

Refactors the GitHub Actions Snyk workflow to use a matrix job strategy,
allowing independent IaC scans for backstage and orchestrator-infra
charts with minimal duplication.

https://issues.redhat.com/browse/RHIDP-6630

Existing or Associated Issue(s)

Additional Information

  • Adds matrix entries for each chart path/output
  • Uses full commit SHA to pin snyk/actions/iac for security
  • Prepares workflow for easier scaling as more charts are added

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
  • JSON Schema template updated and re-generated the raw schema via pre-commit hook.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
@openshift-ci openshift-ci Bot requested review from davidfestal and nickboldt April 24, 2025 16:49
@Fortune-Ndlovu
Copy link
Copy Markdown
Member Author

cc/ @coreydaley @rm3l for review please

Comment thread .github/workflows/snyk.yaml Outdated
…can testing

Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Comment thread .github/workflows/snyk.yaml Outdated
Comment thread .github/workflows/snyk.yaml Outdated
… from chart name. AND Kept workflow_dispatch so WE can trigger this manually from GitHub.

Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
Signed-off-by: Fortune-Ndlovu <fndlovu@redhat.com>
@sonarqubecloud
Copy link
Copy Markdown

@Fortune-Ndlovu
Copy link
Copy Markdown
Member Author

cc: @rm3l @coreydaley for review please :)

Copy link
Copy Markdown
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Apr 25, 2025
@openshift-merge-bot openshift-merge-bot Bot merged commit eed7951 into redhat-developer:main Apr 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants