Skip to content

chore: add MAX_ENTRY_SIZE var to values + doc change#143

Merged
openshift-merge-bot[bot] merged 1 commit intoredhat-developer:mainfrom
elai-shalev:add/chart-env-var
May 5, 2025
Merged

chore: add MAX_ENTRY_SIZE var to values + doc change#143
openshift-merge-bot[bot] merged 1 commit intoredhat-developer:mainfrom
elai-shalev:add/chart-env-var

Conversation

@elai-shalev
Copy link
Copy Markdown

@elai-shalev elai-shalev commented May 5, 2025

After the conversation on this now closed PR, A new env-var was added to the default backstage values.yaml to allow orchestrator plugin to successfully install.

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
  • JSON Schema template updated and re-generated the raw schema via pre-commit hook.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@elai-shalev elai-shalev requested a review from a team as a code owner May 5, 2025 13:02
@openshift-ci openshift-ci Bot requested review from davidfestal and kadel May 5, 2025 13:02
@elai-shalev
Copy link
Copy Markdown
Author

@rm3l PTAL :)

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 5, 2025

Copy link
Copy Markdown
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label May 5, 2025
@openshift-merge-bot openshift-merge-bot Bot merged commit 0ef375e into redhat-developer:main May 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants