enabling serverless+serverlessLogic by default#155
Merged
openshift-merge-bot[bot] merged 1 commit intoredhat-developer:mainfrom May 12, 2025
Merged
enabling serverless+serverlessLogic by default#155openshift-merge-bot[bot] merged 1 commit intoredhat-developer:mainfrom
openshift-merge-bot[bot] merged 1 commit intoredhat-developer:mainfrom
Conversation
rm3l
reviewed
May 12, 2025
Member
rm3l
left a comment
rm3l
left a comment
There was a problem hiding this comment.
@elai-shalev Can we get 2 different PRs for those 2 different/unrelated issues? It will make more sense IMO in the repo history, and be cleaner in terms of versioning as well. Thanks.
elai-shalev
changed the title
|
Author
Done, the networkPolicy change will be added in another PR |
openshift-merge-bot
Bot
merged commit 3a20cda
into
redhat-developer:main
8 checks passed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will close this ticket by enableing serverless operator and serverlessLogic operator by default in the helm chart values.
Note that the operators will still be deployed conditionally, as 'Orchestrator' needs to be enabled in order to trigger their deployment.
Chart.yamlaccording to semver.values.yamland added to the README.md. The pre-commit utility can be used to generate the necessary content. Usepre-commit run -ato apply changes.pre-commithook.ct lintcommand.