chore: update default chart settings using downstream patches so we can remove Chart_patch.yaml (RHIDP-7529)#163
Merged
openshift-merge-bot[bot] merged 3 commits intorelease-1.6from May 19, 2025
Conversation
…an remove Chart_patch.yaml (RHIDP-7529) Signed-off-by: Nick Boldt <nboldt@redhat.com>
nickboldt
changed the title
nickboldt
commented
May 16, 2025
Signed-off-by: Nick Boldt <nboldt@redhat.com>
|
Member
Author
|
changed chart name back to backstage as per #162 (comment) -> #130 (comment) |
nickboldt
commented
May 16, 2025
|
Looks good to me, @rm3l WDYT about introducing these changes to 1.6? |
rm3l
approved these changes
May 19, 2025
Member
rm3l
left a comment
rm3l
left a comment
There was a problem hiding this comment.
Looks good to me, @rm3l WDYT about introducing these changes to 1.6?
I was initially concerned that it might introduce potential breaking changes (regarding the nameOverride settings that might affect resource naming), but after some more manual upgrade testing, I didn't notice any issues (because the 1.6 released Chart already has the same nameOverride settings). So LGTM.
/lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
chore: update default chart settings using downstream patches so we can remove Chart_patch.yaml (RHIDP-7529)
Signed-off-by: Nick Boldt nboldt@redhat.com
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
N/A (or see commit message above for issue number)
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.