Skip to content

fix: Fix the images used by the Orchestrator DB creation Job#164

Merged
rm3l merged 2 commits intoredhat-developer:mainfrom
rm3l:rhidp-7457-helm-fix-the-images-used-by-the-orchestrator-db-creation-job
May 20, 2025
Merged

fix: Fix the images used by the Orchestrator DB creation Job#164
rm3l merged 2 commits intoredhat-developer:mainfrom
rm3l:rhidp-7457-helm-fix-the-images-used-by-the-orchestrator-db-creation-job

Conversation

@rm3l
Copy link
Copy Markdown
Member

@rm3l rm3l commented May 20, 2025

Description of the change

We should not use container images from Docker Hub. We should also be consistent and use images that have their counterpart available on registry.redhat.io when publishing the Helm Chart.
This PR makes sure to reuse the existing DB image in the Orchestrator DB creation Job. This way, there won't be any impact on our publishing process or our airgap docs.

Existing or Associated Issue(s)

Fixes https://issues.redhat.com/browse/RHIDP-7457

Additional Information

The procedure to install the Orchestrator-flavored RHDH on OpenShift should continue to work.

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
  • JSON Schema template updated and re-generated the raw schema via pre-commit hook.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

/cc @elai-shalev

rm3l added 2 commits May 20, 2025 12:32
By reusing the existing images, we don't need to change our airgap docs, and this would also work with the images used in the downstream chart
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 20, 2025

@rm3l: GitHub didn't allow me to request PR reviews from the following users: elai-shalev.

Note that only redhat-developer members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Description of the change

We should not use container images from Docker Hub. We should also be consistent and use images that have their counterpart available on registry.redhat.io when publishing the Helm Chart.
This PR makes sure to reuse the existing DB image in the Orchestrator DB creation Job. This way, there won't be any impact on our publishing process or our airgap docs.

Existing or Associated Issue(s)

Fixes https://issues.redhat.com/browse/RHIDP-7457

Additional Information

The procedure to install the Orchestrator-flavored RHDH on OpenShift should continue to work.

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
  • JSON Schema template updated and re-generated the raw schema via pre-commit hook.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

/cc @elai-shalev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Copy Markdown

@elai-shalev elai-shalev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one non blocking comment

Comment thread charts/backstage/values.yaml
@rm3l
Copy link
Copy Markdown
Member Author

rm3l commented May 20, 2025

CI failing (not starting at all) because of a billing issue in this org. This issue has been reported and is being investigated. I'll re-trigger the CI once this issue is fixed.

/hold

@rm3l rm3l closed this May 20, 2025
@rm3l rm3l reopened this May 20, 2025
@sonarqubecloud
Copy link
Copy Markdown

@rm3l
Copy link
Copy Markdown
Member Author

rm3l commented May 20, 2025

CI issues fixed - retriggering the jobs..

/hold cancel

@rm3l rm3l merged commit b7e18cd into redhat-developer:main May 20, 2025
8 of 13 checks passed
@rm3l rm3l deleted the rhidp-7457-helm-fix-the-images-used-by-the-orchestrator-db-creation-job branch May 20, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants