Skip to content

chore: bumping osl default version to 1.36 in orchestrator-infra#201

Merged
gazarenkov merged 3 commits intoredhat-developer:mainfrom
elai-shalev:bump-osl-1.6
Aug 7, 2025
Merged

chore: bumping osl default version to 1.36 in orchestrator-infra#201
gazarenkov merged 3 commits intoredhat-developer:mainfrom
elai-shalev:bump-osl-1.6

Conversation

@elai-shalev
Copy link
Copy Markdown

@elai-shalev elai-shalev commented Aug 3, 2025

Description of the change

We need to bump the default OSL version in orchestrator-infra chart, as Orchestrater now requires most recent version.

      startingCSV: logic-operator-rhel8.v1.36.0

Related to this bug:
https://issues.redhat.com/browse/FLPATH-2543

  • For each Chart updated, version bumped in the corresponding Chart.yaml according to Semantic Versioning.
  • For each Chart updated, variables are documented in the values.yaml and added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes. The pre-commit Workflow will do this automatically for you if needed.
  • JSON Schema template updated and re-generated the raw schema via the pre-commit hook.
  • Tests pass using the Chart Testing tool and the ct lint command.
  • If you updated the orchestrator-infra chart, make sure the versions of the Knative CRDs are aligned with the versions of the CRDs installed by the OpenShift Serverless operators declared in the values.yaml file. See Installing Knative Eventing and Knative Serving CRDs for more details.

Summary by Sourcery

Bump the default OpenShift Serverless Logic Operator to v1.36.0 and update the orchestrator-infra chart version and docs accordingly.

Enhancements:

  • Bump default serverlessLogicOperator.subscription.spec.startingCSV to logic-operator-rhel8.v1.36.0

Documentation:

  • Update README version badge and CRD extraction commands to reference operator bundle v1.36.0

Chores:

  • Update orchestrator-infra chart version from 0.2.0 to 0.2.1

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Aug 3, 2025

Reviewer's Guide

This PR updates the orchestrator-infra Helm chart to use OSL version 1.36.0 and bumps the chart release to 0.2.1, ensuring all CRD retrieval instructions and documentation reflect the new operator version.

File-Level Changes

Change Details Files
Bump chart version and update README badge
  • Increment Chart.yaml version to 0.2.1
  • Update version badge in README.md to 0.2.1
charts/orchestrator-infra/Chart.yaml
charts/orchestrator-infra/README.md
Update default OSL operator version and CRD instructions
  • Change serverlessLogicOperator.startingCSV to logic-operator-rhel8.v1.36.0 in values.yaml
  • Adjust subscription startingCSV description in README.md and README.md.gotmpl
  • Update docker run commands for CRD extraction to use 1.36.0
charts/orchestrator-infra/values.yaml
charts/orchestrator-infra/README.md
charts/orchestrator-infra/README.md.gotmpl

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @elai-shalev - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments

### Comment 1
<location> `charts/orchestrator-infra/README.md:111` </location>
<code_context>
 The versions of the CRDs present in the chart and the ones in the subscrtiprion must match. In order to verify the correct CRD, use this following command to extract the CRD:

 ```bash
</code_context>

<issue_to_address>
Typo: 'subscrtiprion' should be 'subscription'.
</issue_to_address>

<suggested_fix>
<<<<<<< SEARCH
The versions of the CRDs present in the chart and the ones in the subscrtiprion must match. In order to verify the correct CRD, use this following command to extract the CRD:
=======
The versions of the CRDs present in the chart and the ones in the subscription must match. In order to verify the correct CRD, use this following command to extract the CRD:
>>>>>>> REPLACE

</suggested_fix>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread charts/orchestrator-infra/README.md Outdated
@elai-shalev
Copy link
Copy Markdown
Author

@Fortune-Ndlovu Hey, is is possible we get anyone from the team to take a look at this before Armel is back?

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 7, 2025

@gazarenkov gazarenkov merged commit efa04db into redhat-developer:main Aug 7, 2025
5 of 7 checks passed
elai-shalev added a commit to elai-shalev/rhdh-chart that referenced this pull request Aug 25, 2025
…hat-developer#201)

* bumping osl default version to 1.36 in orchestrator-infra

* fixing typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants