adding sonataflowPlatform's jobservice and dataindex custom images to…

[elai-shalev]

This change will introduce two new variables to the bachstage chart schema, to take custom images for sonataflow's dataindex and jobs service. This can be used in disconnected environments when the iages are taken from a local registry.
related to this bug:
https://issues.redhat.com/browse/RHDHBUGS-2003

Checklist

• For each Chart updated, version bumped in the corresponding Chart.yaml according to Semantic Versioning.
• For each Chart updated, variables are documented in the values.yaml and added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes. The pre-commit Workflow will do this automatically for you if needed.
• JSON Schema template updated and re-generated the raw schema via the pre-commit hook.
• Tests pass using the Chart Testing tool and the ct lint command.
• If you updated the orchestrator-infra chart, make sure the versions of the Knative CRDs are aligned with the versions of the CRDs installed by the OpenShift Serverless operators declared in the values.yaml file. See Installing Knative Eventing and Knative Serving CRDs for more details.

Summary by Sourcery

Add custom image support for sonataflow dataindex and jobservice in the Backstage Helm chart and bump chart version

Enhancements:

• Introduce two new values in the chart schema to configure custom images for sonataflow dataindex and jobservice in disconnected environments

Build:

• Bump charts/backstage version from 4.5.5 to 4.5.6

Documentation:

• Update README badge to reflect the new chart version

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• It looks like the new custom image variables aren’t documented in values.yaml or the README—please add entries for them so users know how to configure them.
• After updating the values.schema.tmpl.json, don’t forget to regenerate the raw JSON schema (values.schema.json) via the pre-commit hook so the schema change is applied.
• I don’t see the actual schema additions in the diff—double-check that the two new image fields are included in both the template and generated schema files.

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- It looks like the new custom image variables aren’t documented in values.yaml or the README—please add entries for them so users know how to configure them.
- After updating the values.schema.tmpl.json, don’t forget to regenerate the raw JSON schema (values.schema.json) via the pre-commit hook so the schema change is applied.
- I don’t see the actual schema additions in the diff—double-check that the two new image fields are included in both the template and generated schema files.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[rm3l]

What's the fix version of https://issues.redhat.com/browse/RHDHBUGS-2003 ? Is this critical enough to be in the upcoming 1.7.1? Or can it wait until 1.8.0?

[elai-shalev]

What's the fix version of https://issues.redhat.com/browse/RHDHBUGS-2003 ? Is this critical enough to be in the upcoming 1.7.1? Or can it wait until 1.8.0?

I think it can wait to 1.8, there is a workaround by installing the chart from source and adding the params to the schema manually

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[rm3l]

/lgtm