Skip to content

fix(orchestrator-infra): Rename the chart in the README [RHDHBUGS-2021]#237

Merged
rm3l merged 1 commit intoredhat-developer:release-1.7from
rm3l:cherry-pick/release-1.7/rhdhbugs-2021-doc-update-helm-orchestrator-infra-doc-chart
Sep 10, 2025
Merged

fix(orchestrator-infra): Rename the chart in the README [RHDHBUGS-2021]#237
rm3l merged 1 commit intoredhat-developer:release-1.7from
rm3l:cherry-pick/release-1.7/rhdhbugs-2021-doc-update-helm-orchestrator-infra-doc-chart

Conversation

@rm3l
Copy link
Copy Markdown
Member

@rm3l rm3l commented Sep 10, 2025

Description of the change

Manual cherry-pick of #236

The chart was renamed in [1][2], but the README was still pointing to the
previous chart, which caused users to install an outdated version of the
chart when following this doc.

[1] https://issues.redhat.com/browse/RHIDP-6169
[2] #131

Which issue(s) does this PR fix or relate to

How to test changes / Special notes to the reviewer

Checklist

  • For each Chart updated, version bumped in the corresponding Chart.yaml according to Semantic Versioning.
  • For each Chart updated, variables are documented in the values.yaml and added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes. The pre-commit Workflow will do this automatically for you if needed.
  • JSON Schema template updated and re-generated the raw schema via the pre-commit hook.
  • Tests pass using the Chart Testing tool and the ct lint command.
  • If you updated the orchestrator-infra chart, make sure the versions of the Knative CRDs are aligned with the versions of the CRDs installed by the OpenShift Serverless operators declared in the values.yaml file. See Installing Knative Eventing and Knative Serving CRDs for more details.

Summary by Sourcery

Rename the orchestrator-infra chart reference in README, bump chart version to 0.1.2, and align documentation with the renamed chart to prevent users installing the outdated version

Bug Fixes:

  • Fix wrong helm install command pointing to the old chart name in orchestrator-infra README

Enhancements:

  • Bump orchestrator-infra chart version from 0.1.1 to 0.1.2

Documentation:

  • Update README badge and install instruction to use redhat-developer-hub-orchestrator-infra instead of orchestrator-infra

Chores:

  • Cherry-pick chart rename changes from upstream PR

@rm3l rm3l requested a review from a team as a code owner September 10, 2025 07:25
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • The change to the install command in README.md should also be applied to README.md.gotmpl so future doc generations don’t revert the new chart name.
  • Don’t forget to regenerate the Helm repo index after renaming the chart so the updated path is published for users.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The change to the install command in README.md should also be applied to README.md.gotmpl so future doc generations don’t revert the new chart name.
- Don’t forget to regenerate the Helm repo index after renaming the chart so the updated path is published for users.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rm3l rm3l changed the title fix(orchestrator-infra): Rename the chart in the README [RHDHBUGS-2021] (#236) fix(orchestrator-infra): Rename the chart in the README [RHDHBUGS-2021] Sep 10, 2025
Copy link
Copy Markdown
Member Author

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a simple fix in the README - so merging to close the issue.

@rm3l rm3l merged commit 1e96f66 into redhat-developer:release-1.7 Sep 10, 2025
7 of 8 checks passed
@rm3l rm3l deleted the cherry-pick/release-1.7/rhdhbugs-2021-doc-update-helm-orchestrator-infra-doc-chart branch September 10, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant