Skip to content

fixing issue with namespace range#241

Merged
rm3l merged 1 commit intoredhat-developer:mainfrom
elai-shalev:fix/namespace-issues
Sep 11, 2025
Merged

fixing issue with namespace range#241
rm3l merged 1 commit intoredhat-developer:mainfrom
elai-shalev:fix/namespace-issues

Conversation

@elai-shalev
Copy link
Copy Markdown

@elai-shalev elai-shalev commented Sep 11, 2025

This PR will fix a small issue in the orchestrator-software-templates-infra chart
in some templates, the namespace range was not working and needed to be fixed.

Checklist

  • For each Chart updated, version bumped in the corresponding Chart.yaml according to Semantic Versioning.
  • For each Chart updated, variables are documented in the values.yaml and added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes. The pre-commit Workflow will do this automatically for you if needed.
  • JSON Schema template updated and re-generated the raw schema via the pre-commit hook.
  • Tests pass using the Chart Testing tool and the ct lint command.
  • If you updated the orchestrator-infra chart, make sure the versions of the Knative CRDs are aligned with the versions of the CRDs installed by the OpenShift Serverless operators declared in the values.yaml file. See Installing Knative Eventing and Knative Serving CRDs for more details.

Summary by Sourcery

Fix namespace range handling in the openshift-gitops templates by using the current namespace variable for resource names, labels, and bindings, and bump the chart version to 0.2.3.

Bug Fixes:

  • Use the dynamic namespace variable ($ns) instead of the first element for ArgoCD ClusterRoleBinding labels, role names, and service account subjects
  • Use the dynamic namespace variable ($ns) for ArgoCD custom resource name and app label

Build:

  • Bump orchestrator-software-templates-infra chart version to 0.2.3

Documentation:

  • Update README badge to reflect chart version 0.2.3

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Sep 11, 2025
@rm3l rm3l merged commit d28eca0 into redhat-developer:main Sep 11, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants