chore: Make sure ct lint runs against all charts#243
Merged
rm3l merged 3 commits intoredhat-developer:mainfrom Sep 11, 2025
Merged
chore: Make sure ct lint runs against all charts#243rm3l merged 3 commits intoredhat-developer:mainfrom
ct lint runs against all charts#243rm3l merged 3 commits intoredhat-developer:mainfrom
Conversation
It still makes sense to lint all charts, even the ones that are excluded from extensive CI testing
Co-authored-by: rm3l <rm3l@users.noreply.github.com>
|
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Remove or deprecate the original ct.yaml and update any references so there's no confusion now that ct-lint.yaml is your primary config.
- Add a brief inline note in ct-lint.yaml explaining why 'validate-maintainers' is disabled to give future contributors context.
- Consider exposing the Helm timeout value as a CI variable instead of hardcoding 500s, which makes it easier to adjust per chart or per environment.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Remove or deprecate the original ct.yaml and update any references so there's no confusion now that ct-lint.yaml is your primary config.
- Add a brief inline note in ct-lint.yaml explaining why 'validate-maintainers' is disabled to give future contributors context.
- Consider exposing the Helm timeout value as a CI variable instead of hardcoding 500s, which makes it easier to adjust per chart or per environment.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description of the change
Otherwise, we might miss some required version bumps on the previously-excluded charts, like in https://github.com/redhat-developer/rhdh-chart/actions/runs/17655946490/job/50178635934?pr=239#step:8:26 where it skipped a chart that actually requires a version bump.
Which issue(s) does this PR fix or relate to
https://github.com/redhat-developer/rhdh-chart/actions/runs/17655946490/job/50178635934?pr=239#step:8:26
How to test changes / Special notes to the reviewer
We can see in https://github.com/redhat-developer/rhdh-chart/actions/runs/17656363770/job/50179970842?pr=243 that all modified charts are being linted.
And in https://github.com/redhat-developer/rhdh-chart/actions/runs/17656363790/job/50179971216?pr=243#step:14:28, we can see that only the non-excluded charts modified are being tested.
Checklist
Chart.yamlaccording to Semantic Versioning.values.yamland added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Usepre-commit run -ato apply changes. The pre-commit Workflow will do this automatically for you if needed.pre-commithook.ct lintcommand.Summary by Sourcery
Update chart-testing configuration and workflow to lint all charts with a dedicated config file and apply minor README adjustments across multiple chart directories
Enhancements:
CI:
Documentation:
Summary by Sourcery
Ensure chart linting runs against all charts by creating a dedicated configuration file and updating the CI workflow.
Enhancements:
CI: