Skip to content

chore: Make sure ct lint runs against all charts#243

Merged
rm3l merged 3 commits intoredhat-developer:mainfrom
rm3l:chore/make_sure_to_lint_all_charts
Sep 11, 2025
Merged

chore: Make sure ct lint runs against all charts#243
rm3l merged 3 commits intoredhat-developer:mainfrom
rm3l:chore/make_sure_to_lint_all_charts

Conversation

@rm3l
Copy link
Copy Markdown
Member

@rm3l rm3l commented Sep 11, 2025

Description of the change

Otherwise, we might miss some required version bumps on the previously-excluded charts, like in https://github.com/redhat-developer/rhdh-chart/actions/runs/17655946490/job/50178635934?pr=239#step:8:26 where it skipped a chart that actually requires a version bump.

Which issue(s) does this PR fix or relate to

https://github.com/redhat-developer/rhdh-chart/actions/runs/17655946490/job/50178635934?pr=239#step:8:26

How to test changes / Special notes to the reviewer

We can see in https://github.com/redhat-developer/rhdh-chart/actions/runs/17656363770/job/50179970842?pr=243 that all modified charts are being linted.
And in https://github.com/redhat-developer/rhdh-chart/actions/runs/17656363790/job/50179971216?pr=243#step:14:28, we can see that only the non-excluded charts modified are being tested.

Checklist

  • For each Chart updated, version bumped in the corresponding Chart.yaml according to Semantic Versioning.
  • For each Chart updated, variables are documented in the values.yaml and added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes. The pre-commit Workflow will do this automatically for you if needed.
  • JSON Schema template updated and re-generated the raw schema via the pre-commit hook.
  • Tests pass using the Chart Testing tool and the ct lint command.
  • If you updated the orchestrator-infra chart, make sure the versions of the Knative CRDs are aligned with the versions of the CRDs installed by the OpenShift Serverless operators declared in the values.yaml file. See Installing Knative Eventing and Knative Serving CRDs for more details.

Summary by Sourcery

Update chart-testing configuration and workflow to lint all charts with a dedicated config file and apply minor README adjustments across multiple chart directories

Enhancements:

  • Introduce ct-lint.yaml to define chart directories, disable maintainer validation, set remote origin, and extend Helm timeout

CI:

  • Switch GitHub Actions lint job to use ct-lint.yaml instead of ct.yaml

Documentation:

  • Normalize casing in the Backstage chart README
  • Add placeholder comments in orchestrator and software templates chart READMEs

Summary by Sourcery

Ensure chart linting runs against all charts by creating a dedicated configuration file and updating the CI workflow.

Enhancements:

  • Introduce ct-lint.yaml to specify all chart directories, disable maintainer validation, set the remote origin, and increase Helm timeout

CI:

  • Switch the GitHub Actions lint job to use ct-lint.yaml instead of ct.yaml

It still makes sense to lint all charts, even the ones that are excluded from extensive CI testing
Co-authored-by: rm3l <rm3l@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown

⚠️ Files changed after running the pre-commit hooks

Those changes should have been pushed automatically to your PR branch.

NOTE: If the PR checks are stuck after this additional commit, manually close the PR and immediately reopen it to trigger the checks again.

@rm3l rm3l marked this pull request as ready for review September 11, 2025 20:27
@rm3l rm3l closed this Sep 11, 2025
@rm3l rm3l reopened this Sep 11, 2025
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Remove or deprecate the original ct.yaml and update any references so there's no confusion now that ct-lint.yaml is your primary config.
  • Add a brief inline note in ct-lint.yaml explaining why 'validate-maintainers' is disabled to give future contributors context.
  • Consider exposing the Helm timeout value as a CI variable instead of hardcoding 500s, which makes it easier to adjust per chart or per environment.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Remove or deprecate the original ct.yaml and update any references so there's no confusion now that ct-lint.yaml is your primary config.
- Add a brief inline note in ct-lint.yaml explaining why 'validate-maintainers' is disabled to give future contributors context.
- Consider exposing the Helm timeout value as a CI variable instead of hardcoding 500s, which makes it easier to adjust per chart or per environment.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sonarqubecloud
Copy link
Copy Markdown

@rm3l rm3l merged commit 552d233 into redhat-developer:main Sep 11, 2025
8 of 9 checks passed
@rm3l rm3l deleted the chore/make_sure_to_lint_all_charts branch September 11, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant