Skip to content

use rhdh-community image#263

Merged
openshift-merge-bot[bot] merged 7 commits intoredhat-developer:mainfrom
gazarenkov:rhdh-community-image
Dec 5, 2025
Merged

use rhdh-community image#263
openshift-merge-bot[bot] merged 7 commits intoredhat-developer:mainfrom
gazarenkov:rhdh-community-image

Conversation

@gazarenkov
Copy link
Copy Markdown
Member

Description of the change

To make it possible to deploy on other than amd arch use rhdh-community/rhdh image

Which issue(s) does this PR fix or relate to

https://issues.redhat.com/browse/RHDHBUGS-2183

How to test changes / Special notes to the reviewer

Checklist

  • For each Chart updated, version bumped in the corresponding Chart.yaml according to Semantic Versioning.
  • For each Chart updated, variables are documented in the values.yaml and added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes. The pre-commit Workflow will do this automatically for you if needed.
  • JSON Schema template updated and re-generated the raw schema via the pre-commit hook.
  • Tests pass using the Chart Testing tool and the ct lint command.
  • If you updated the orchestrator-infra chart, make sure the versions of the Knative CRDs are aligned with the versions of the CRDs installed by the OpenShift Serverless operators declared in the values.yaml file. See Installing Knative Eventing and Knative Serving CRDs for more details.

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review Bot commented Nov 3, 2025

PR Reviewer Guide 🔍

(Review updated until commit 3cdfaba)

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅

RHDHBUGS-2183 - PR Code Verified

Compliant requirements:

  • Use a multi-arch capable upstream image so deployments work on non-amd64 (e.g., arm64).
  • Ensure default chart configuration references the upstream community image.
  • Bump chart version and documentation to reflect the change.
  • Maintain ability to deploy via Helm with clear instructions.

Requires further human verification:

  • Validate on an actual arm64 cluster that pods schedule and run successfully with the new image.
  • Confirm runtime parity/features between previous downstream image and community image in target environments.
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🔒 No security concerns identified
⚡ Recommended focus areas for review

Schema-Values Sync

Ensure the JSON schema defaults ('repository' and 'tag') remain consistent with values.yaml and documentation to avoid validation drift across environments.

    "default": "rhdh-community/rhdh",
    "title": "Backstage image repository",
    "type": "string"
},
"tag": {
    "default": "next",
    "description": "Immutable tags are recommended.",
    "title": "Backstage image tag",
    "type": "string"
📚 Focus areas based on broader codebase context

Tag Stability

The default image tag is set to next, which is mutable and may cause non-reproducible deployments. Consider using an immutable, versioned tag aligned with released images. (Ref 2)

"repository": {
    "default": "rhdh-community/rhdh",
    "title": "Backstage image repository",
    "type": "string"
},
"tag": {
    "default": "next",
    "description": "Immutable tags are recommended.",
    "title": "Backstage image tag",
    "type": "string"

Reference reasoning: The operator manifests use specific, pinned image tags for critical components, reflecting a practice of versioned images to ensure consistent behavior across deployments.

📄 References
  1. redhat-developer/rhdh-operator/config/manager/deployment.yaml [25-47]
  2. redhat-developer/rhdh-operator/dist/rhdh/install.yaml [3200-3231]
  3. redhat-developer/rhdh-operator/dist/rhdh/install.yaml [3170-3199]
  4. redhat-developer/rhdh-operator/config/profile/rhdh/default-config/deployment.yaml [74-82]
  5. redhat-developer/rhdh-operator/dist/rhdh/install.yaml [2565-2581]
  6. redhat-developer/rhdh-operator/dist/rhdh/install.yaml [3257-3268]
  7. redhat-developer/rhdh-operator/dist/rhdh/install.yaml [3238-3256]
  8. redhat-developer/rhdh-operator/dist/rhdh/install.yaml [1503-1520]

@gazarenkov gazarenkov requested a review from rm3l November 3, 2025 19:09
@qodo-code-review qodo-code-review Bot added the enhancement New feature or request label Nov 3, 2025
@qodo-code-review
Copy link
Copy Markdown

qodo-code-review Bot commented Nov 3, 2025

PR Type

(Describe updated until commit 3cdfaba)

Enhancement


Description

  • Switch Backstage image from rhdh/rhdh-hub-rhel9 to rhdh-community/rhdh

  • Update default image tag from latest to next

  • Bump chart version to 4.6.2

  • Update documentation and schema to reflect new image configuration


File Walkthrough

Relevant files
Configuration changes
Chart.yaml
Bump chart version to 4.6.2                                                           

charts/backstage/Chart.yaml

  • Bumped chart version from 4.6.1 to 4.6.2
+1/-1     
values.schema.json
Update JSON schema with new image defaults                             

charts/backstage/values.schema.json

  • Changed default image repository from rhdh/rhdh-hub-rhel9 to
    rhdh-community/rhdh
  • Changed default image tag from latest to next
+2/-2     
Documentation
README.md
Update documentation version references                                   

charts/backstage/README.md

  • Updated version badge from 4.6.1 to 4.6.2
  • Updated helm install command example to use version 4.6.2
+2/-2     
Enhancement
values.yaml
Update default image repository and tag                                   

charts/backstage/values.yaml

  • Changed image repository from rhdh/rhdh-hub-rhel9 to
    rhdh-community/rhdh
  • Changed image tag from latest to next
+2/-2     

Co-authored-by: gazarenkov <gazarenkov@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 3, 2025

⚠️ Files changed after running the pre-commit hooks

Those changes should have been pushed automatically to your PR branch.

NOTE: If the PR checks are stuck after this additional commit, manually close the PR and immediately reopen it to trigger the checks again.

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review Bot commented Nov 3, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Fix broken link in documentation
Suggestion Impact:The commit updated the broken installation docs link, though to a different target (tree path and installation-ci-charts.adoc) than suggested. It reflects acting on the suggestion to fix the broken link.

code diff:

-Up-to-date instructions on installing RHDH through the chart can be found in the [installation docs](https://github.com/redhat-developer/rhdh-chart/blob/main/.rhdh/docs/installing-ci-charts.adoc).
+Up-to-date instructions on installing RHDH through the chart can be found in the [installation docs](https://github.com/redhat-developer/rhdh-chart/tree/main/.rhdh/docs/installation-ci-charts.adoc).

The link to the installation documentation is broken. Update the filename in the
URL from installing-ci-charts.adoc to installing-from-helm-ci.adoc to fix the
404 error.

charts/backstage/README.md [56]

-Up-to-date instructions on installing RHDH through the chart can be found in the [installation docs](https://github.com/redhat-developer/rhdh-chart/blob/main/.rhdh/docs/installing-ci-charts.adoc).
+Up-to-date instructions on installing RHDH through the chart can be found in the [installation docs](https://github.com/redhat-developer/rhdh-chart/blob/main/.rhdh/docs/installing-from-helm-ci.adoc).

[Suggestion processed]

Suggestion importance[1-10]: 7

__

Why: The suggestion correctly identifies that the PR introduces a broken link to installation instructions and provides a valid, working link, which is important for usability.

Medium
General
Use a specific image version

Replace the floating image tag next with a specific, immutable version tag
(e.g., 1.2.0-1) to ensure predictable and stable deployments.

charts/backstage/values.yaml [40-41]

 repository: rhdh-community/rhdh
-tag: next
+tag: "1.2.0-1" # Or another specific, stable version
  • Apply / Chat
Suggestion importance[1-10]: 6

__

Why: The suggestion correctly points out that using a floating tag like next is against best practices for reproducible deployments and recommends using a specific version, which improves chart stability.

Low
  • Update

@rhdh-qodo-merge
Copy link
Copy Markdown

rhdh-qodo-merge Bot commented Nov 3, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Fix broken link in documentation

The link to the installation documentation in README.md is broken. Update the
filename in the URL from installing-ci-charts.adoc to
installing-from-ci-builds.adoc to fix it.

charts/backstage/README.md [56]

-Up-to-date instructions on installing RHDH through the chart can be found in the [installation docs](https://github.com/redhat-developer/rhdh-chart/blob/main/.rhdh/docs/installing-ci-charts.adoc).
+Up-to-date instructions on installing RHDH through the chart can be found in the [installation docs](https://github.com/redhat-developer/rhdh-chart/blob/main/.rhdh/docs/installing-from-ci-builds.adoc).
  • Apply / Chat
Suggestion importance[1-10]: 9

__

Why: The suggestion correctly identifies that the link updated in the PR is broken (results in a 404) and provides the correct, working link, which is critical for users trying to follow installation instructions.

High
General
Avoid using a floating image tag

The next image tag in values.yaml is a floating tag, which can cause
inconsistent deployments. Add a comment to recommend using a specific version
tag for stable environments.

charts/backstage/values.yaml [40-41]

 repository: rhdh-community/rhdh
+# For stable deployments, it is recommended to use a specific version tag, e.g., "1.2.0-5"
 tag: next
  • Apply / Chat
Suggestion importance[1-10]: 6

__

Why: The suggestion correctly points out the risk of using a floating image tag like next and recommends a best practice for production deployments. Adding a comment to warn users is a valuable improvement for chart usability.

Low
  • More

Co-authored-by: gazarenkov <gazarenkov@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 3, 2025

⚠️ Files changed after running the pre-commit hooks

Those changes should have been pushed automatically to your PR branch.

NOTE: If the PR checks are stuck after this additional commit, manually close the PR and immediately reopen it to trigger the checks again.

@rm3l rm3l closed this Nov 4, 2025
@rm3l rm3l reopened this Nov 4, 2025
@qodo-code-review
Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

RHDHBUGS-2183 - Partially compliant

Compliant requirements:

  • Use the upstream multi-arch image (rhdh-community/rhdh) instead.
  • Stop relying on the downstream non-multi-arch image.
  • Update Helm chart defaults and documentation accordingly.
  • Bump chart version following semantic versioning when changing defaults.

Non-compliant requirements:

  • Make RHDH deployable on non-amd64 architectures by default.

Requires further human verification:

  • Validate on an actual non-amd64 cluster (e.g., arm64) that the chart deploys successfully and pods are scheduled and running.
  • Confirm the selected 'next' tag exists for all required architectures and aligns with release/support expectations.
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🔒 No security concerns identified
⚡ Recommended focus areas for review

Tag Choice

The image tag was changed to 'next'. This may be unstable and mutable; consider pinning to a stable, immutable tag to ensure reproducible deployments and avoid unexpected changes.

upstream:
  nameOverride: developer-hub
  backstage:
    image:
      registry: quay.io
      repository: rhdh-community/rhdh
      tag: next
      pullPolicy: IfNotPresent
    command: []
    # FIXME (tumido): USE POSTGRES_PASSWORD and POSTGRES_USER instead of POSTGRES_ADMIN_PASSWORD
    # This is a hack. In {fedora,rhel}/postgresql images, regular user is forbidden
Schema Alignment

Ensure values.schema.json defaults ('repository' and 'tag') match values.yaml and intended chart behavior; verify tooling and docs rely on these defaults consistently.

"repository": {
    "default": "rhdh-community/rhdh",
    "title": "Backstage image repository",
    "type": "string"
},
"tag": {
    "default": "next",
    "description": "Immutable tags are recommended.",
    "title": "Backstage image tag",
    "type": "string"
}
Version Sync

README version and install command updated to 4.6.2; confirm Chart.yaml appVersion or other badges remain consistent across docs and chart metadata.

# RHDH Backstage Helm Chart for OpenShift

![Version: 4.6.2](https://img.shields.io/badge/Version-4.6.2-informational?style=flat-square)
![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)

A Helm chart for deploying Red Hat Developer Hub, which is a Red Hat supported version of Backstage.

The telemetry data collection feature is enabled by default. Red Hat Developer Hub sends telemetry data to Red Hat by using the `backstage-plugin-analytics-provider-segment` plugin. To disable this and to learn what data is being collected, see https://docs.redhat.com/en/documentation/red_hat_developer_hub/1.6/html-single/telemetry_data_collection_and_analysis/index

**Homepage:** <https://red.ht/rhdh>

## Productized RHDH

This repository now provides the productized RHDH chart.
For the **Generally Available** version of this chart, see:

* https://github.com/openshift-helm-charts/charts - official releases to https://charts.openshift.io/

## Maintainers

| Name | Email | Url |
| ---- | ------ | --- |
| Red Hat |  | <https://redhat.com> |

## TL;DR

```console
helm repo add bitnami https://charts.bitnami.com/bitnami
helm repo add backstage https://backstage.github.io/charts
helm repo add redhat-developer https://redhat-developer.github.io/rhdh-chart

helm install my-backstage redhat-developer/backstage --version 4.6.2

Introduction


</details>

</td></tr>
<tr><td>

<details><summary>📄 References</summary><ol><li>No matching references available</li>

</ol></details>

</td></tr>
</table>

@rhdh-qodo-merge
Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅

RHDHBUGS-2183 - PR Code Verified

Compliant requirements:

  • Use the upstream multi-arch image so RHDH can deploy on non-amd64 architectures.
  • Ensure charts default to the upstream image (like rhdh-local) instead of the downstream non-multi-arch image.
  • Bump chart version and reflect changes in README installation instructions.

Requires further human verification:

  • Validate deployment on an arm64 cluster to confirm images resolve correctly and pods schedule successfully.
  • Run chart-testing (ct lint/install) against multiple platforms to ensure no regressions.
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🔒 No security concerns identified
⚡ Recommended focus areas for review

Image Default Consistency

Ensure repository: rhdh-community/rhdh and tag: next are consistently used across all chart templates/rendered deployments, and that any docs/examples align.

  registry: quay.io
  repository: rhdh-community/rhdh
  tag: next
  pullPolicy: IfNotPresent
command: []
📚 Focus areas based on broader codebase context

Image Tag Stability

The image tag is set to next, which is mutable and may introduce unpredictable changes. Consider using an immutable, versioned tag and documenting how it maps to supported architectures. (Ref 3, Ref 4)

registry: quay.io
repository: rhdh-community/rhdh
tag: next
pullPolicy: IfNotPresent

Reference reasoning: The referenced deployment configs use stable image references (e.g., quay.io/rhdh/rhdh-hub-rhel9:next controlled via RELATED_IMAGE_backstage) and emphasize predictable operator-managed images. Aligning with this pattern by pinning a specific versioned tag will ensure consistency across deployments.

📄 References
  1. redhat-developer/rhdh-operator/dist/backstage.io/install.yaml [2323-2357]
  2. redhat-developer/rhdh-operator/dist/rhdh/install.yaml [3200-3231]
  3. redhat-developer/rhdh-operator/config/profile/rhdh/default-config/deployment.yaml [83-99]
  4. redhat-developer/rhdh-operator/config/profile/rhdh/default-config/deployment.yaml [41-62]
  5. redhat-developer/rhdh-operator/dist/rhdh/install.yaml [3170-3199]
  6. redhat-developer/rhdh-operator/config/manager/deployment.yaml [25-47]
  7. redhat-developer/rhdh-operator/dist/rhdh/install.yaml [3238-3256]
  8. redhat-developer/rhdh-operator/dist/rhdh/install.yaml [3257-3268]

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Nov 4, 2025

@qodo-code-review
Copy link
Copy Markdown

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Avoid using the 'next' image tag

Change the default image tag from next to a more stable one, like latest or a
specific version, to ensure predictable and stable deployments for users.

charts/backstage/values.yaml [41]

-tag: next
+tag: latest
  • Apply / Chat
Suggestion importance[1-10]: 8

__

Why: The suggestion correctly points out that using the next tag as a default is a poor practice for a released chart, as it typically points to an unstable development version, potentially causing issues for users.

Medium
  • More

@rhdh-qodo-merge
Copy link
Copy Markdown

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Use an immutable image tag

Replace the mutable next image tag in values.yaml with a specific, immutable
version tag to ensure reproducible and stable deployments.

charts/backstage/values.yaml [35-42]

 upstream:
   nameOverride: developer-hub
   backstage:
     image:
       registry: quay.io
       repository: rhdh-community/rhdh
-      tag: next
+      tag: <specific-immutable-tag> # e.g. 1.2.0
       pullPolicy: IfNotPresent

[To ensure code accuracy, apply this suggestion manually]

Suggestion importance[1-10]: 7

__

Why: The suggestion correctly identifies that using the mutable next tag for the default image compromises deployment stability and contradicts the chart's own schema recommendation.

Medium
Use an immutable default image tag

In values.schema.json, change the default image tag from the mutable next to a
specific, immutable version to ensure deployment stability and reproducibility.

charts/backstage/values.schema.json [4590-4600]

 "repository": {
     "default": "rhdh-community/rhdh",
     "title": "Backstage image repository",
     "type": "string"
 },
 "tag": {
-    "default": "next",
+    "default": "<specific-immutable-tag>",
     "description": "Immutable tags are recommended.",
     "title": "Backstage image tag",
     "type": "string"
 }
  • Apply / Chat
Suggestion importance[1-10]: 7

__

Why: The suggestion correctly identifies that setting the default image tag to the mutable next tag in the schema contradicts the schema's own description and is a bad practice for deployment stability.

Medium
  • More

Copy link
Copy Markdown
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change on the chart version, but LGTM overall. This should not have any impact on the midstream script, as it directly applies a patch that overrides the image repository and tag accordingly.

Comment thread charts/backstage/Chart.yaml Outdated
Comment thread charts/backstage/README.md Outdated
Comment thread charts/backstage/README.md Outdated
@zdrapela
Copy link
Copy Markdown
Member

zdrapela commented Nov 7, 2025

/review

@rhdh-qodo-merge
Copy link
Copy Markdown

Persistent review updated to latest commit 3cdfaba

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 5, 2025

Copy link
Copy Markdown
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Dec 5, 2025
@openshift-merge-bot openshift-merge-bot Bot merged commit 7ec665f into redhat-developer:main Dec 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants