You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Update the Install Methods to reference OSL version 1.37.1.
Requires further human verification:
Confirm the referenced install-method docs/commands are the complete set of install methods used in the release (and not duplicated elsewhere).
Validate in a cluster that installing with startingCSVlogic-operator.v1.37.1 succeeds and that the CRDs packaged under crds/ match what the operator expects for 1.37.1.
The new CRD extraction instructions switch to podman and write into crds/... paths; verify these paths match the chart layout and that the guidance is accurate/consistent with the repository (including whether helm.sh/hook annotations are indeed required and where they should be applied).
The KnativeEventing and KnativeServing CRDs are required for this chart to run. These CRDs need to be present under the `crds/` directory before running `helm install`.
After installing the openshift-serverless subscription, more Knative CRDs will be installed on the cluster.
The versions of the CRDs present in the chart and the ones in the subscription must match. In order to verify the correct CRD, use this following command to extract the CRD:
```bashexport osl_bundle=registry.redhat.io/openshift-serverless-1/serverless-operator-bundle:1.37.1
podman container run --rm --entrypoint cat "$osl_bundle" /manifests/operator_v1beta1_knativeeventing_crd.yaml > crds/knative-eventing/knative-eventing-crd.yaml
podman container run --rm --entrypoint cat "$osl_bundle" /manifests/operator_v1beta1_knativeserving_crd.yaml > crds/knative-serving/knative-serving-crd.yaml
After running these commands, you may need to re-add the helm.sh/hook annotations.
</details>
<details><summary><a href='https://github.com/redhat-developer/rhdh-chart/pull/318/files#diff-04e92a4f0b7513b0341d3f8487f044b6954d4a640d246f2725662b4ddac4e696R10-R18'><strong>Version alignment</strong></a>
The default `startingCSV` is bumped to `logic-operator.v1.37.1`; ensure the chart’s bundled CRDs (and any other pinned OSL references) are updated to the matching 1.37.1 versions so installs don’t fail due to version/CRD mismatches.
</summary>
```yaml
# -- whether the update should be installed automatically
installPlanApproval: Manual
# -- name of the operator package
name: logic-operator
# -- name of the catalog source
source: redhat-operators
sourceNamespace: openshift-marketplace
# -- The initial version of the operator, must match CRDs installed by the chart
startingCSV: logic-operator.v1.37.1
The PR updates the OpenShift Serverless Logic version but omits the required CRD file updates in the crds/ directory. It is suggested to fetch and commit the correct CRDs to prevent installation failures.
The orchestrator-infra chart requires several CRDs for Knative Eventing and Knative Serving. These CRDs will be applied prior to installing the chart, ensuring that Knative CRs can be created as part of the chart's deployment process. This approach eliminates the need to wait for the OpenShift Serverless Operator's subscription to install them beforehand.
The KnativeEventing and KnativeServing CRDs are required for this chart to run. These CRDs need to be present under the `crds/` directory before running `helm install`.
After installing the openshift-serverless subscription, more Knative CRDs will be installed on the cluster.
The versions of the CRDs present in the chart and the ones in the subscription must match. In order to verify the correct CRD, use this following command to extract the CRD:
```bashexport osl_bundle=registry.redhat.io/openshift-serverless-1/serverless-operator-bundle:1.37.1
podman container run --rm --entrypoint cat "$osl_bundle" /manifests/operator_v1beta1_knativeeventing_crd.yaml > crds/knative-eventing/knative-eventing-crd.yaml
... (clipped 5 lines)
Solution Walkthrough:
Before:
# charts/orchestrator-infra/values.yaml
serverlessLogicOperator:
subscription:
spec:
startingCSV: logic-operator.v1.37.1
# charts/orchestrator-infra/README.md
...
The KnativeEventing and KnativeServing CRDs are required for this chart to run. These CRDs need to be present under the `crds/` directory...
# charts/orchestrator-infra/crds/# (Contains outdated CRD files for v1.37.0, not shown in PR diff)
After:
# charts/orchestrator-infra/values.yaml
serverlessLogicOperator:
subscription:
spec:
startingCSV: logic-operator.v1.37.1
# charts/orchestrator-infra/crds/knative-eventing/knative-eventing-crd.yaml# (New file content for v1.37.1 is added)
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
...
# charts/orchestrator-infra/crds/knative-serving/knative-serving-crd.yaml# (New file content for v1.37.1 is added)
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
...
Suggestion importance[1-10]: 9
__
Why: This suggestion correctly identifies a critical omission; the PR updates operator versions but fails to include the corresponding CRD files, which would cause installation failures and break the chart.
High
General
Improve clarity by renaming a variable
Rename the osl_bundle variable to serverless_bundle for clarity, as it points to the "OpenShift Serverless Operator" image, not the "OpenShift Serverless Logic" one.
-export osl_bundle=registry.redhat.io/openshift-serverless-1/serverless-operator-bundle:1.37.1-podman container run --rm --entrypoint cat "$osl_bundle" /manifests/operator_v1beta1_knativeeventing_crd.yaml > crds/knative-eventing/knative-eventing-crd.yaml+export serverless_bundle=registry.redhat.io/openshift-serverless-1/serverless-operator-bundle:1.37.1+podman container run --rm --entrypoint cat "$serverless_bundle" /manifests/operator_v1beta1_knativeeventing_crd.yaml > crds/knative-eventing/knative-eventing-crd.yaml-podman container run --rm --entrypoint cat "$osl_bundle" /manifests/operator_v1beta1_knativeserving_crd.yaml > crds/knative-serving/knative-serving-crd.yaml+podman container run --rm --entrypoint cat "$serverless_bundle" /manifests/operator_v1beta1_knativeserving_crd.yaml > crds/knative-serving/knative-serving-crd.yaml
Apply / Chat
Suggestion importance[1-10]: 4
__
Why: The suggestion correctly identifies that the variable name osl_bundle is misleading and could cause confusion, improving the clarity of the documentation for a newly added script.
rm3l
deleted the
rhidp-11679-bump-openshift-serverless-logic-version-to-1.37.1-in-the-install-methods--1.9
branch
February 13, 2026 11:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rm3l
force-pushed
the
rhidp-11679-bump-openshift-serverless-logic-version-to-1.37.1-in-the-install-methods--1.9
branch
from
Manual cherry-pick of #317