Skip to content

Revert "[release-1.8] feat: bumping orchestrator plugins to 1.8.10 (#…#358

Closed
lholmquist wants to merge 1 commit intoredhat-developer:release-1.8from
lholmquist:orchestrator-1.8.10-revert
Closed

Revert "[release-1.8] feat: bumping orchestrator plugins to 1.8.10 (#…#358
lholmquist wants to merge 1 commit intoredhat-developer:release-1.8from
lholmquist:orchestrator-1.8.10-revert

Conversation

@lholmquist
Copy link
Copy Markdown
Member

…355)"

This reverts commit 5e3002b.

There will be another orchestrator plugin release which will most likely be 1.8.11 and that one should be used instead.

Description of the change

Which issue(s) does this PR fix or relate to

  • JIRA_issue_link

How to test changes / Special notes to the reviewer

Checklist

  • For each Chart updated, version bumped in the corresponding Chart.yaml according to Semantic Versioning.
  • For each Chart updated, variables are documented in the values.yaml and added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Run pre-commit run --all-files to run the hooks and then push any resulting changes. The pre-commit Workflow will enforce this and warn you if needed.
  • JSON Schema template updated and re-generated the raw schema via the pre-commit hook.
  • Tests pass using the Chart Testing tool and the ct lint command.
  • If you updated the orchestrator-infra chart, make sure the versions of the Knative CRDs are aligned with the versions of the CRDs installed by the OpenShift Serverless operators declared in the values.yaml file. See Installing Knative Eventing and Knative Serving CRDs for more details.

@openshift-ci openshift-ci Bot requested review from rm3l and zdrapela April 16, 2026 19:09
@rhdh-qodo-merge
Copy link
Copy Markdown

rhdh-qodo-merge Bot commented Apr 16, 2026

Code Review by Qodo

🐞 Bugs (1)   📘 Rule violations (0)   📎 Requirement gaps (0)
🐞\ ☼ Reliability (1)

Grey Divider


Action required

1. Chart version decremented 🐞
Description
The Backstage Helm chart version is decreased to 4.5.14 even though the chart is being changed,
contradicting the chart’s own requirement to increment the version per change. This can block
publishing to a chart repository and can prevent normal upgrade paths because chart versions are
expected to move forward.
Code

charts/backstage/Chart.yaml[50]

+version: 4.5.14
Relevance

⭐⭐⭐ High

Version downgrade is risky; team routinely bumps chart versions for any change and to avoid
collisions (#186, #304).

PR-#186
PR-#304
PR-#257

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The chart metadata explicitly states the chart version should be incremented each time changes are
made, but the PR sets the version to 4.5.14 (a downgrade relative to the PR base). README also pins
installation to the downgraded version, amplifying the impact if 4.5.15 already exists in the
release channel.

charts/backstage/Chart.yaml[45-50]
charts/backstage/README.md[4-34]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The chart version was decremented (set to 4.5.14) even though this PR changes chart behavior/content. Helm chart versions should move forward; otherwise publishing/consumption/upgrade flows can break.

## Issue Context
This PR is a revert of orchestrator plugin bumps, but it still modifies chart contents; the chart’s own comments state the chart version should be incremented on every change.

## Fix Focus Areas
- charts/backstage/Chart.yaml[45-50]
- charts/backstage/README.md[4-34]

## Proposed fix
1. Change `version:` in `Chart.yaml` to a new higher patch version (e.g., 4.5.16) rather than lowering it.
2. Regenerate `README.md` (or update it) so the version badge and example install command match the new chart version (ideally via the existing README.gotmpl generation workflow).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@sonarqubecloud
Copy link
Copy Markdown

@rhdh-qodo-merge
Copy link
Copy Markdown

Review Summary by Qodo

Revert orchestrator plugins to 1.8.9 release

🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Reverts orchestrator plugins from version 1.8.10 to 1.8.9
• Downgrades chart version from 4.5.15 to 4.5.14
• Updates all four orchestrator plugin packages with new integrity hashes
• Awaits upcoming 1.8.11 orchestrator plugin release
Diagram
flowchart LR
  A["Orchestrator Plugins 1.8.10"] -- "Revert to" --> B["Orchestrator Plugins 1.8.9"]
  C["Chart Version 4.5.15"] -- "Downgrade to" --> D["Chart Version 4.5.14"]
  B -- "Update integrity hashes" --> E["4 Plugin Packages Updated"]
Loading

Grey Divider

File Changes

1. charts/backstage/Chart.yaml ⚙️ Configuration changes +1/-1

Downgrade chart version to 4.5.14

• Downgrades chart version from 4.5.15 to 4.5.14

charts/backstage/Chart.yaml


2. charts/backstage/README.md 📝 Documentation +3/-3

Update documentation version references

• Updates version badge from 4.5.15 to 4.5.14
• Updates helm install command example to use version 4.5.14

charts/backstage/README.md


3. charts/backstage/values.yaml ⚙️ Configuration changes +8/-8

Downgrade all orchestrator plugins to 1.8.9

• Reverts orchestrator-backend-dynamic plugin from 1.8.10 to 1.8.9 with new integrity hash
• Reverts orchestrator frontend plugin from 1.8.10 to 1.8.9 with new integrity hash
• Reverts scaffolder-backend-module-orchestrator-dynamic from 1.8.10 to 1.8.9 with new integrity
 hash
• Reverts orchestrator-form-widgets plugin from 1.8.10 to 1.8.9 with new integrity hash

charts/backstage/values.yaml


Grey Divider

Qodo Logo

@rhdh-qodo-merge rhdh-qodo-merge Bot added documentation Improvements or additions to documentation bug_fix labels Apr 16, 2026
Copy link
Copy Markdown
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing for the same reasons mentioned in redhat-developer/rhdh-operator#2661 (comment)

/close

@openshift-ci openshift-ci Bot closed this Apr 17, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 17, 2026

@rm3l: Closed this PR.

Details

In response to this:

Closing for the same reasons mentioned in redhat-developer/rhdh-operator#2661 (comment)

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug_fix documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants