(chore): increase MAX_ENTRY_SIZE for lightspeed#369
Closed
Jdubrick wants to merge 2 commits intoredhat-developer:mainfrom
Closed
(chore): increase MAX_ENTRY_SIZE for lightspeed#369Jdubrick wants to merge 2 commits intoredhat-developer:mainfrom
Jdubrick wants to merge 2 commits intoredhat-developer:mainfrom
Conversation
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Code Review by Qodo
1. Unversioned chart change
|
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
|
Review Summary by QodoIncrease MAX_ENTRY_SIZE limit for Lightspeed installation
WalkthroughsDescription• Increase MAX_ENTRY_SIZE from 30000000 to 40000000 • Resolves Lightspeed installation failures • Updates both values.yaml and JSON schema Diagramflowchart LR
A["MAX_ENTRY_SIZE<br/>30000000"] -- "increase limit" --> B["MAX_ENTRY_SIZE<br/>40000000"]
B -- "applied to" --> C["Backstage Chart<br/>Configuration"]
File Changes1. charts/backstage/values.yaml
|
Author
|
Closing as we figure out if value is actually needed anymore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description of the change
MAX_ENTRY_SIZEas Lightspeed was failing to install despite redhat-developer/rhdh@d4f996b being merged alreadyWhich issue(s) does this PR fix or relate to
N/A
How to test changes / Special notes to the reviewer
Checklist
Chart.yamlaccording to Semantic Versioning.values.yamland added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Runpre-commit run --all-filesto run the hooks and then push any resulting changes. The pre-commit Workflow will enforce this and warn you if needed.pre-commithook.ct lintcommand.