Skip to content

(chore): increase MAX_ENTRY_SIZE for lightspeed#369

Closed
Jdubrick wants to merge 2 commits intoredhat-developer:mainfrom
Jdubrick:bump-package-size-limit
Closed

(chore): increase MAX_ENTRY_SIZE for lightspeed#369
Jdubrick wants to merge 2 commits intoredhat-developer:mainfrom
Jdubrick:bump-package-size-limit

Conversation

@Jdubrick
Copy link
Copy Markdown

Description of the change

Which issue(s) does this PR fix or relate to

N/A

How to test changes / Special notes to the reviewer

Checklist

  • For each Chart updated, version bumped in the corresponding Chart.yaml according to Semantic Versioning.
  • For each Chart updated, variables are documented in the values.yaml and added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Run pre-commit run --all-files to run the hooks and then push any resulting changes. The pre-commit Workflow will enforce this and warn you if needed.
  • JSON Schema template updated and re-generated the raw schema via the pre-commit hook.
  • Tests pass using the Chart Testing tool and the ct lint command.
  • If you updated the orchestrator-infra chart, make sure the versions of the Knative CRDs are aligned with the versions of the CRDs installed by the OpenShift Serverless operators declared in the values.yaml file. See Installing Knative Eventing and Knative Serving CRDs for more details.

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
@rhdh-qodo-merge
Copy link
Copy Markdown

rhdh-qodo-merge Bot commented Apr 23, 2026

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider


Action required

1. Unversioned chart change 🐞 Bug ☼ Reliability
Description
The PR modifies the backstage chart defaults (values.yaml and values.schema.json) but does not
increment charts/backstage/Chart.yaml version, so the change is not properly tracked as a new chart
release/upgrade. This violates the repository contribution checklist and may cause chart
lint/release flows to reject or miss the update.
Code

charts/backstage/values.yaml[R385-386]

          - name: MAX_ENTRY_SIZE
-            value: "30000000"
+            value: "40000000"
Relevance

⭐⭐⭐ High

Team enforces chart SemVer bumps on chart changes; versioning guidance accepted previously (e.g.,
correct bump type).

PR-#186
PR-#248
PR-#291

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
charts/backstage/Chart.yaml explicitly states the chart version should be incremented each time the
chart is changed, yet it remains at 5.8.0 after this PR changes chart values defaults. The
repository CONTRIBUTING checklist also requires bumping Chart.yaml for each updated chart, and CI
runs chart-testing (ct lint) on changed charts, which commonly enforces chart metadata/version
correctness.

charts/backstage/Chart.yaml[45-50]
CONTRIBUTING.md[5-12]
.github/workflows/lint.yaml[45-65]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The PR changes chart defaults (values.yaml / values.schema.json) but does not bump `charts/backstage/Chart.yaml` `version`, which the repo’s contributing guidance requires for any chart update.

## Issue Context
This change updates `MAX_ENTRY_SIZE` default for the `upstream.backstage.initContainers` env. The chart version is still `5.8.0`.

## Fix Focus Areas
- charts/backstage/Chart.yaml[45-50]

## Suggested fix
- Increment `version:` in `charts/backstage/Chart.yaml` (likely a patch bump, e.g., `5.8.0` -> `5.8.1`).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
@sonarqubecloud
Copy link
Copy Markdown

@rhdh-qodo-merge
Copy link
Copy Markdown

Review Summary by Qodo

Increase MAX_ENTRY_SIZE limit for Lightspeed installation

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Increase MAX_ENTRY_SIZE from 30000000 to 40000000
• Resolves Lightspeed installation failures
• Updates both values.yaml and JSON schema
Diagram
flowchart LR
  A["MAX_ENTRY_SIZE<br/>30000000"] -- "increase limit" --> B["MAX_ENTRY_SIZE<br/>40000000"]
  B -- "applied to" --> C["Backstage Chart<br/>Configuration"]
Loading

Grey Divider

File Changes

1. charts/backstage/values.yaml ⚙️ Configuration changes +1/-1

Increase MAX_ENTRY_SIZE environment variable value

• Updated MAX_ENTRY_SIZE environment variable from 30000000 to 40000000
• Change applied to initContainers configuration
• Addresses Lightspeed installation failures

charts/backstage/values.yaml


2. charts/backstage/values.schema.json ⚙️ Configuration changes +1/-1

Update schema default for MAX_ENTRY_SIZE

• Updated MAX_ENTRY_SIZE default value from 30000000 to 40000000
• Synchronized schema with values.yaml changes
• Maintains consistency in chart configuration

charts/backstage/values.schema.json


Grey Divider

Qodo Logo

@Jdubrick
Copy link
Copy Markdown
Author

Closing as we figure out if value is actually needed anymore

@Jdubrick Jdubrick closed this Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant