ci: revert "fix(ci): temporarily pin catalog index image in CI to 1.10-51 to work around wrong lightspeed OCI refs [RHDHBUGS-3095]"

[rm3l]

Description of the change

This reverts commit 8e40fbf.

Which issue(s) does this PR fix or relate to

• JIRA_issue_link

How to test changes / Special notes to the reviewer

Checklist

• For each Chart updated, version bumped in the corresponding Chart.yaml according to Semantic Versioning.
• For each Chart updated, variables are documented in the values.yaml and added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Run pre-commit run --all-files to run the hooks and then push any resulting changes. The pre-commit Workflow will enforce this and warn you if needed.
• JSON Schema template updated and re-generated the raw schema via the pre-commit hook.
• Tests pass using the Chart Testing tool and the ct lint command.
• If you updated the orchestrator-infra chart, make sure the versions of the Knative CRDs are aligned with the versions of the CRDs installed by the OpenShift Serverless operators declared in the values.yaml file. See Installing Knative Eventing and Knative Serving CRDs for more details.

[rhdh-qodo-merge]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[rhdh-qodo-merge]

Review Summary by Qodo

Revert catalog index image tag pinning in CI workflows

📦 Other

Walkthroughs

Description

• Removes temporary catalog index image tag pinning from CI workflows
• Reverts workaround for lightspeed OCI refs issue ([RHDHBUGS-3095](https://redhat.atlassian.net/browse/RHDHBUGS-3095))
• Simplifies Helm arguments in nightly and test workflows
• Allows catalog index to use latest version in CI

Diagram

flowchart LR
  A["CI Workflows<br/>nightly.yaml & test.yaml"] -->|Remove pinning| B["catalogIndex.image.tag=1.10-51"]
  B -->|Revert| C["Use latest catalog index"]
  C -->|Result| D["Simplified Helm args"]

Loading

File Changes

1. .github/workflows/nightly.yaml ⚙️ Configuration changes +1/-2

Remove catalog index tag pinning from nightly workflow

• Removes --set global.catalogIndex.image.tag=1.10-51 from extra_helm_args
• Deletes TODO comment referencing [RHDHBUGS-3095](https://redhat.atlassian.net/browse/RHDHBUGS-3095) workaround
• Keeps other Helm arguments for backstage image configuration

.github/workflows/nightly.yaml

---

2. .github/workflows/test.yaml ⚙️ Configuration changes +1/-2

Remove catalog index tag pinning from test workflow

• Removes --set global.catalogIndex.image.tag=1.10-51 from conditional Helm args
• Deletes TODO comment referencing [RHDHBUGS-3095](https://redhat.atlassian.net/browse/RHDHBUGS-3095) workaround
• Simplifies main branch condition to only set backstage image parameters
• Changes fallback from pinned tag to empty string for non-main branches

.github/workflows/test.yaml

---