Skip to content

Commit 65e599a

Browse files
committed
fix: use "true" instead of "1" for E2E_COLLECT_COVERAGE env var
For consistency with other boolean env vars in the codebase (like E2E_NIGHTLY_MODE, USE_NEW_FRONTEND_SYSTEM), change from checking "1" to checking "true". Updated in: - src/playwright/fixtures/test.ts (_coverageCollector fixture) - src/utils/plugin-metadata.ts (coverage image swap) - docs/changelog.md (documentation) Addresses: #95 (comment)
1 parent 309c8b1 commit 65e599a

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/utils/plugin-metadata.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,7 @@ async function resolvePluginPackages(
489489
const prUrl = prOciUrls.get(displayName);
490490
if (prUrl) {
491491
const usesCoverage =
492-
process.env.E2E_COLLECT_COVERAGE === "1" &&
492+
process.env.E2E_COLLECT_COVERAGE === "true" &&
493493
metadata.role === "frontend-plugin";
494494
const resolved = usesCoverage
495495
? prUrl.replace(/(:[^!]+)/, "$1__coverage")

0 commit comments

Comments
 (0)