Merge branch 'main' into install-orch-fix

Author: rostalan

.yarnrc.yml

@@ -1 +1,5 @@
+compressionLevel: mixed
+
+enableGlobalCache: false
+
 nodeLinker: node-modules

docs/changelog.md

@@ -2,7 +2,7 @@
 
 All notable changes to this project will be documented in this file.
 
-## [1.1.29] - Current
+## [1.1.30] - Current
 
 ### Fixed
 
@@ -11,6 +11,20 @@ All notable changes to this project will be documented in this file.
 - **Add `startingCSV` pinning to `logic-operator.v1.37.2`**: Ensures the subscription installs the exact OSL version instead of whatever `stable` channel resolves to.
 - **Add `prepack` lifecycle script**: Ensures `dist/` is built when the package is installed as a git dependency (Yarn 3 packs from source, skipping gitignored `dist/`).
 
+## [1.1.29]
+
+### Changed
+
+- **Pin all dependency versions**: Removed `^` range prefixes from all `dependencies` and `devDependencies` to use exact versions, preventing unexpected breaking changes from transitive updates. `peerDependencies` retain ranges for consumer flexibility.
+- **Update all dependencies to latest versions**: Bumped all packages to their latest versions except `@keycloak/keycloak-admin-client` (pinned at 26.5.6 due to broken postinstall in newer versions). Notable major bumps: `eslint` 9→10, `@eslint/js` 9→10, `typescript` 5→6, `otplib` 12→13, `lint-staged` 15→16.
+- **Update Yarn to 4.12.0**: Bumped `packageManager` from `yarn@3.8.7` to `yarn@4.12.0`.
+
+### Fixed
+
+- **Migrate `otplib` v12→v13**: Replaced removed `authenticator.generate(secret)` API with `generateSync({ secret })` in `LoginHelper`.
+- **Preserve error cause in re-thrown errors**: Added `{ cause: error }` to wrapped errors in `RHDHDeployment` and `KubernetesClientHelper` for better error chain traceability.
+- **Use optional chaining in `APIHelper.deleteUserEntityFromAPI`**: Replaced verbose null check with optional chain (`r.metadata?.uid`).
+
 ## [1.1.28]
 
 - **APIHelper.createGitHubRepoWithFile**: Ensure file creation happens after repository creation.

package.json

@@ -89,37 +89,37 @@
     "@playwright/test": "^1.57.0"
   },
   "devDependencies": {
-    "@backstage/catalog-model": "1.7.5",
-    "@playwright/test": "^1.57.0",
-    "@types/fs-extra": "^11.0.4",
-    "@types/js-yaml": "^4.0.9",
-    "@types/lodash.clonedeepwith": "^4.5.9",
-    "@types/lodash.mergewith": "^4.6.9",
-    "@types/node": "^24.10.1",
-    "@types/proper-lockfile": "^4.1.4",
-    "husky": "^9.1.7",
-    "lint-staged": "^15.4.3",
-    "markdown-link-check": "^3.13.6"
+    "@backstage/catalog-model": "1.7.7",
+    "@playwright/test": "1.59.1",
+    "@types/fs-extra": "11.0.4",
+    "@types/js-yaml": "4.0.9",
+    "@types/lodash.clonedeepwith": "4.5.9",
+    "@types/lodash.mergewith": "4.6.9",
+    "@types/node": "25.5.2",
+    "@types/proper-lockfile": "4.1.4",
+    "husky": "9.1.7",
+    "lint-staged": "16.4.0",
+    "markdown-link-check": "3.14.2"
   },
   "dependencies": {
-    "@axe-core/playwright": "^4.11.0",
-    "@backstage-community/plugin-rbac-common": "1.23.0",
-    "@eslint/js": "^9.39.1",
+    "@axe-core/playwright": "4.11.1",
+    "@backstage-community/plugin-rbac-common": "1.26.0",
+    "@eslint/js": "10.0.1",
     "@keycloak/keycloak-admin-client": "26.5.6",
-    "@kubernetes/client-node": "^1.4.0",
-    "eslint": "^9.39.1",
-    "eslint-plugin-check-file": "^3.3.1",
-    "eslint-plugin-playwright": "^2.4.0",
-    "fs-extra": "^11.3.2",
-    "js-yaml": "^4.1.1",
-    "lodash.clonedeepwith": "^4.5.0",
-    "lodash.mergewith": "^4.6.2",
-    "otplib": "12.0.1",
-    "prettier": "^3.7.4",
-    "proper-lockfile": "^4.1.2",
-    "typescript": "^5.9.3",
-    "typescript-eslint": "^8.48.1",
-    "zx": "^8.8.5"
+    "@kubernetes/client-node": "1.4.0",
+    "eslint": "10.2.0",
+    "eslint-plugin-check-file": "3.3.1",
+    "eslint-plugin-playwright": "2.10.1",
+    "fs-extra": "11.3.4",
+    "js-yaml": "4.1.1",
+    "lodash.clonedeepwith": "4.5.0",
+    "lodash.mergewith": "4.6.2",
+    "otplib": "13.4.0",
+    "prettier": "3.8.1",
+    "proper-lockfile": "4.1.2",
+    "typescript": "6.0.2",
+    "typescript-eslint": "8.58.1",
+    "zx": "8.8.5"
   },
-  "packageManager": "yarn@3.8.7"
+  "packageManager": "yarn@4.12.0"
 }

src/deployment/rhdh/deployment.ts

@@ -386,6 +386,7 @@ export class RHDHDeployment {
     } catch (error) {
       throw new Error(
         `RHDH deployment failed in ${namespace}: ${error instanceof Error ? error.message : error}`,
+        { cause: error },
       );
     }
 

src/playwright/helpers/api-helper.ts

@@ -297,7 +297,7 @@ export class APIHelper {
 
   async deleteUserEntityFromAPI(user: string) {
     const r: UserEntity = await this.getCatalogUserFromAPI(user);
-    if (!r.metadata || !r.metadata.uid) {
+    if (!r.metadata?.uid) {
       return;
     }
     const url = `${this.baseUrl}/api/catalog/entities/by-uid/${r.metadata.uid}`;

src/playwright/helpers/common.ts

@@ -1,5 +1,5 @@
 import { UIhelper } from "./ui-helper.js";
-import { authenticator } from "otplib";
+import { generateSync } from "otplib";
 import { test, expect } from "@playwright/test";
 import type { Browser, Page, TestInfo } from "@playwright/test";
 import { SETTINGS_PAGE_COMPONENTS } from "../page-objects/page-obj.js";
@@ -222,12 +222,12 @@ export class LoginHelper {
       throw new Error("Invalid User ID");
     }
 
-    return authenticator.generate(secret);
+    return generateSync({ secret });
   }
 
   getGoogle2FAOTP(): string {
     const secret = process.env.GOOGLE_2FA_SECRET as string;
-    return authenticator.generate(secret);
+    return generateSync({ secret });
   }
 
   async keycloakLogin(username: string, password: string) {
@@ -302,7 +302,7 @@ export class LoginHelper {
         .locator("[type='submit'][value='Sign in']:not(webauthn-status *)")
         .first()
         .click({ timeout: 5000 });
-      const twofactorcode = authenticator.generate(twofactor);
+      const twofactorcode = generateSync({ secret: twofactor });
       await popup.locator("#app_totp").click({ timeout: 5000 });
       await popup.locator("#app_totp").fill(twofactorcode, { timeout: 5000 });
 

src/utils/kubernetes-client.ts

@@ -43,6 +43,7 @@ class KubernetesClientHelper {
             `Kubeconfig locations checked:\n` +
             `  - KUBECONFIG env: ${process.env.KUBECONFIG || "(not set)"}\n` +
             `  - Default: ~/.kube/config`,
+          { cause: error },
         );
       }
       throw error;
@@ -485,6 +486,7 @@ class KubernetesClientHelper {
     } catch (error) {
       throw new Error(
         `Failed to get cluster ingress domain: ${error instanceof Error ? error.message : error}`,
+        { cause: error },
       );
     }
   }
@@ -510,6 +512,7 @@ class KubernetesClientHelper {
     } catch (error) {
       throw new Error(
         `Failed to get route ${name} in namespace ${namespace}: ${error instanceof Error ? error.message : error}`,
+        { cause: error },
       );
     }
   }