feat: add unit tests for plugin metadata resolution#70
Merged
subhashkhileri merged 1 commit intoMar 31, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/utils/tests/:plugin-metadata.test.ts— pure utilities (extractPluginName, getNormalizedPluginMergeKey,disablePluginWrappers, generatePluginsFromMetadata)
plugin-metadata.pr.test.ts— PR mode: metadata injection, user override, OCI resolution, skipinjection, precedence
plugin-metadata.nightly.test.ts— nightly detection (isNightlyJob), nightly resolution, user configpreservation
plugin-metadata.fixtures.test.ts— realistic workspace fixtures (argocd, scorecard, github-events,topology, global-header, orchestrator) + edge cases
helpers.ts) for env var isolation and metadata fixture creationyarn build && yarn testto pre-commit hook so tests run locally before every commitWhat's tested
(redhat-resource-optimization pattern)
overrides
E2E_NIGHTLY_MODEstrict check (rejects"false"),JOB_NAMEperiodic detection,PR precedence over nightly
fields preserved
Verified by breaking
Each critical code path was intentionally broken to confirm tests fail with clear messages: