Skip to content

chore(deps): Revert "chore(deps): update redhat-plumbers-in-action/differential-shellcheck digest to 929381c (#1206)"#1303

Merged
rm3l merged 1 commit into
redhat-developer:mainfrom
rm3l:rhidp-6780-operator-fix-shellcheck-errors-reported-in-gh-code-scanning--revert-differential-shellcheck-update
Jun 25, 2025
Merged

chore(deps): Revert "chore(deps): update redhat-plumbers-in-action/differential-shellcheck digest to 929381c (#1206)"#1303
rm3l merged 1 commit into
redhat-developer:mainfrom
rm3l:rhidp-6780-operator-fix-shellcheck-errors-reported-in-gh-code-scanning--revert-differential-shellcheck-update

Conversation

@rm3l

@rm3l rm3l commented Jun 25, 2025

Copy link
Copy Markdown
Member

Description

For some reason, this dependency update is supposed to have fixed some
alerts that were displayed in Code Scanning. But these alerts seem to be
still relevant. So reverting so that the alerts can be reopened and so
that we can work on fixing those alerts (at least the most critical
ones).

This reverts commit 91f5b2c.

Which issue(s) does this PR fix or relate to

Relates to https://issues.redhat.com/browse/RHIDP-6780

PR acceptance criteria

  • Tests
  • Documentation

How to test changes / Special notes to the reviewer

…ellcheck digest to 929381c (redhat-developer#1206)"

For some reason, this dependency update was supposed to have fixed some
alerts that were displayed in Code Scanning. But these alerts seem to be
still relevant. So reverting so that the alerts can be reopened and so
that we can work on fixing those alerts (at least the most critical
ones).

This reverts commit 91f5b2c.
@sourcery-ai

sourcery-ai Bot commented Jun 25, 2025

Copy link
Copy Markdown
Contributor

Reviewer's Guide

This PR reverts the recent bump of the differential-shellcheck action in the CI workflow by restoring its prior commit hash, enabling the reopening of existing code scanning alerts for further triage.

File-Level Changes

Change Details Files
Revert differential-shellcheck version update in CI configuration
  • Changed action reference from newer digest back to original digest
.github/workflows/scripts-checks.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@openshift-ci

openshift-ci Bot commented Jun 25, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kadel for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rm3l - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rm3l rm3l merged commit d0da24f into redhat-developer:main Jun 25, 2025
8 of 9 checks passed
@rm3l rm3l deleted the rhidp-6780-operator-fix-shellcheck-errors-reported-in-gh-code-scanning--revert-differential-shellcheck-update branch June 25, 2025 15:57
Fortune-Ndlovu pushed a commit to Fortune-Ndlovu/rhdh-operator that referenced this pull request Sep 6, 2025
…ellcheck digest to 929381c (redhat-developer#1206)" (redhat-developer#1303)

For some reason, this dependency update was supposed to have fixed some
alerts that were displayed in Code Scanning. But these alerts seem to be
still relevant. So reverting so that the alerts can be reopened and so
that we can work on fixing those alerts (at least the most critical
ones).

This reverts commit 91f5b2c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant