chore: change behavior of filtered versions for restricted env.#1480
Merged
Conversation
Contributor
Reviewer's GuideThe prepare-restricted-environment.sh script now disables version filtering by default using a wildcard and enforces that CI index builds must explicitly specify a version filter; this is implemented by updating defaults, enhancing the help text and examples, introducing a flag-tracking variable, and adding a validation block. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Co-Authored-By: Fortune Ndlovu <fndlovu@redhat.com>
gazarenkov
approved these changes
Aug 7, 2025
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fortune-Ndlovu, gazarenkov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fortune-Ndlovu
added a commit
to Fortune-Ndlovu/rhdh-operator
that referenced
this pull request
Sep 6, 2025
…at-developer#1480) * chore: change filtered versions for restricted env. behaviour * Fix ShellCheck * Resolve review comments Co-Authored-By: Fortune Ndlovu <fndlovu@redhat.com> --------- Co-authored-by: Fortune Ndlovu <fndlovu@redhat.com>
This was referenced Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change the behavior of
prepare-restricted-environment.shscript so that by default, no versions are filtered.Also, for CI images (when using
--ci-index), require to specify the version filter by--filter-versionsflag. This option is used only for testing purposes, where you want to test one specific image.Which issue(s) does this PR fix or relate to
PR acceptance criteria
How to test changes / Special notes to the reviewer
Summary by Sourcery
Update prepare-restricted-environment.sh to disable default version filtering and enforce explicit version filter for CI index images
Enhancements: