Skip to content

chore: Update default IIB tag in CI install script#2083

Merged
rm3l merged 1 commit into
redhat-developer:mainfrom
rm3l:chore/update_default_iib_tag_in_install_script
Jan 8, 2026
Merged

chore: Update default IIB tag in CI install script#2083
rm3l merged 1 commit into
redhat-developer:mainfrom
rm3l:chore/update_default_iib_tag_in_install_script

Conversation

@rm3l

@rm3l rm3l commented Jan 8, 2026

Copy link
Copy Markdown
Member

Description

Update default IIB tag in CI install script. This is the default tag pulled when running the install script on non-OCP clusters. On OCP, this is determined automatically based on the current OCP version.

Which issue(s) does this PR fix or relate to

PR acceptance criteria

  • Tests
  • Documentation

How to test changes / Special notes to the reviewer

@rhdh-qodo-merge

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🔒 No security concerns identified
⚡ Recommended focus areas for review

Compatibility

The default OCP_VER value for non-OpenShift clusters is now hardcoded to a newer version. Please validate that the corresponding default IIB tag/image for this version exists and is accessible in the target registries, and that using this value won’t break installs on non-OCP clusters (where OCP version detection does not apply).

OCP_VER="v4.21"
OCP_ARCH="x86_64"
📄 References
  1. redhat-developer/rhdh-operator/config/profile/rhdh/plugin-infra/plugin-infra.sh [1-49]
  2. redhat-developer/rhdh-operator/config/profile/rhdh/plugin-infra/plugin-infra.sh [50-75]
  3. redhat-developer/rhdh-operator/config/profile/rhdh/plugin-infra/gitops-secret-setup.sh [199-222]
  4. redhat-developer/rhdh-operator/config/profile/rhdh/plugin-infra/gitops-secret-setup.sh [1-35]
  5. redhat-developer/rhdh-operator/config/profile/rhdh/plugin-infra/gitops-secret-setup.sh [37-62]
  6. redhat-developer/rhdh-operator/config/profile/rhdh/plugin-infra/gitops-secret-setup.sh [133-182]
  7. redhat-developer/rhdh-operator/config/profile/rhdh/plugin-infra/gitops-secret-setup.sh [87-130]
  8. redhat-developer/rhdh-operator/config/profile/rhdh/plugin-infra/gitops-secret-setup.sh [183-197]

@rhdh-qodo-merge rhdh-qodo-merge Bot added the enhancement New feature or request label Jan 8, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jan 8, 2026

Copy link
Copy Markdown

@rhdh-qodo-merge

Copy link
Copy Markdown

PR Type

Enhancement


Description

  • Update default OCP version from v4.16 to v4.21 in install script

  • Affects IIB tag selection for non-OCP cluster deployments


File Walkthrough

Relevant files
Configuration changes
install-rhdh-catalog-source.sh
Update default OCP version constant                                           

.rhdh/scripts/install-rhdh-catalog-source.sh

  • Updated default OCP_VER variable from "v4.16" to "v4.21"
  • This default is used when running the install script on non-OCP
    clusters
  • On OCP clusters, the version is determined automatically based on
    current OCP version
+1/-1     

@rhdh-qodo-merge

Copy link
Copy Markdown

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Enable environment override of default version

Make the OCP_VER variable configurable by allowing it to be set from the
environment, with "v4.21" as the default value.

.rhdh/scripts/install-rhdh-catalog-source.sh [650]

-OCP_VER="v4.21"
+OCP_VER="${OCP_VER:-v4.21}"
  • Apply / Chat
Suggestion importance[1-10]: 6

__

Why: The suggestion correctly proposes making the OCP_VER configurable via an environment variable, which improves the script's flexibility over the hardcoded value in the PR.

Low
  • More

@openshift-ci

openshift-ci Bot commented Jan 8, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gazarenkov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Jan 8, 2026
@rm3l rm3l merged commit 80b4e02 into redhat-developer:main Jan 8, 2026
10 of 11 checks passed
@rm3l rm3l deleted the chore/update_default_iib_tag_in_install_script branch January 8, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants