[chore] Updating orchestrator npm packages to OCI artifacts#2231
Conversation
Signed-off-by: Leanne Ahern <lahern@redhat.com>
|
/cherry-pick release-1.9 |
|
@rm3l: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
If we use quay refs here instead, you can't cherry pick because the plugins will be using different tags (1.9.0-- or 1.10.0--) and therefore also different digests. |
This option is supported as of RHDH 1.9 and allows inheriting the version from the dynamic-plugins.default.yaml (coming from the plugin catalog index image). This way, we are sure to use the default plugin version. NOTE: For this to work properly, the plugin refs should match. So if the orchestrator plugins refs are changed later to quay.io or registry.access.redhat.com in the DPDY, we should update them here as well.
Yeah, this is exactly the kind of issues I think the |
Signed-off-by: Leanne Ahern <lahern@redhat.com>
Signed-off-by: Leanne Ahern <lahern@redhat.com>
Co-authored-by: OpinionatedHeron <OpinionatedHeron@users.noreply.github.com>
|
|
Signed-off-by: Leanne Ahern <lahern@redhat.com>
…on/rhdh-operator into startOrchestrator
|
rm3l
left a comment
There was a problem hiding this comment.
LGTM, but this should be documented as a breaking change in 1.9.0 for Operator users.
/lgtm
| - package: "@redhat/backstage-plugin-orchestrator@1.8.2" | ||
| disabled: false | ||
| - package: "@redhat/backstage-plugin-orchestrator-backend-dynamic@1.8.2" | ||
| disabled: false | ||
| dependencies: | ||
| - ref: sonataflow | ||
| - package: "@redhat/backstage-plugin-scaffolder-backend-module-orchestrator-dynamic@1.8.2" | ||
| disabled: false | ||
| - package: "@redhat/backstage-plugin-orchestrator-form-widgets@1.8.2" | ||
| disabled: false | ||
| - package: 'oci://registry.access.redhat.com/rhdh/red-hat-developer-hub-backstage-plugin-orchestrator:{{inherit}}' | ||
| disabled: false | ||
| - package: 'oci://registry.access.redhat.com/rhdh/red-hat-developer-hub-backstage-plugin-orchestrator-backend:{{inherit}}' | ||
| disabled: false | ||
| dependencies: | ||
| - ref: sonataflow | ||
| - package: 'oci://registry.access.redhat.com/rhdh/red-hat-developer-hub-backstage-plugin-scaffolder-backend-module-orchestrator:{{inherit}}' | ||
| disabled: false | ||
| - package: 'oci://registry.access.redhat.com/rhdh/red-hat-developer-hub-backstage-plugin-orchestrator-form-widgets:{{inherit}}' | ||
| disabled: false |
There was a problem hiding this comment.
LGTM, but I think this would need to be documented as a known issue or breaking change in 1.9.0 (affecting only Operator users).
In 1.8, Operator users needed to explicitly use the @redhat/* NPM refs in their dynamic-plugins config in order to deploy the Orchestrator flavor, and now they would need to explicitly switch to the OCI refs, otherwise RHDH will fail to start IMO. So it will break Operator users that have existing Orchestrator-flavored instances of RHDH.
There was a problem hiding this comment.
I quickly tested an upgrade from 1.8 to this PR branch, and the init container failed to start until I manually update my dynamic-plugins config, which confirms this upgrade issue.
[...]
======= Skipping disabled dynamic plugin oci://registry.access.redhat.com/rhdh/red-hat-developer-hub-backstage-plugin-orchestrator@sha256:7355b244d463187b11174b091b10235167ffc6fbd9466ec3cff0a8b5b04d6e98!red-hat-developer-hub-backstage-plugin-orchestrator
======= Skipping disabled dynamic plugin oci://registry.access.redhat.com/rhdh/red-hat-developer-hub-backstage-plugin-scaffolder-backend-module-orchestrator@sha256:6a138dd4c6bb7b98d7af58657395fc3ef3b96768276a2d65d9a7ef5fda52f2b5!red-hat-developer-hub-backstage-plugin-scaffolder-backend-module-orchestrator
======= Installing dynamic plugin @redhat/backstage-plugin-orchestrator@1.8.2
Traceback (most recent call last):
File "/opt/app-root/src/install-dynamic-plugins.py", line 1284, in <module>
main()
File "/opt/app-root/src/install-dynamic-plugins.py", line 1269, in main
_, plugin_config = install_plugin(plugin, plugin_path_by_hash, dynamic_plugins_root, skip_integrity_check)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/app-root/src/install-dynamic-plugins.py", line 917, in install_plugin
plugin_path = installer.install(plugin, plugin_path_by_hash)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/app-root/src/install-dynamic-plugins.py", line 810, in install
raise InstallException(f"No integrity hash provided for Package {package}")
InstallException: No integrity hash provided for Package @redhat/backstage-plugin-orchestrator@1.8.2
======= Cleaning up temporary catalog index directory
======= Removed lock file: /dynamic-plugins-root/install-dynamic-plugins.lock
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rm3l The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8228512
into
redhat-developer:main
|
@rm3l: #2231 failed to apply on top of branch "release-1.9": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…eveloper#2231) * Updating orchestrator npm packages to OCI artifacts Signed-off-by: Leanne Ahern <lahern@redhat.com> * Simplify the configuration by leveraging the {{inherit}} option This option is supported as of RHDH 1.9 and allows inheriting the version from the dynamic-plugins.default.yaml (coming from the plugin catalog index image). This way, we are sure to use the default plugin version. NOTE: For this to work properly, the plugin refs should match. So if the orchestrator plugins refs are changed later to quay.io or registry.access.redhat.com in the DPDY, we should update them here as well. * Updating orchestrator packages from ghcr.io to quay.io Signed-off-by: Leanne Ahern <lahern@redhat.com> * Correcting quay.io path Signed-off-by: Leanne Ahern <lahern@redhat.com> * Regenerate bundle/installer manifests Co-authored-by: OpinionatedHeron <OpinionatedHeron@users.noreply.github.com> * Updating quay.io paths to use registry.access.redhat Signed-off-by: Leanne Ahern <lahern@redhat.com> --------- Signed-off-by: Leanne Ahern <lahern@redhat.com> Co-authored-by: Armel Soro <asoro@redhat.com> Co-authored-by: Gennady Azarenkov <gazarenkov@gmail.com> Co-authored-by: Nick Boldt <nboldt@redhat.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: OpinionatedHeron <OpinionatedHeron@users.noreply.github.com>
…2282) * Updating orchestrator npm packages to OCI artifacts * Simplify the configuration by leveraging the {{inherit}} option This option is supported as of RHDH 1.9 and allows inheriting the version from the dynamic-plugins.default.yaml (coming from the plugin catalog index image). This way, we are sure to use the default plugin version. NOTE: For this to work properly, the plugin refs should match. So if the orchestrator plugins refs are changed later to quay.io or registry.access.redhat.com in the DPDY, we should update them here as well. * Updating orchestrator packages from ghcr.io to quay.io * Correcting quay.io path * Regenerate bundle/installer manifests * Updating quay.io paths to use registry.access.redhat --------- Signed-off-by: Leanne Ahern <lahern@redhat.com> Co-authored-by: Leanne Ahern <127859485+OpinionatedHeron@users.noreply.github.com> Co-authored-by: Gennady Azarenkov <gazarenkov@gmail.com> Co-authored-by: Nick Boldt <nboldt@redhat.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: OpinionatedHeron <OpinionatedHeron@users.noreply.github.com>



Description
Updating orchestrator npm packages to the relevant OCI Artifacts to reflect updates to RHDH.
npm packages were causing the scaffolder plugin to throw an error during startup
Which issue(s) does this PR fix or relate to
RHDHBUGS-2527
PR acceptance criteria
How to test changes / Special notes to the reviewer
Deploy Operator-based instance of RHDH with the orchestrator plugins enabled.