Skip to content

chore: enable minor Dockerfile updates#2723

Open
kim-tsao wants to merge 1 commit intoredhat-developer:mainfrom
kim-tsao:update_renovate
Open

chore: enable minor Dockerfile updates#2723
kim-tsao wants to merge 1 commit intoredhat-developer:mainfrom
kim-tsao:update_renovate

Conversation

@kim-tsao
Copy link
Copy Markdown
Member

Description

Enable the Renovate rule for PR creation whenever there is a minor image update. This will help close the gap on any missed version bumps. I'm not enabling automerge for these PRs yet unless we feel it's safe to do so.

Which issue(s) does this PR fix or relate to

https://redhat.atlassian.net/browse/RHIDP-12347

  • Fixes #issue_number

PR acceptance criteria

  • Tests
  • Documentation

How to test changes / Special notes to the reviewer

Signed-off-by: Kim Tsao <ktsao@redhat.com>
@rhdh-qodo-merge
Copy link
Copy Markdown

rhdh-qodo-merge Bot commented Apr 24, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (1)

Grey Divider


Action required

1. Minor Docker updates still blocked 📎 Requirement gap ≡ Correctness
Description
Minor Dockerfile image updates remain disabled on main because the global rule disables all
minor updates and the newly-enabled Docker exception only applies to release-1.* branches. This
does not meet the requirement to allow minor Dockerfile base-image update PRs in the repo.
Code

.github/renovate.json[R92-96]

+      "description": "Do generate PRs for minor dockerfile updates in 1.y ",
+      "enabled": true,
      "matchDatasources": [
        "docker"
      ],
Evidence
PR Compliance ID 19 requires Renovate to propose minor Dockerfile base-image updates. Although this
PR enables a Docker+minor rule, it is restricted to release-1.* branches, while a separate rule
still disables all minor updates (including Docker) broadly, leaving main suppressed.

Renovate allows minor Dockerfile base-image updates in rhdh-operator
.github/renovate.json[57-67]
.github/renovate.json[92-103]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Minor Dockerfile base-image updates are still suppressed on `main` due to a global `matchUpdateTypes: ["minor"]` rule with `enabled: false`, while the Docker exception is limited to `release-1.*` branches.

## Issue Context
Compliance requires that Renovate opens PRs for minor Dockerfile base-image updates in this repository. Any change must also keep minor Dockerfile updates **not automerged**.

## Fix Focus Areas
- .github/renovate.json[57-67]
- .github/renovate.json[92-103]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

@sonarqubecloud
Copy link
Copy Markdown

Comment thread .github/renovate.json
Comment on lines +92 to 96
"description": "Do generate PRs for minor dockerfile updates in 1.y ",
"enabled": true,
"matchDatasources": [
"docker"
],
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Minor docker updates still blocked 📎 Requirement gap ≡ Correctness

Minor Dockerfile image updates remain disabled on main because the global rule disables all
minor updates and the newly-enabled Docker exception only applies to release-1.* branches. This
does not meet the requirement to allow minor Dockerfile base-image update PRs in the repo.
Agent Prompt
## Issue description
Minor Dockerfile base-image updates are still suppressed on `main` due to a global `matchUpdateTypes: ["minor"]` rule with `enabled: false`, while the Docker exception is limited to `release-1.*` branches.

## Issue Context
Compliance requires that Renovate opens PRs for minor Dockerfile base-image updates in this repository. Any change must also keep minor Dockerfile updates **not automerged**.

## Fix Focus Areas
- .github/renovate.json[57-67]
- .github/renovate.json[92-103]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

@rhdh-qodo-merge
Copy link
Copy Markdown

Review Summary by Qodo

Enable Renovate minor Dockerfile image updates

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Enable Renovate rule for minor Dockerfile image updates
• Allow PR creation for version bumps in Docker dependencies
• Automerge disabled pending safety review
Diagram
flowchart LR
  A["Renovate Config"] -- "Enable minor updates" --> B["Docker Image PRs"]
  B -- "Manual merge required" --> C["Version Bump Applied"]
Loading

Grey Divider

File Changes

1. .github/renovate.json ⚙️ Configuration changes +2/-2

Enable minor Dockerfile update PR generation

• Changed enabled flag from false to true for minor Dockerfile updates rule
• Updated description to reflect that PRs will now be generated for minor updates
• Automerge remains disabled for safety

.github/renovate.json


Grey Divider

Qodo Logo

@rhdh-qodo-merge rhdh-qodo-merge Bot added the enhancement New feature or request label Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant