chore: enable minor Dockerfile updates#2723
Open
kim-tsao wants to merge 1 commit intoredhat-developer:mainfrom
Open
chore: enable minor Dockerfile updates#2723kim-tsao wants to merge 1 commit intoredhat-developer:mainfrom
kim-tsao wants to merge 1 commit intoredhat-developer:mainfrom
Conversation
Signed-off-by: Kim Tsao <ktsao@redhat.com>
Code Review by Qodo
1. Minor Docker updates still blocked
|
|
Comment on lines
+92
to
96
| "description": "Do generate PRs for minor dockerfile updates in 1.y ", | ||
| "enabled": true, | ||
| "matchDatasources": [ | ||
| "docker" | ||
| ], |
There was a problem hiding this comment.
1. Minor docker updates still blocked 📎 Requirement gap ≡ Correctness
Minor Dockerfile image updates remain disabled on main because the global rule disables all minor updates and the newly-enabled Docker exception only applies to release-1.* branches. This does not meet the requirement to allow minor Dockerfile base-image update PRs in the repo.
Agent Prompt
## Issue description
Minor Dockerfile base-image updates are still suppressed on `main` due to a global `matchUpdateTypes: ["minor"]` rule with `enabled: false`, while the Docker exception is limited to `release-1.*` branches.
## Issue Context
Compliance requires that Renovate opens PRs for minor Dockerfile base-image updates in this repository. Any change must also keep minor Dockerfile updates **not automerged**.
## Fix Focus Areas
- .github/renovate.json[57-67]
- .github/renovate.json[92-103]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Review Summary by QodoEnable Renovate minor Dockerfile image updates
WalkthroughsDescription• Enable Renovate rule for minor Dockerfile image updates • Allow PR creation for version bumps in Docker dependencies • Automerge disabled pending safety review Diagramflowchart LR
A["Renovate Config"] -- "Enable minor updates" --> B["Docker Image PRs"]
B -- "Manual merge required" --> C["Version Bump Applied"]
File Changes1. .github/renovate.json
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Enable the Renovate rule for PR creation whenever there is a minor image update. This will help close the gap on any missed version bumps. I'm not enabling automerge for these PRs yet unless we feel it's safe to do so.
Which issue(s) does this PR fix or relate to
https://redhat.atlassian.net/browse/RHIDP-12347
PR acceptance criteria
How to test changes / Special notes to the reviewer