Make empty flavours: [] disable Default Flavours

[gazarenkov]

Description

This is the fix for the issue when setting spec.flavours: [] (empty array) in a Backstage CR does not disable default flavours as documented.

Which issue(s) does this PR fix or relate to

https://redhat.atlassian.net/browse/RHDHBUGS-3198

PR acceptance criteria

• Tests
• Documentation

How to test changes / Special notes to the reviewer

1. Create a Backstage CR with explicit empty flavours array:

apiVersion: rhdh.redhat.com/v1alpha5
kind: Backstage
metadata:
  name: test-backstage
spec:
  flavours: []  # Explicitly disable all flavours

2. Check the deployed pod's configuration
3. Observe that default flavours (e.g., lightspeed) not loaded

[github-actions]

⚠️ Files changed in bundle and installer generation!

Those changes to the operator bundle/installer manifests should have been pushed automatically to your PR branch.

NOTE: If the PR checks are stuck after this additional commit, manually close the PR and immediately reopen it to trigger the checks again.

[github-actions]

PR images are available:

1. https://quay.io/rhdh-community/operator:0.11.0-pr-2909-5ac4f02
2. https://quay.io/rhdh-community/operator-bundle:0.11.0-pr-2909-5ac4f02
3. https://quay.io/rhdh-community/operator-catalog:0.11.0-pr-2909-5ac4f02

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.07%. Comparing base (cec3793) to head (ad8019a).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2909      +/-   ##
==========================================
+ Coverage   61.05%   61.07%   +0.01%     
==========================================
  Files          37       37              
  Lines        2108     2109       +1     
==========================================
+ Hits         1287     1288       +1     
  Misses        686      686              
  Partials      135      135              

Flag	Coverage Δ
nightly	?
unittests	61.07% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
pkg/model/flavour.go	75.92% <100.00%> (+0.45%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

PR images are available:

1. https://quay.io/rhdh-community/operator:0.11.0-pr-2909-2d03d04
2. https://quay.io/rhdh-community/operator-bundle:0.11.0-pr-2909-2d03d04
3. https://quay.io/rhdh-community/operator-catalog:0.11.0-pr-2909-2d03d04

[Fortune-Ndlovu]

/agentic_review

[rhdh-qodo-merge]

Code Review by Qodo

Sorry, something went wrong

We weren't able to complete the code review on our side. Please try again

[Fortune-Ndlovu]

When testing locally, I received no errors, and reconciliation completed cleanly. Below are just nitpicks worth considering

[Fortune-Ndlovu]

/review

[github-actions]

PR images are available:

1. https://quay.io/rhdh-community/operator:0.11.0-pr-2909-b1d1ea5
2. https://quay.io/rhdh-community/operator-bundle:0.11.0-pr-2909-b1d1ea5
3. https://quay.io/rhdh-community/operator-catalog:0.11.0-pr-2909-b1d1ea5

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

PR images are available:

1. https://quay.io/rhdh-community/operator:0.11.0-pr-2909-ad8019a
2. https://quay.io/rhdh-community/operator-bundle:0.11.0-pr-2909-ad8019a
3. https://quay.io/rhdh-community/operator-catalog:0.11.0-pr-2909-ad8019a

[Fortune-Ndlovu]

lgtm

[Fortune-Ndlovu]

/cherry-pick release-1.10

[openshift-cherrypick-robot]

@Fortune-Ndlovu: #2909 failed to apply on top of branch "release-1.10":

Applying: Add workflow to update dynamic plugins
Applying: debug
Applying: fix empty flavours array not disabling default flavours
Using index info to reconstruct a base tree...
M	api/v1alpha1/zz_generated.deepcopy.go
M	api/v1alpha2/zz_generated.deepcopy.go
M	api/v1alpha3/zz_generated.deepcopy.go
M	api/v1alpha4/zz_generated.deepcopy.go
M	api/v1alpha5/zz_generated.deepcopy.go
Falling back to patching base and 3-way merge...
Auto-merging api/v1alpha5/zz_generated.deepcopy.go
Applying: fix/add tests, point plugin-catalog-index to next tag
Applying: Regenerate bundle/installer manifests
Using index info to reconstruct a base tree...
M	bundle/backstage.io/manifests/backstage-operator.clusterserviceversion.yaml
M	bundle/rhdh/manifests/backstage-operator.clusterserviceversion.yaml
M	bundle/rhdh/manifests/rhdh-default-config_v1_configmap.yaml
M	dist/rhdh/install.yaml
Falling back to patching base and 3-way merge...
Auto-merging dist/rhdh/install.yaml
Auto-merging bundle/rhdh/manifests/rhdh-default-config_v1_configmap.yaml
Auto-merging bundle/rhdh/manifests/backstage-operator.clusterserviceversion.yaml
CONFLICT (content): Merge conflict in bundle/rhdh/manifests/backstage-operator.clusterserviceversion.yaml
Auto-merging bundle/backstage.io/manifests/backstage-operator.clusterserviceversion.yaml
CONFLICT (content): Merge conflict in bundle/backstage.io/manifests/backstage-operator.clusterserviceversion.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0005 Regenerate bundle/installer manifests

Details

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.