Skip to content

Commit 3232ef6

Browse files
committed
fix: update nyc from 15.1.0 to 18.0.0
Per kadel's feedback: "latest version is 18.0.0, 15.1.0 is 6 years old" Updated nyc from 15.1.0 (2020) to 18.0.0 (latest, Feb 2026) in: - scripts/instrument-plugin.sh - scripts/report-coverage.sh Ensures we get latest Istanbul features and bug fixes.
1 parent 7a7b6a2 commit 3232ef6

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

scripts/instrument-plugin.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ while IFS= read -r PROD_IMAGE; do
130130
# Instrument with nyc (pinned version for reproducibility)
131131
# Must run from work directory to avoid "outside project root" errors
132132
echo " Instrumenting with Istanbul/nyc..."
133-
if ! (cd "$WORK_DIR" && npx --yes nyc@15.1.0 instrument dist-original dist-instrumented --source-map); then
133+
if ! (cd "$WORK_DIR" && npx --yes nyc@18.0.0 instrument dist-original dist-instrumented --source-map); then
134134
echo " ❌ Instrumentation failed - skipping"
135135
rm -rf "$WORK_DIR"
136136
((SKIPPED_COUNT++))

scripts/report-coverage.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ fi
3939
echo ""
4040
echo "[INFO] Merging coverage data with nyc..."
4141
mkdir -p "$REPO_ROOT/.nyc_output"
42-
npx nyc@15.1.0 merge "$REPO_ROOT/$COVERAGE_JSON_DIR" "$REPO_ROOT/.nyc_output/out.json"
43-
(cd "$REPO_ROOT" && npx nyc@15.1.0 report --reporter=lcov --reporter=text-summary --report-dir coverage)
42+
npx nyc@18.0.0 merge "$REPO_ROOT/$COVERAGE_JSON_DIR" "$REPO_ROOT/.nyc_output/out.json"
43+
(cd "$REPO_ROOT" && npx nyc@18.0.0 report --reporter=lcov --reporter=text-summary --report-dir coverage)
4444

4545
if [[ ${#WORKSPACES[@]} -gt 1 ]]; then
4646
echo "[WARN] Multi-workspace coverage upload is not supported." >&2

0 commit comments

Comments
 (0)