handling for missing envs

Signed-off-by: rostalan <rlan@redhat.com>

Author: rostalan

workspaces/orchestrator/e2e-tests/tests/specs/orchestrator.tests.ts

@@ -29,12 +29,12 @@ interface WorkflowInstance {
   serviceUrl?: string;
 }
 
-function decodeEnvVar(name: string): string {
+function requireEnvVar(name: string): string {
   const value = process.env[name];
-  if (!value) {
+  if (!value?.trim()) {
     throw new Error(`Environment variable ${name} is not set`);
   }
-  return Buffer.from(value, "base64").toString();
+  return value;
 }
 
 function isDataIndexHealthy(ns: string): boolean {
@@ -331,17 +331,12 @@ test.describe("Orchestrator", () => {
 
       const backstageToken = await new AuthApiHelper(page).getToken();
 
-      const kcBaseUrl = decodeEnvVar("KEYCLOAK_AUTH_BASE_URL");
-      const kcRealm = decodeEnvVar("KEYCLOAK_AUTH_REALM");
-      const kcClientId = decodeEnvVar("KEYCLOAK_AUTH_CLIENTID");
-      const kcClientSecret = decodeEnvVar("KEYCLOAK_AUTH_CLIENT_SECRET");
-
-      const username = process.env.GH_USER_ID;
-      const password = process.env.GH_USER_PASS;
-      // eslint-disable-next-line playwright/no-conditional-in-test
-      if (!username || !password) {
-        throw new Error("GH_USER_ID and GH_USER_PASS must be set");
-      }
+      const kcBaseUrl = requireEnvVar("KEYCLOAK_BASE_URL");
+      const kcRealm = requireEnvVar("KEYCLOAK_REALM");
+      const kcClientId = requireEnvVar("KEYCLOAK_CLIENT_ID");
+      const kcClientSecret = requireEnvVar("KEYCLOAK_CLIENT_SECRET");
+      const username = process.env.GH_USER_ID || "test1";
+      const password = process.env.GH_USER_PASS || "test1@123";
 
       const tokenUrl = `${kcBaseUrl}/auth/realms/${kcRealm}/protocol/openid-connect/token`;