chore(rbac): migrate RBAC plugin tests from RHDH#1987
chore(rbac): migrate RBAC plugin tests from RHDH#1987gashcrumb merged 7 commits intoredhat-developer:mainfrom
Conversation
PatAKnight
requested review from
a team,
AndrienkoAleksandr,
divyanshiGupta,
dzemanov and
its-mitesh-kumar
as code owners
|
/publish |
|
Publish workflow has completed with success. Publishing process✅ Finished successfully.
Backstage Compatibility Check✅ All workspaces are compatible with the target Backstage version ( No action required. Metadata Validation✅ All metadata files validated successfully. Running e2e tests |
|
✅ Smoke tests workflow passed. All plugins loaded successfully. |
PatAKnight
force-pushed
the
rbac-test-migration
branch
from
2676343 to
7e434fa
Compare
|
/publish |
|
Publish workflow has completed with success. Publishing process✅ Finished successfully.
Backstage Compatibility Check✅ All workspaces are compatible with the target Backstage version ( No action required. Metadata Validation✅ All metadata files validated successfully. Running e2e tests |
|
✅ Smoke tests workflow passed. All plugins loaded successfully. |
❌ Failed E2E Tests -
|
PatAKnight
force-pushed
the
rbac-test-migration
branch
from
7e434fa to
6040782
Compare
|
/publish |
|
Publish workflow has completed with success. Publishing process✅ Finished successfully.
Backstage Compatibility Check✅ All workspaces are compatible with the target Backstage version ( No action required. Metadata Validation✅ All metadata files validated successfully. Running e2e tests |
|
✅ Smoke tests workflow passed. All plugins loaded successfully. |
❌ Failed E2E Tests -
|
github-actions
Bot
added
mandatory-workspace
PatAKnight
force-pushed
the
rbac-test-migration
branch
3 times, most recently
from
d81d1a7 to
a0321a1
Compare
|
/publish |
|
Publish workflow has completed with success. Publishing process✅ Finished successfully.
Backstage Compatibility Check✅ All workspaces are compatible with the target Backstage version ( No action required. Metadata Validation✅ All metadata files validated successfully. Running e2e tests |
|
✅ Smoke tests workflow passed. All plugins loaded successfully. |
✅ Passed E2E Tests -
|
|
/publish |
|
Publish workflow has completed with success. Publishing process✅ Finished successfully.
Backstage Compatibility Check✅ All workspaces are compatible with the target Backstage version ( No action required. Metadata Validation✅ All metadata files validated successfully. Running e2e tests |
PatAKnight
force-pushed
the
rbac-test-migration
branch
from
8fa7531 to
8c96554
Compare
|
/publish |
|
Publish workflow has completed with failure. Backstage Compatibility Check✅ All workspaces are compatible with the target Backstage version ( No action required. |
|
Publish workflow has completed with success. Publishing process✅ Finished successfully.
Backstage Compatibility Check✅ All workspaces are compatible with the target Backstage version ( No action required. Metadata Validation✅ All metadata files validated successfully. Running e2e tests |
|
✅ Smoke tests workflow passed. All plugins loaded successfully. |
✅ Passed E2E Tests -
|
|
/publish |
|
Publish workflow has completed with success. Publishing process✅ Finished successfully.
Backstage Compatibility Check✅ All workspaces are compatible with the target Backstage version ( No action required. Metadata Validation✅ All metadata files validated successfully. Running e2e tests |
|
✅ Smoke tests workflow passed. All plugins loaded successfully. |
✅ Passed E2E Tests -
|
Signed-off-by: Patrick Knight <pknight@redhat.com>
Signed-off-by: Patrick Knight <pknight@redhat.com>
Signed-off-by: Patrick Knight <pknight@redhat.com>
Signed-off-by: Patrick Knight <pknight@redhat.com>
Signed-off-by: Patrick Knight <pknight@redhat.com>
Signed-off-by: Patrick Knight <pknight@redhat.com>
Signed-off-by: Patrick Knight <pknight@redhat.com>
PatAKnight
force-pushed
the
rbac-test-migration
branch
from
5839f02 to
4d4579a
Compare
|
/publish |
|
|
Publish workflow has completed with success. Publishing process✅ Finished successfully.
Backstage Compatibility Check✅ All workspaces are compatible with the target Backstage version ( No action required. Metadata Validation✅ All metadata files validated successfully. Running e2e tests |
|
✅ Smoke tests workflow passed. All plugins loaded successfully. |
✅ Passed E2E Tests -
|
3 participants
Description
This PR aims to migrate the RBAC E2E tests over from the RHDH repo. There are a number of changes that I went in and perform to try to make these easier to maintain as well as make them more resilient and less flaky.
First, I removed the RBAC API E2E tests as they are technically covered by the unit tests within the RBAC backend plugin and it made more sense for them to be handled at the plugin level compared to the overlays repo.
Second, I went in and refactored a lot of the tests so that there is less duplication throughout. There were a number of selectors/locators that were duplicated throughout the pages/objects/spec files that made it hard for us to update when there were changes to the frontend. Where ever possible, I tried to reduce this by targeting ones that were repeated several times over.
Third, I removed a lot of code that was no longer used. I believe that these were hold overs from a time where the UI was much different.
Fourth, I updated as many of the serial tests as possible so that they are more independent and can now be ran in parallel. There is still one serial run left, but that one truly has requirements from previous tests.
Fifth, where ever possible, I pulled stuff up and out into constants. So, we now have a single source for roles, users, and groups to hopefully make it easier to make changes. As part of this approach, I renamed users, groups, and roles to more meaningful names to make it easier to understand what they are doing.
Sixth, I have a fall back
afterAllto ensure that all roles, policies, and conditions are properly cleaned up at the end. This is so that failures don't end up impacting future tests in the event that we enable retries. This was something that was scattered throughout the original tests and didn't cover all of the created roles, policies, and conditions during testing.Seventh, added some catalog entities so that they live with the tests instead of being referenced from external sources. This should hopefully make it easier to make changes without needing to track down the entity and finding the right person to approve them.
Which issue(s) does this PR fix