fix: use 'true' instead of '1' for E2E_COLLECT_COVERAGE#2564
Merged
gustavolira merged 1 commit intoJun 4, 2026
Merged
Conversation
Aligns with e2e-test-utils PR redhat-developer#95 (merged 2026-06-04) which changed from checking E2E_COLLECT_COVERAGE === "1" to === "true" for consistency with other boolean env vars (E2E_NIGHTLY_MODE, USE_NEW_FRONTEND_SYSTEM). Changes: - run-e2e.sh: default from "1" to "true", update all checks - scripts/upload-coverage.sh: update example and error message - scripts/report-coverage.sh: update example This fixes coverage collection which was broken because the overlay repo was setting E2E_COLLECT_COVERAGE=1 but test-utils now expects E2E_COLLECT_COVERAGE=true.
|
hopehadfield
approved these changes
Jun 4, 2026
Member
Author
|
/publish |
Contributor
|
PR action ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns E2E_COLLECT_COVERAGE value with e2e-test-utils PR #95.
Problem
After merging redhat-developer/rhdh-e2e-test-utils#95, coverage collection stopped working because:
E2E_COLLECT_COVERAGE=1(in run-e2e.sh)E2E_COLLECT_COVERAGE === "true"Fix
Updated all occurrences from "1" to "true" to match:
This aligns with the boolean env var convention used elsewhere (E2E_NIGHTLY_MODE, etc).
Testing
After merge, re-run /publish on PR #2550 to validate end-to-end coverage collection.