Skip to content

Commit 367195b

Browse files
authored
fix: use resolveMetricTranslation in drilldown table (#3101)
Signed-off-by: Diana Janickova <djanicko@redhat.com>
1 parent 41e0cb2 commit 367195b

2 files changed

Lines changed: 9 additions & 3 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@red-hat-developer-hub/backstage-plugin-scorecard': patch
3+
---
4+
5+
Fix drilldown page header showing raw provider title instead of the translated scorecard title

workspaces/scorecard/plugins/scorecard/src/components/ScorecardPage/ScorecardPage.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ import { ScorecardQueryProvider } from '../../api';
2626
import { ScorecardHomepageCard } from '../ScorecardHomepageSection/ScorecardHomepageCard';
2727
import NotFoundState from '../Common/NotFoundState';
2828
import { useTranslation } from '../../hooks/useTranslation';
29+
import { resolveMetricTranslation } from '../../utils/translationUtils';
2930

3031
import { ScorecardPageHeader } from './ScorecardPageHeader';
3132
import { EntitiesTable } from './EntitiesTable/EntitiesTable';
@@ -44,9 +45,9 @@ export const ScorecardPage = () => {
4445

4546
const { t } = useTranslation();
4647

47-
const titleKey = `metric.${resolvedMetricId}.title`;
48-
const title = t(titleKey as any, {});
49-
const finalTitle = title === titleKey ? metricTitle : title;
48+
const finalTitle =
49+
resolveMetricTranslation(t, resolvedMetricId, 'title', metricTitle) ||
50+
metricTitle;
5051

5152
if (metricNotFound) {
5253
return (

0 commit comments

Comments
 (0)