Skip to content

Commit 4e40bf1

Browse files
fix(homepage): replace "View X entities" with "Browse the catalog" (#2702)
* fix(homepage): replace "View X entities" with "Browse the catalog" * fix e2e
1 parent b6600bb commit 4e40bf1

File tree

10 files changed

+14
-13
lines changed

10 files changed

+14
-13
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@red-hat-developer-hub/backstage-plugin-dynamic-home-page': patch
3+
---
4+
5+
Fix misleading entity count in EntitySection card link

workspaces/homepage/packages/app/e2e-tests/homepageCards.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ test.describe('Homepage Card Individual Tests', () => {
142142

143143
await testUtils.verifyLinkInCard(
144144
translations.entities.title,
145-
evaluateMessage(translations.entities.viewAll, '5'),
145+
translations.entities.browseTheCatalog,
146146
);
147147
});
148148

workspaces/homepage/plugins/dynamic-home-page/report-alpha.api.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ export const homepageTranslationRef: TranslationRef<
5454
readonly 'entities.fetchError': string;
5555
readonly 'entities.emptyDescription': string;
5656
readonly 'entities.register': string;
57-
readonly 'entities.viewAll': string;
57+
readonly 'entities.browseTheCatalog': string;
5858
}
5959
>;
6060

workspaces/homepage/plugins/dynamic-home-page/src/components/EntitySection/EntitySection.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ import {
4444
hasEntityIllustrationUserDismissed,
4545
} from '../../utils/utils';
4646
import { useTranslation } from '../../hooks/useTranslation';
47-
import { Trans } from '../Trans';
4847
import { containerGridItemSx } from '../../utils/GridItem';
4948
import {
5049
useContainerQuery,
@@ -321,10 +320,7 @@ export const EntitySection = () => {
321320
{entities?.length > 0 && (
322321
<Box sx={{ pt: 2 }}>
323322
<ViewMoreLink to="/catalog">
324-
<Trans
325-
message="entities.viewAll"
326-
params={{ count: data?.totalItems?.toString() || '' }}
327-
/>
323+
{t('entities.browseTheCatalog')}
328324
</ViewMoreLink>
329325
</Box>
330326
)}

workspaces/homepage/plugins/dynamic-home-page/src/translations/de.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ const homepageTranslationDe = createTranslationMessages({
7272
'entities.emptyDescription':
7373
'Sobald Software-Kataloge hinzugefügt werden, wird dieser Bereich relevante Inhalte anzeigen, die auf Ihre Erfahrung zugeschnitten sind.',
7474
'entities.register': 'Komponente registrieren',
75-
'entities.viewAll': 'Alle {{count}} Katalog-Entitäten anzeigen',
75+
'entities.browseTheCatalog': 'Katalog durchsuchen',
7676
},
7777
});
7878

workspaces/homepage/plugins/dynamic-home-page/src/translations/es.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ const homepageTranslationEs = createTranslationMessages({
6969
'entities.emptyDescription':
7070
'Una vez que se agreguen catálogos de software, este espacio mostrará contenido relevante adaptado a tu experiencia.',
7171
'entities.register': 'Registrar un componente',
72-
'entities.viewAll': 'Ver todas las {{count}} entidades del catálogo',
72+
'entities.browseTheCatalog': 'Explorar el catálogo',
7373
},
7474
});
7575

workspaces/homepage/plugins/dynamic-home-page/src/translations/fr.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ const homepageTranslationFr = createTranslationMessages({
7272
'entities.emptyDescription':
7373
'Une fois les catalogues de logiciels ajoutés, cet espace présentera du contenu pertinent adapté à votre expérience.',
7474
'entities.register': 'Enregistrer un composant',
75-
'entities.viewAll': 'Afficher toutes les {{count}} entités du catalogue',
75+
'entities.browseTheCatalog': 'Parcourir le catalogue',
7676
},
7777
});
7878

workspaces/homepage/plugins/dynamic-home-page/src/translations/it.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ const homepageTranslationIt = createTranslationMessages({
7070
'entities.emptyDescription':
7171
"Una volta aggiunti i cataloghi software, in quest'area verranno visualizzati contenuti pertinenti e personalizzati in base all'esperienza dell'utente.",
7272
'entities.register': 'Registrare un componente',
73-
'entities.viewAll': 'Visualizza tutte le {{count}} entità del catalogo',
73+
'entities.browseTheCatalog': 'Esplora il catalogo',
7474
},
7575
});
7676

workspaces/homepage/plugins/dynamic-home-page/src/translations/ja.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ const homepageTranslationJa = createTranslationMessages({
7171
'entities.emptyDescription':
7272
'ソフトウェアカタログが追加されると、利用状況に合わせてカスタマイズされた関連コンテンツがこのスペースに表示されます。',
7373
'entities.register': 'コンポーネントの登録',
74-
'entities.viewAll': '{{count}} 個のカタログエンティティーをすべて表示する',
74+
'entities.browseTheCatalog': 'カタログを閲覧',
7575
},
7676
});
7777

workspaces/homepage/plugins/dynamic-home-page/src/translations/ref.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ export const homepageMessages = {
8989
emptyDescription:
9090
'Once software catalogs are added, this space will showcase relevant content tailored to your experience.',
9191
register: 'Register a component',
92-
viewAll: 'View all {{count}} catalog entities',
92+
browseTheCatalog: 'Browse the catalog',
9393
},
9494
};
9595

0 commit comments

Comments
 (0)