fix(orchestrator): fix Tests (#587)

* fixTests

Signed-off-by: Lior Soffer <liorsoffer1@gmail.com>

* openapi generate files

Signed-off-by: Lior Soffer <liorsoffer1@gmail.com>

* run prettier

Signed-off-by: Lior Soffer <liorsoffer1@gmail.com>

* add changeset

Signed-off-by: Lior Soffer <liorsoffer1@gmail.com>

* openapi generate files

Signed-off-by: Lior Soffer <liorsoffer1@gmail.com>

* yarn build:api-reports

Signed-off-by: Lior Soffer <liorsoffer1@gmail.com>

---------

Signed-off-by: Lior Soffer <liorsoffer1@gmail.com>

Author: LiorSoffer

workspaces/orchestrator/.changeset/spicy-pens-drum.md

@@ -0,0 +1,6 @@
+---
+'@red-hat-developer-hub/backstage-plugin-orchestrator-backend': patch
+'@red-hat-developer-hub/backstage-plugin-orchestrator-common': patch
+---
+
+fix tests

workspaces/orchestrator/plugins/orchestrator-backend/src/service/OrchestratorService.ts

@@ -15,14 +15,14 @@
  */
 
 import {
+  AuthToken,
   Filter,
   ProcessInstance,
   ProcessInstanceVariables,
   WorkflowDefinition,
   WorkflowExecutionResponse,
   WorkflowInfo,
   WorkflowOverview,
-  AuthToken,
 } from '@red-hat-developer-hub/backstage-plugin-orchestrator-common';
 
 import { Pagination } from '../types/pagination';

workspaces/orchestrator/plugins/orchestrator-backend/src/service/SonataFlowService.test.ts

@@ -1,5 +1,5 @@
 /*
- * Copyright 2024 The Backstage Authors
+ * Copyright Red Hat, Inc.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 import { LoggerService } from '@backstage/backend-plugin-api';
 
 import { WorkflowExecutionResponse } from '@red-hat-developer-hub/backstage-plugin-orchestrator-common';
@@ -131,7 +132,7 @@ describe('SonataFlowService', () => {
       return {
         method: 'POST',
         body: JSON.stringify(inputData),
-        headers: { 'content-type': 'application/json' },
+        headers: { 'Content-Type': 'application/json' },
       };
     };
 
@@ -185,7 +186,7 @@ describe('SonataFlowService', () => {
         'Execute workflow successful. Response: {"id":"workflow-123","status":"completed"}',
       );
       // Verify that all other logger methods were not called
-      expect(loggerMock.debug).toHaveBeenCalledTimes(1);
+      expect(loggerMock.debug).toHaveBeenCalledTimes(2);
       expect(loggerMock.info).not.toHaveBeenCalled();
       expect(loggerMock.error).not.toHaveBeenCalled();
       expect(loggerMock.warn).not.toHaveBeenCalled();

workspaces/orchestrator/plugins/orchestrator-backend/src/service/SonataFlowService.ts

@@ -17,6 +17,7 @@
 import { LoggerService } from '@backstage/backend-plugin-api';
 
 import {
+  AuthToken,
   extractWorkflowFormat,
   Filter,
   fromWorkflowSource,
@@ -27,7 +28,6 @@ import {
   WorkflowExecutionResponse,
   WorkflowInfo,
   WorkflowOverview,
-  AuthToken,
 } from '@red-hat-developer-hub/backstage-plugin-orchestrator-common';
 
 import { Pagination } from '../types/pagination';
@@ -111,19 +111,19 @@ export class SonataFlowService {
       'Content-Type': 'application/json',
     };
 
-  	// Add X-Authentication headers from authTokens
-  	if (args.authTokens && Array.isArray(args.authTokens)) {
-    	args.authTokens.forEach((tokenObj) => {
-      	if (tokenObj.provider && tokenObj.token) {
-        const headerKey = `X-Authentication-${tokenObj.provider}`;
-        headers[headerKey] = String(tokenObj.token); // Ensure token is a string
-      	}
+    // Add X-Authentication headers from authTokens
+    if (args.authTokens && Array.isArray(args.authTokens)) {
+      args.authTokens.forEach(tokenObj => {
+        if (tokenObj.provider && tokenObj.token) {
+          const headerKey = `X-Authentication-${tokenObj.provider}`;
+          headers[headerKey] = String(tokenObj.token); // Ensure token is a string
+        }
       });
-  	}
-  	
-  	else {
-    	this.logger.debug('No authTokens provided or authTokens is not an array.');
-  	}
+    } else {
+      this.logger.debug(
+        'No authTokens provided or authTokens is not an array.',
+      );
+    }
 
     const response = await fetch(urlToFetch, {
       method: 'POST',

workspaces/orchestrator/plugins/orchestrator-backend/src/service/api/v2.ts

@@ -177,8 +177,7 @@ export class V2 {
       definitionId: workflowId,
       inputData:
         executeWorkflowRequestDTO.inputData as ProcessInstanceVariables,
-      authTokens:
-        executeWorkflowRequestDTO.authTokens as Array<AuthToken>,
+      authTokens: executeWorkflowRequestDTO.authTokens as Array<AuthToken>,
       serviceUrl: definition.serviceUrl,
       businessKey,
       cacheHandler: 'throw',

workspaces/orchestrator/plugins/orchestrator-common/report.api.md

@@ -1 +1 @@
-51adf79657d741a8cf1777c6336f9b8aea276fd5
+9b9af1749d23e78871a55d78b89cb0e2462d6a3b

workspaces/orchestrator/plugins/orchestrator-common/src/generated/.METADATA.sha1

@@ -42,6 +42,25 @@ export interface AssessedProcessInstanceDTO {
      */
     'assessedBy'?: ProcessInstanceDTO;
 }
+/**
+ * 
+ * @export
+ * @interface AuthToken
+ */
+export interface AuthToken {
+    /**
+     * The auth token provider name
+     * @type {string}
+     * @memberof AuthToken
+     */
+    'provider': string;
+    /**
+     * The auth token itself retrieved from the above specified provider name
+     * @type {string}
+     * @memberof AuthToken
+     */
+    'token': string;
+}
 /**
  * The ErrorResponse object represents a common structure for handling errors in API responses. It includes essential information about the error, such as the error message and additional optional details.
  * @export
@@ -73,6 +92,12 @@ export interface ExecuteWorkflowRequestDTO {
      * @memberof ExecuteWorkflowRequestDTO
      */
     'inputData'?: object;
+    /**
+     * 
+     * @type {Array<AuthToken>}
+     * @memberof ExecuteWorkflowRequestDTO
+     */
+    'authTokens'?: Array<AuthToken>;
 }
 /**
  * 

workspaces/orchestrator/plugins/orchestrator-common/src/generated/api/definition.ts

@@ -587,6 +587,25 @@ spec:
             inputData:
               type: object
               additionalProperties: true
+            authTokens:
+              type: array
+              items:
+                $ref: '#/components/schemas/AuthToken'
+              minItems: 1
+              additionalProperties: true
+        AuthToken:
+          type: object
+          properties:
+            provider:
+              description: The auth token provider name
+              type: string
+            token:
+              description: The auth token itself retrieved from the above specified provider name
+              type: string
+          required:
+            - provider
+            - token
+          additionalProperties: false
         ExecuteWorkflowResponseDTO:
           type: object
           properties: