fix(orchestrator):remove workflow input editor (#943)

Signed-off-by: Lior Soffer <liorsoffer1@gmail.com>

Author: LiorSoffer

workspaces/orchestrator/.changeset/rotten-apricots-obey.md

@@ -0,0 +1,5 @@
+---
+'@red-hat-developer-hub/backstage-plugin-orchestrator': patch
+---
+
+"fix(orchestrator):remove workflow input editor"

workspaces/orchestrator/plugins/orchestrator/package.json

@@ -65,7 +65,6 @@
     "@kie-tools-core/editor": "^10.0.0",
     "@kie-tools/serverless-workflow-standalone-editor": "^10.0.0",
     "@material-ui/core": "^4.12.4",
-    "@monaco-editor/react": "^4.6.0",
     "@red-hat-developer-hub/backstage-plugin-orchestrator-common": "workspace:^",
     "@red-hat-developer-hub/backstage-plugin-orchestrator-form-api": "workspace:^",
     "@red-hat-developer-hub/backstage-plugin-orchestrator-form-react": "workspace:^",

workspaces/orchestrator/plugins/orchestrator/src/components/ExecuteWorkflowPage/ExecuteWorkflowPage.tsx

@@ -48,7 +48,7 @@ import {
 } from '../../routes';
 import { getErrorObject } from '../../utils/ErrorUtils';
 import { BaseOrchestratorPage } from '../BaseOrchestratorPage';
-import JsonTextAreaForm from './JsonTextAreaForm';
+import MissingSchemaNotice from './MissingSchemaNotice';
 import { getSchemaUpdater } from './schemaUpdater';
 
 export const ExecuteWorkflowPage = () => {
@@ -75,9 +75,11 @@ export const ExecuteWorkflowPage = () => {
   }, [orchestratorApi, workflowId]);
 
   const [schema, setSchema] = useState<JSONSchema7 | undefined>();
+
   useEffect(() => {
     setSchema(value?.inputSchema);
   }, [value]);
+
   const updateSchema = useMemo(
     () => getSchemaUpdater(schema, setSchema),
     [schema],
@@ -116,7 +118,11 @@ export const ExecuteWorkflowPage = () => {
   const error = responseError || workflowNameError;
   let pageContent;
 
-  if (loading || workflowNameLoading) {
+  if (
+    loading ||
+    workflowNameLoading ||
+    (!loading && value?.inputSchema && !schema) // wait for useEffect to setSchema
+  ) {
     pageContent = <Progress />;
   } else if (error) {
     pageContent = <ResponseErrorPanel error={error} />;
@@ -140,7 +146,7 @@ export const ExecuteWorkflowPage = () => {
                 initialFormData={initialFormData}
               />
             ) : (
-              <JsonTextAreaForm
+              <MissingSchemaNotice
                 handleExecute={handleExecute}
                 isExecuting={isExecuting}
               />

workspaces/orchestrator/plugins/orchestrator/src/components/ExecuteWorkflowPage/JsonTextAreaForm.tsx

@@ -0,0 +1,58 @@
+/*
+ * Copyright Red Hat, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import React from 'react';
+
+import type { JsonObject } from '@backstage/types';
+
+import Alert from '@mui/material/Alert';
+import AlertTitle from '@mui/material/AlertTitle';
+import Grid from '@mui/material/Grid';
+
+import { SubmitButton } from '@red-hat-developer-hub/backstage-plugin-orchestrator-form-react';
+
+const MissingSchemaNotice = ({
+  isExecuting,
+  handleExecute,
+}: {
+  isExecuting: boolean;
+  handleExecute: (parameters: JsonObject) => Promise<void>;
+}) => {
+  return (
+    <Grid container spacing={2}>
+      <Grid item xs={12}>
+        <Alert severity="info" style={{ width: '100%' }}>
+          <AlertTitle>Missing JSON Schema for Input Form</AlertTitle>
+          This workflow will run without any input values.
+          <br />
+          To enable a form-based input, please provide a valid JSON schema in
+          the <code>dataInputSchema</code> property of your workflow definition
+          file.
+        </Alert>
+      </Grid>
+      <Grid item xs={12}>
+        <SubmitButton
+          submitting={isExecuting}
+          handleClick={() => handleExecute({})}
+        >
+          Run
+        </SubmitButton>
+      </Grid>
+    </Grid>
+  );
+};
+
+export default MissingSchemaNotice;

workspaces/orchestrator/plugins/orchestrator/src/components/ExecuteWorkflowPage/MissingSchemaNotice.tsx

@@ -9326,30 +9326,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@monaco-editor/loader@npm:^1.4.0":
-  version: 1.4.0
-  resolution: "@monaco-editor/loader@npm:1.4.0"
-  dependencies:
-    state-local: ^1.0.6
-  peerDependencies:
-    monaco-editor: ">= 0.21.0 < 1"
-  checksum: 374ec0ea872ee15b33310e105a43217148161480d3955c5cece87d0f801754cd2c45a3f6c539a75da18a066c1615756fb87eaf1003f1df6a64a0cbce5d2c3749
-  languageName: node
-  linkType: hard
-
-"@monaco-editor/react@npm:^4.6.0":
-  version: 4.6.0
-  resolution: "@monaco-editor/react@npm:4.6.0"
-  dependencies:
-    "@monaco-editor/loader": ^1.4.0
-  peerDependencies:
-    monaco-editor: ">= 0.25.0 < 1"
-    react: ^16.8.0 || ^17.0.0 || ^18.0.0
-    react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0
-  checksum: 9d44e76c5baad6db5f84c90a5540fbd3c9af691b97d76cf2a99b3c8273004d0efe44c2572d80e9d975c9af10022c21e4a66923924950a5201e82017c8b20428c
-  languageName: node
-  linkType: hard
-
 "@motionone/animation@npm:^10.12.0":
   version: 10.18.0
   resolution: "@motionone/animation@npm:10.18.0"
@@ -11586,7 +11562,6 @@ __metadata:
     "@kie-tools-core/editor": ^10.0.0
     "@kie-tools/serverless-workflow-standalone-editor": ^10.0.0
     "@material-ui/core": ^4.12.4
-    "@monaco-editor/react": ^4.6.0
     "@mui/icons-material": ^5.17.1
     "@mui/material": ^5.17.1
     "@red-hat-developer-hub/backstage-plugin-orchestrator-common": "workspace:^"
@@ -34029,13 +34004,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"state-local@npm:^1.0.6":
-  version: 1.0.7
-  resolution: "state-local@npm:1.0.7"
-  checksum: d1afcf1429e7e6eb08685b3a94be8797db847369316d4776fd51f3962b15b984dacc7f8e401ad20968e5798c9565b4b377afedf4e4c4d60fe7495e1cbe14a251
-  languageName: node
-  linkType: hard
-
 "static-eval@npm:2.0.2":
   version: 2.0.2
   resolution: "static-eval@npm:2.0.2"