fix(sandbox): handle signup case where defaultNamespace is not yet defined (#975)

* handle defaultNamespace being undefined

Author: mfrancisc

workspaces/sandbox/README.md

@@ -34,3 +34,9 @@ Please, note that every time you want to re deploy, you need to run:
 
 NOTE: the app uses prod RH SSO as auth provider and sandbox stage backend by default
 ( those can be configured in `deploy/app-config.yaml` )
+
+Known issues:
+
+- sometimes the local node build fails and you'll have to run `make stop-rhdh-local` and `make start-rhdh-local` again.
+  This is what you will see when the build fails:
+  ![Known Issues](./images/known_build_issue.png)

workspaces/sandbox/images/know_build_issue.png

@@ -13,7 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import { OAuthApi } from '@backstage/core-plugin-api/index';
+import { OAuthApi } from '@backstage/core-plugin-api';
 
 export type SecureFetchClientOptions = {
   oauthApi: OAuthApi;

workspaces/sandbox/plugins/sandbox/src/api/SecureFetchClient.tsx

@@ -153,7 +153,6 @@ export const VerificationCodeStep: React.FC<VerificationCodeProps> = ({
 
       // Poll until user is found or max attempts reached
       let urlToOpen = '';
-      let userFound = false;
       let userReady = false;
       for (let i = 0; i < maxAttempts; i++) {
         setRefetchingUserData(true);
@@ -162,29 +161,34 @@ export const VerificationCodeStep: React.FC<VerificationCodeProps> = ({
         // Fetch the latest user data and check if user is found
         const userData = await refetchUserData();
         if (userData) {
-          userFound = true;
           const userStatus = signupDataToStatus(userData);
           userReady = userStatus === 'ready';
+
+          const verificationRequired = userStatus === 'verify';
+          // if verification is required we can stop fetching the data
+          if (verificationRequired) {
+            break;
+          }
+
           // if user is ready we can stop fetching the data
           if (userReady) {
+            // if namespace is not defined we can continue fetching the data
+            if (!userData?.defaultUserNamespace) {
+              // eslint-disable-next-line
+              console.error(
+                'user is ready but default namespace is not defined yet...',
+              );
+              continue;
+            }
             const productURLs = productsURLMapping(userData);
             // find the link to open if any
             urlToOpen = productURLs.find(pu => pu.id === id)?.url || '';
             // User has signed up and the trial is ready and user selects the AAP Trial
-            if (userFound && userReady) {
-              if (pdt === Product.AAP) {
-                if (!userData?.defaultUserNamespace) {
-                  // eslint-disable-next-line
-                  console.error(
-                    'unable to provision AAP. user namespace is not defined.',
-                  );
-                  return;
-                }
-                handleAAPInstance(userData.defaultUserNamespace);
-                setAnsibleCredsModalOpen(true);
-              } else if (urlToOpen) {
-                window.open(urlToOpen, '_blank');
-              }
+            if (pdt === Product.AAP) {
+              handleAAPInstance(userData.defaultUserNamespace as string);
+              setAnsibleCredsModalOpen(true);
+            } else if (urlToOpen) {
+              window.open(urlToOpen, '_blank');
             }
             break;
           }
@@ -268,6 +272,7 @@ export const VerificationCodeStep: React.FC<VerificationCodeProps> = ({
 
         <Typography
           data-testid="resend-code-link"
+          component="div"
           variant="body2"
           color="primary"
           sx={{