feat(app-defaults): add app-auth and app-integration#2693
feat(app-defaults): add app-auth and app-integration#2693gashcrumb wants to merge 1 commit intoredhat-developer:mainfrom
Conversation
gashcrumb
requested review from
a team,
christoph-jerolimov and
rohitkrai03
as code owners
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
Review Summary by QodoAdd app-auth and app-integrations plugins for new frontend system
WalkthroughsDescription• Add app-auth plugin with multi-provider sign-in page and OAuth2 APIs • Add app-integrations plugin for default SCM integrations and auth wiring • Suppress noisy CSS parse errors in jsdom test environment • Update ESLint config to handle .cjs files and add lint-staged configuration • Integrate new plugins into sample app with updated dependencies Diagramflowchart LR
A["app-auth plugin"] -->|"provides sign-in page"| B["Sample App"]
C["app-integrations plugin"] -->|"provides SCM auth"| B
D["Jest environment"] -->|"suppress CSS errors"| E["Test setup"]
F["ESLint config"] -->|"handle .cjs files"| G["Lint pipeline"]
B -->|"uses"| H["New Frontend System"]
File Changes1. workspaces/app-defaults/plugins/app-auth/package.json
|
Code Review by Qodo
1. Jest env path invalid
|
gashcrumb
force-pushed
the
RHIDP-12359
branch
2 times, most recently
from
00f04dd to
6b21b19
Compare
![rhdh-qodo-merge[bot]](https://avatars.githubusercontent.com/in/1961108?s=60&v=4){kind=small}
This change adds an 'app-auth' plugin which provides the sign-in page and related authentiction module API factories to an app using the new frontend system. This change also adds a second 'app-integration' plugin which provides a default ScmAuth configuration. In both cases these plugins bring code migrated from the old frontend system setup in the RHDH repository. This change also adds a change to cleanup some noisy non-outcome altering output on the console when running the tests, along with some related updates to the eslint config so that the lint run by the pre-commit hook still works. This change also contains some updates to the app-defaults workspace README. Based on review feedback, this change also includes an improved error message should the app be misconfigured such that the sign-in page would not render properly Assisted-By: Cursor Desktop
|
|
not sure the best version to use in the package.json files for these, maybe I should have just kept them at 0.0.1. |
1 participant
This change adds an 'app-auth' plugin which provides the sign-in page and related authentiction module API factories to an app using the new frontend system. This change also adds a second 'app-integration' plugin which provides a default ScmAuth configuration. In both cases these plugins bring code migrated from the old frontend system setup in the RHDH repository. This change also adds a change to cleanup some noisy non-outcome altering output on the console when running the tests, along with some related updates to the eslint config so that the lint run by the pre-commit hook still works. Based on review feedback, this change also includes an improved error message should the app be misconfigured such that the sign-in page would not render properly
Fixes RHIDP-12359
Assisted-By: Cursor Desktop
Hey, I just made a Pull Request!
✔️ Checklist
Exporting these modules as dynamic plugins and starting RHDH backend's
start:nextscript along with the relevant configuration that enables these modules provides a sign-in page that uses the correct authentication method as well as the ability to sign in using a secondary auth provider to access source control, for example:When starting the workspace in development mode using
yarn startthe guest authentication method can be used to sign-in.