[WIP] fix(lightspeed): package version fixes#2707
Open
debsmita1 wants to merge 1 commit intoredhat-developer:mainfrom
Open
[WIP] fix(lightspeed): package version fixes#2707debsmita1 wants to merge 1 commit intoredhat-developer:mainfrom
debsmita1 wants to merge 1 commit intoredhat-developer:mainfrom
Conversation
debsmita1
requested review from
a team,
ciiay,
karthikjeeyar,
logonoff,
rohitkrai03 and
yangcao77
as code owners
Review Summary by QodoFix package versions and remove unused dependencies
WalkthroughsDescription• Remove unused dependencies from lightspeed plugin • Update @mui/icons-material version to 6.1.8 in theme plugin • Clean up devDependencies in lightspeed package • Add changesets documenting package updates Diagramflowchart LR
A["Lightspeed Plugin"] -->|"Remove @material-ui/lab, react-markdown"| B["Cleaned Dependencies"]
A -->|"Remove @backstage/core-app-api, @emotion/is-prop-valid, msw, prettier"| B
C["Theme Plugin"] -->|"Update @mui/icons-material to 6.1.8"| D["Updated Version"]
B --> E["Changesets Created"]
D --> E
File Changes1. workspaces/lightspeed/.changeset/angry-shirts-swim.md
|
Code Review by Qodo
1. Icons peer version conflict
|
Changed Packages
|
|
![rhdh-qodo-merge[bot]](https://avatars.githubusercontent.com/in/1961108?s=60&v=4){kind=small}
Comment on lines
+53
to
54
| "@mui/icons-material": "^6.1.8", | ||
| "@mui/material": "^5.0.0", |
There was a problem hiding this comment.
1. Icons peer version conflict 🐞 Bug ☼ Reliability
@red-hat-developer-hub/backstage-plugin-theme now requires @mui/icons-material ^6.1.8 as a peerDependency, but in-repo consumers still require v5, making the peer requirement unsatisfied and likely breaking installs/builds for those workspaces. For example, bulk-import app pins @mui/icons-material 5.18.0 while depending on the theme plugin, and orchestrator’s peerDependency still requires @mui/icons-material ^5.17.1.
Agent Prompt
### Issue description
`@red-hat-developer-hub/backstage-plugin-theme` now declares a peer dependency on `@mui/icons-material` `^6.1.8`, but existing in-repo consumers still require `@mui/icons-material` v5. This creates incompatible peer constraints across the monorepo and can break yarn installs or workspace builds.
### Issue Context
- The theme plugin peer range is now v6.
- Bulk-import app pins `@mui/icons-material` to v5 while depending on the theme plugin.
- Orchestrator plugin still has a v5 peer range for `@mui/icons-material`.
### Fix Focus Areas
Choose one direction and apply consistently:
- **Option A (maintain v5 compatibility):** widen the theme plugin peer range to accept both v5 and v6 (and consider whether the implementation truly requires v6).
- **Option B (upgrade ecosystem to v6):** update other packages’ peer ranges (e.g., orchestrator) and update consuming apps to use v6.
- workspaces/theme/plugins/theme/package.json[49-55]
- workspaces/orchestrator/plugins/orchestrator/package.json[122-125]
- workspaces/bulk-import/packages/app/package.json[53-63]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
+1
to
+3
| --- | ||
| '@red-hat-developer-hub/backstage-plugin-theme': patch | ||
| --- |
There was a problem hiding this comment.
2. Breaking change marked patch 🐞 Bug ⚙ Maintainability
The changeset declares a patch release for the theme plugin even though it raises the required major peer dependency for @mui/icons-material, which is a breaking requirement change for consumers. This can cause consumers on semver ranges to auto-upgrade into an incompatible peer-dependency set.
Agent Prompt
### Issue description
The theme plugin changeset is marked as `patch`, but the PR changes the theme plugin’s peer dependency requirement for `@mui/icons-material` to a new major version. This is a breaking compatibility change and should not be released as a patch.
### Issue Context
Consumers using semver ranges (e.g. `^0.13.0`) can pick up a patch release automatically; if that patch now requires a new major peer dependency, installs/builds can break unexpectedly.
### Fix Focus Areas
- Update the changeset release type to at least `minor` (or `major`, depending on your repo’s semver policy for peer-dependency major bumps).
- Ensure other dependent packages/workspaces are updated in lockstep if v6 is required.
- workspaces/theme/.changeset/late-panthers-drive.md[1-5]
- workspaces/theme/plugins/theme/package.json[49-56]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Resolves: https://redhat.atlassian.net/browse/RHDHBUGS-2902
✔️ Checklist