Skip to content

fix(lightspeed-mcp): refactored mcp config modal #3698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ciiay wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(lightspeed-mcp): refactored mcp config modal #3698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9925df6
fix(lightspeed-mcp): refactored mcp config modal
ciiay Jul 7, 2026
7c3c9ba
resolved tsc issue
ciiay Jul 7, 2026
a0fe739
updated report api
ciiay Jul 7, 2026
b8b000b
fixed failed ci tests
ciiay Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions workspaces/lightspeed/.changeset/mcp-configure-modal-enhancements.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@red-hat-developer-hub/backstage-plugin-lightspeed': minor
---

Enhance the MCP server configure modal with PatternFly layout, server status and tools list, aligned enabled toggle behavior, personal token save/remove flows (including disconnecting state and warnings), auto-enable on successful token validation, and unit tests.
6 changes: 3 additions & 3 deletions workspaces/lightspeed/e2e-tests/pages/LightspeedPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,9 +247,9 @@ export function mcpConfigureModalMessage(
page: Page,
exactText: string,
): Locator {
return mcpCredentialConfigureModal(page).getByText(exactText, {
exact: true,
});
// PatternFly HelperTextItem appends ": error status;" for error variants; validation
// errors may also appear in the tools section. Substring match + first() avoids both.
return mcpCredentialConfigureModal(page).getByText(exactText).first();
}

/**
Expand Down
31 changes: 16 additions & 15 deletions workspaces/lightspeed/packages/app/knip-report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,24 @@
# Knip report

## Unused dependencies (7)
## Unused dependencies (8)

| Name | Location | Severity |
| :------------------------------ | :---------------- | :------- |
| @backstage/plugin-user-settings | package.json:33:6 | error |
| @backstage/integration-react | package.json:28:6 | error |
| @backstage/plugin-scaffolder | package.json:31:6 | error |
| @backstage/core-compat-api | package.json:23:6 | error |
| @backstage/plugin-catalog | package.json:30:6 | error |
| @backstage/plugin-search | package.json:32:6 | error |
| react-router | package.json:42:6 | error |
| Name | Location | Severity |
| :------------------------------- | :---------------- | :------- |
| @backstage-community/plugin-rbac | package.json:22:6 | error |
| @backstage/plugin-user-settings | package.json:35:6 | error |
| @backstage/integration-react | package.json:29:6 | error |
| @backstage/plugin-scaffolder | package.json:33:6 | error |
| @backstage/core-compat-api | package.json:24:6 | error |
| @backstage/plugin-catalog | package.json:32:6 | error |
| @backstage/plugin-search | package.json:34:6 | error |
| react-router | package.json:44:6 | error |

## Unused devDependencies (5)

| Name | Location | Severity |
| :----------------------------- | :---------------- | :------- |
| @backstage/frontend-test-utils | package.json:46:6 | error |
| @testing-library/user-event | package.json:51:6 | error |
| @testing-library/dom | package.json:48:6 | error |
| @playwright/test | package.json:47:6 | error |
| cross-env | package.json:53:6 | error |
| @backstage/frontend-test-utils | package.json:48:6 | error |
| @testing-library/user-event | package.json:53:6 | error |
| @testing-library/dom | package.json:50:6 | error |
| @playwright/test | package.json:49:6 | error |
| cross-env | package.json:55:6 | error |
3 changes: 1 addition & 2 deletions workspaces/lightspeed/packages/backend/knip-report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
# Knip report

## Unused dependencies (10)
## Unused dependencies (9)

| Name | Location | Severity |
| :----------------------------------------------------------- | :---------------- | :------- |
| @backstage/plugin-permission-backend-module-allow-all-policy | package.json:37:6 | error |
| @backstage/plugin-search-backend-node | package.json:46:6 | error |
| @backstage/plugin-permission-backend | package.json:36:6 | error |
| @backstage/plugin-permission-common | package.json:38:6 | error |
| @backstage/plugin-permission-node | package.json:39:6 | error |
| @backstage/plugin-auth-node | package.json:31:6 | error |
Expand Down
15 changes: 0 additions & 15 deletions workspaces/lightspeed/plugins/lightspeed/knip-report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1 @@
# Knip report

## Unused dependencies (2)

| Name | Location | Severity |
| :--------------- | :---------------- | :------- |
| @material-ui/lab | package.json:63:6 | error |
| react-markdown | package.json:78:6 | error |

## Unused devDependencies (3)

| Name | Location | Severity |
| :---------------------- | :---------------- | :------- |
| @backstage/core-app-api | package.json:87:6 | error |
| @emotion/is-prop-valid | package.json:90:6 | error |
| msw | package.json:97:6 | error |
5 changes: 0 additions & 5 deletions workspaces/lightspeed/plugins/lightspeed/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@
"@backstage/plugin-permission-react": "^0.4.41",
"@backstage/theme": "^0.7.2",
"@material-ui/core": "^4.9.13",
"@material-ui/lab": "^4.0.0-alpha.61",
"@monaco-editor/react": "^4.7.0",
"@mui/icons-material": "^6.1.8",
"@mui/material": "^5.12.2",
Expand All @@ -87,7 +86,6 @@
"@tanstack/react-query": "^5.59.15",
"monaco-editor": "^0.55.0",
"react-dropzone": "^14.4.0",
"react-markdown": "^9.0.1",
"react-use": "^17.2.4"
},
"peerDependencies": {
Expand All @@ -96,17 +94,14 @@
},
"devDependencies": {
"@backstage/cli": "^0.36.0",
"@backstage/core-app-api": "^1.19.6",
"@backstage/dev-utils": "^1.1.21",
"@backstage/test-utils": "^1.7.16",
"@emotion/is-prop-valid": "^1.3.1",
"@ianvs/prettier-plugin-sort-imports": "^4.4.0",
"@spotify/prettier-config": "^15.0.0",
"@testing-library/dom": "^10.0.0",
"@testing-library/jest-dom": "^6.0.0",
"@testing-library/react": "^15.0.0",
"@testing-library/user-event": "14.6.1",
"msw": "1.3.5",
"prettier": "3.8.4",
"react": "16.13.1 || ^17.0.0 || ^18.0.0",
"react-dom": "16.13.1 || ^17.0.0 || ^18.0.0",
Expand Down
9 changes: 9 additions & 0 deletions workspaces/lightspeed/plugins/lightspeed/report-alpha.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,15 @@ export const lightspeedTranslationRef: TranslationRef<
readonly 'mcp.settings.configureServerTitle': string;
readonly 'mcp.settings.closeConfigureModalAriaLabel': string;
readonly 'mcp.settings.modalDescription': string;
readonly 'mcp.settings.authenticationToken': string;
readonly 'mcp.settings.modal.toolsHeading': string;
readonly 'mcp.settings.modal.loadingTools': string;
readonly 'mcp.settings.modal.loadingStatus': string;
readonly 'mcp.settings.modal.tokenRemovedWarning': string;
readonly 'mcp.settings.modal.noToolsAvailable': string;
readonly 'mcp.settings.modal.toolsLoadFailed': string;
readonly 'mcp.settings.modal.enabledDescription': string;
readonly 'mcp.settings.modal.enabledDescriptionOff': string;
readonly 'mcp.settings.savedToken': string;
readonly 'mcp.settings.personalAccessToken': string;
readonly 'mcp.settings.usingAdminCredential': string;
Expand Down
Loading
Loading