Skip to content

Commit 5c76ac8

Browse files
[release-1.9] chore: bump theme plugin (#4683)
* fix: sidebar layout my-group title (#4601) * locally commiting .gitignore * fix(sidebar): myGroup title visibility Signed-off-by: rohitratannagar <rohitratannagar2003@gmail.com> --------- Signed-off-by: rohitratannagar <rohitratannagar2003@gmail.com> * chore: bump theme plugin and fix the submenu top offset --------- Signed-off-by: rohitratannagar <rohitratannagar2003@gmail.com> Co-authored-by: rohitratannagar <123488044+rohitratannagar@users.noreply.github.com>
1 parent 50339ca commit 5c76ac8

3 files changed

Lines changed: 13 additions & 6 deletions

File tree

packages/app/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
"@mui/icons-material": "5.18.0",
4747
"@mui/material": "5.18.0",
4848
"@mui/styled-engine": "5.18.0",
49-
"@red-hat-developer-hub/backstage-plugin-theme": "0.12.0",
49+
"@red-hat-developer-hub/backstage-plugin-theme": "0.12.3",
5050
"@red-hat-developer-hub/backstage-plugin-translations": "0.2.1",
5151
"@red-hat-developer-hub/plugin-utils": "1.0.0",
5252
"@scalprum/core": "0.9.0",

packages/app/src/components/Root/Root.tsx

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,13 @@ const SidebarLayout = styled(Box, {
176176
top: `max(0px, ${aboveSidebarHeaderHeight ?? 0}px)`,
177177
width: isSidebarOpen ? '250px !important' : 'auto',
178178
},
179+
180+
// SidebarSubmenu flyout uses position:fixed with top:0, which causes it to
181+
// render behind the global header. Offset it by the header height.
182+
'& > div > nav > div > div > div > div > div > div > div': {
183+
top: `${aboveSidebarHeaderHeight ?? 0}px`,
184+
bottom: 0,
185+
},
179186
}),
180187
);
181188

yarn.lock

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13514,9 +13514,9 @@ __metadata:
1351413514
languageName: node
1351513515
linkType: hard
1351613516

13517-
"@red-hat-developer-hub/backstage-plugin-theme@npm:0.12.0":
13518-
version: 0.12.0
13519-
resolution: "@red-hat-developer-hub/backstage-plugin-theme@npm:0.12.0"
13517+
"@red-hat-developer-hub/backstage-plugin-theme@npm:0.12.3":
13518+
version: 0.12.3
13519+
resolution: "@red-hat-developer-hub/backstage-plugin-theme@npm:0.12.3"
1352013520
dependencies:
1352113521
"@mui/icons-material": ^5.17.1
1352213522
peerDependencies:
@@ -13526,7 +13526,7 @@ __metadata:
1352613526
"@mui/icons-material": ^5.17.1
1352713527
"@mui/material": ^5.0.0
1352813528
react: ^16.13.1 || ^17.0.0 || ^18.0.0
13529-
checksum: c8489fa11585c8e57d47c5e3972df90dab01a7de70629ca8c944026a914c98d944837bcfa8ac205c45bbd92f075207dfc4ed560463a933d234649afb8a612fd1
13529+
checksum: a26ffe04bfd29776773e0acecf867784bc1c5817e4a14725013d44ce989ce961a827aa2fca6d8c1a4d05a9ab42152db8e303ae56e9b7f941fc926353a6d0ef27
1353013530
languageName: node
1353113531
linkType: hard
1353213532

@@ -18304,7 +18304,7 @@ __metadata:
1830418304
"@mui/icons-material": 5.18.0
1830518305
"@mui/material": 5.18.0
1830618306
"@mui/styled-engine": 5.18.0
18307-
"@red-hat-developer-hub/backstage-plugin-theme": 0.12.0
18307+
"@red-hat-developer-hub/backstage-plugin-theme": 0.12.3
1830818308
"@red-hat-developer-hub/backstage-plugin-translations": 0.2.1
1830918309
"@red-hat-developer-hub/plugin-utils": 1.0.0
1831018310
"@scalprum/core": 0.9.0

0 commit comments

Comments
 (0)