Commit a83006b
committed
refactor(ci): add defensive checks and improved logging to parallel deployments
Address code review findings from PR #4679:
1. **Namespace validation**: Add defensive check to ensure NAME_SPACE and
NAME_SPACE_RBAC are different and non-empty before starting parallel
deployments. Prevents subtle race conditions if misconfigured.
2. **Improved logging**:
- Log both namespace names at the start for debugging
- Add synchronization point logs ("Waiting for parallel deployments..."
and "Parallel deployments finished") to make log flow clearer when
output from both background jobs is interleaved
3. **Documentation**: Add "Requires" section to function header documenting
the namespace disjointness requirement
These changes improve debuggability and fail-fast behavior without changing
the core parallelization logic.1 parent ea19fa3 commit a83006b
1 file changed
Lines changed: 12 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
668 | 668 | | |
669 | 669 | | |
670 | 670 | | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
671 | 674 | | |
672 | 675 | | |
673 | 676 | | |
674 | 677 | | |
675 | 678 | | |
676 | 679 | | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
677 | 686 | | |
| 687 | + | |
678 | 688 | | |
679 | 689 | | |
680 | 690 | | |
| |||
684 | 694 | | |
685 | 695 | | |
686 | 696 | | |
| 697 | + | |
687 | 698 | | |
688 | 699 | | |
689 | 700 | | |
| 701 | + | |
690 | 702 | | |
691 | 703 | | |
692 | 704 | | |
| |||
0 commit comments