Commit f631cd9
committed
refactor(ci): add defensive checks and improved logging to parallel deployments
Address code review findings from PR #4679:
1. **Namespace validation**: Add defensive check to ensure NAME_SPACE and
NAME_SPACE_RBAC are different and non-empty before starting parallel
deployments. Prevents subtle race conditions if misconfigured.
2. **Improved logging**:
- Log both namespace names at the start for debugging
- Add synchronization point logs ("Waiting for parallel deployments..."
and "Parallel deployments finished") to make log flow clearer when
output from both background jobs is interleaved
3. **Documentation**: Add "Requires" section to function header documenting
the namespace disjointness requirement
These changes improve debuggability and fail-fast behavior without changing
the core parallelization logic.1 parent b0560bc commit f631cd9
1 file changed
Lines changed: 12 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
647 | 647 | | |
648 | 648 | | |
649 | 649 | | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
650 | 653 | | |
651 | 654 | | |
652 | 655 | | |
653 | 656 | | |
654 | 657 | | |
655 | 658 | | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
| 663 | + | |
| 664 | + | |
656 | 665 | | |
| 666 | + | |
657 | 667 | | |
658 | 668 | | |
659 | 669 | | |
| |||
663 | 673 | | |
664 | 674 | | |
665 | 675 | | |
| 676 | + | |
666 | 677 | | |
667 | 678 | | |
668 | 679 | | |
| 680 | + | |
669 | 681 | | |
670 | 682 | | |
671 | 683 | | |
| |||
0 commit comments