fix(ci): bring plugin version values up to match default dynamic plugins#4153
Conversation
|
/test e2e-osd-gcp-helm-nightly |
|
/test e2e-gke-helm-nightly |
|
The image is available at: |
19cc1b0 to
7cadc1e
Compare
|
/test e2e-gke-helm-nightly |
|
🚫 Image Push Skipped. The container image push was skipped because the build was skipped (either due to [skip-build] tag or no relevant changes with existing image) |
7cadc1e to
9115513
Compare
|
🚫 Image Push Skipped. The container image push was skipped because the build was skipped (either due to [skip-build] tag or no relevant changes with existing image) |
|
/test e2e-gke-helm-nightly |
|
/test e2e-osd-gcp-helm-nightly |
|
/test e2e-osd-gcp-operator-nightly |
| disabled: false | ||
| # Enable orchestrator plugins - Official release (Backstage 1.45.3) | ||
| - package: "oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-orchestrator:bs_1.45.3__5.1.0!red-hat-developer-hub-backstage-plugin-orchestrator" | ||
| - package: "oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-orchestrator:bs_1.45.3__5.4.0!red-hat-developer-hub-backstage-plugin-orchestrator" |
There was a problem hiding this comment.
| - package: "oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-orchestrator:bs_1.45.3__5.4.0!red-hat-developer-hub-backstage-plugin-orchestrator" | |
| - package: 'oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-orchestrator:{{inherit}}' |
How about inheriting the version from the dynamic-plugins.default.yaml ? This {{inherit}} option was added in 1.9.0 (see https://issues.redhat.com/browse/RHIDP-8215) and I think it may help reduce the burden with these versions..
There was a problem hiding this comment.
looks really neat, lets try that
|
/test e2e-osd-gcp-helm-nightly |
|
The image is available at: |
2f4f3a2 to
2882192
Compare
2882192 to
5b20534
Compare
|
The image is available at: |
| url: http://sonataflow-platform-data-index-service | ||
|
|
||
| - package: "oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-orchestrator-form-widgets:bs_1.45.3__1.2.0!red-hat-developer-hub-backstage-plugin-orchestrator-form-widgets" | ||
| - package: "oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-orchestrator-form-widgets:{{inherit}}!red-hat-developer-hub-backstage-plugin-orchestrator-form-widgets" |
There was a problem hiding this comment.
Wondering why the Orchestrator plugins are defined here under global.dynamic.plugins and not under orchestrator.plugins..
See my similar comment in #4186 (comment)
Once redhat-developer/rhdh-chart#307 is merged, you may even be able to just unset orchestrator.plugins from the values files here.
There was a problem hiding this comment.
okay, nvm. As pointed out in #4186 (comment), it seems that the dynamic plugins definition in the values.yaml is used for both Helm and Operator deployments (which is a bit confusing IMO).
There was a problem hiding this comment.
One more point for separating the dynamic plugins from values.yaml to a ConfigMap
5b20534 to
cd42dd2
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
The image is available at: |
|
/test e2e-osd-gcp-helm-nightly |
ⓘ Your monthly quota for Qodo has expired. Upgrade your plan ⓘ Paying users. Check that your Qodo account is linked with this Git user account |
cd42dd2 to
adc7868
Compare
|
The image is available at: |
|
🚫 Image Push Skipped. The container image push was skipped because the build was skipped (either due to [skip-build] tag or no relevant changes with existing image) |
|
This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days. |
|
How is it going with this PR @jrichter1? |
15c3b38 to
923ce22
Compare
Signed-off-by: Jan Richter <jrichter@redhat.com>
923ce22 to
b4dac40
Compare
Signed-off-by: Jan Richter <jrichter@redhat.com>
|
|
/test e2e-osd-gcp-helm-nightly |
|
/test e2e-eks-helm-nightly |
|
@jrichter1: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ba8b9ec
into
redhat-developer:main
| # Scorecard - test ignored | ||
| # Test file: e2e-tests/playwright/e2e/plugins/scorecard/scorecard.spec.ts | ||
| - package: oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-scorecard:pr_1499__0.1.0!red-hat-developer-hub-backstage-plugin-scorecard | ||
| - package: oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-scorecard:bs_1.45.3__2.3.5!red-hat-developer-hub-backstage-plugin-scorecard |
There was a problem hiding this comment.
| - package: oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-scorecard:bs_1.45.3__2.3.5!red-hat-developer-hub-backstage-plugin-scorecard | |
| - package: oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/red-hat-developer-hub-backstage-plugin-scorecard:bs_1.45.3__2.3.5 |
Just discussed with Armel and Gennady, that it's safer for E2E tests to skip the exclamation mark in plugin definitions for now. You can try that for the cherry pick.
It specifies the directory inside the OCI image (to allow having more plugins in one image). If the folder name is the same as the plugin name, it can be safely skipped. We actually always have only one plugin per image so far.
…ins (redhat-developer#4153) * fix(ci): inherit plugin versions for showcase value files Signed-off-by: Jan Richter <jrichter@redhat.com> * inherit plugins in showcase diff Signed-off-by: Jan Richter <jrichter@redhat.com> --------- Signed-off-by: Jan Richter <jrichter@redhat.com>
…ins (redhat-developer#4153) * fix(ci): inherit plugin versions for showcase value files Signed-off-by: Jan Richter <jrichter@redhat.com> * inherit plugins in showcase diff Signed-off-by: Jan Richter <jrichter@redhat.com> --------- Signed-off-by: Jan Richter <jrichter@redhat.com>



Description
updates oci plugin versions in CI value files up to the same as in default dynamic plugins config
hopefully, it will fix the duplicate config errors in some of the jobs
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer